| Message ID | 20230917172520.46145-1-koba.ko@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 04e18c0dcbc108843b4e53075c55b873e2afb786 |
| Headers | show |
| Series | [BlueZ,V2] configure.ac: Add enable_btpclient and enable_mesh for internal ELL | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=785020 ---Test result--- Test Summary: CheckPatch PASS 0.51 seconds GitLint PASS 0.54 seconds BuildEll PASS 28.51 seconds BluezMake PASS 1007.29 seconds MakeCheck PASS 12.57 seconds MakeDistcheck PASS 161.74 seconds CheckValgrind PASS 262.90 seconds CheckSmatch PASS 353.86 seconds bluezmakeextell PASS 108.10 seconds IncrementalBuild PASS 867.01 seconds ScanBuild PASS 1096.14 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 18 Sep 2023 01:25:20 +0800 you wrote: > when checking enable_external_ell != 'yes', > even enable_btpclient and enable_mesh are not enabled. > configure still prompt the error. > Then ELL must be installed to pass the configure. > > Signed-off-by: Koba Ko <koba.ko@canonical.com> > ~~~ > V2: > * correct the wrong-spelling > * add BlueZ tag > * rephrase the commit description > * change the '&&' to '||' condition. > > [...] Here is the summary with links: - [BlueZ,V2] configure.ac: Add enable_btpclient and enable_mesh for internal ELL https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=04e18c0dcbc1 You are awesome, thank you!
diff --git a/configure.ac b/configure.ac index 4186c3792..54a609ad2 100644 --- a/configure.ac +++ b/configure.ac @@ -301,7 +301,8 @@ if (test "${enable_external_ell}" = "yes"); then AC_SUBST(ELL_CFLAGS) AC_SUBST(ELL_LIBS) fi -if (test "${enable_external_ell}" != "yes"); then +if (test "${enable_external_ell}" != "yes" && + (test "${enable_btpclient}" = "yes" || test "${enable_mesh}" = "yes")); then if (test ! -f ${srcdir}/ell/ell.h) && (test ! -f ${srcdir}/../ell/ell/ell.h); then AC_MSG_ERROR(ELL source is required or use --enable-external-ell)
when checking enable_external_ell != 'yes', even enable_btpclient and enable_mesh are not enabled. configure still prompt the error. Then ELL must be installed to pass the configure. Signed-off-by: Koba Ko <koba.ko@canonical.com> ~~~ V2: * correct the wrong-spelling * add BlueZ tag * rephrase the commit description * change the '&&' to '||' condition. --- configure.ac | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)