| Message ID | c0a206c000f475f50d7ee52825567fcd111568ee.1694164323.git.federico.serafini@bugseng.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [XEN] xen/vPCI: address violation of MISRA C:2012 Rule 8.3 | expand |
On 08/09/23 11:13, Federico Serafini wrote: > Make function declaration consistent with the corresponding definition. > No functional change. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> > --- > xen/include/xen/vpci.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h > index 0b8a2a3c74..d743d96a10 100644 > --- a/xen/include/xen/vpci.h > +++ b/xen/include/xen/vpci.h > @@ -26,7 +26,7 @@ typedef int vpci_register_init_t(struct pci_dev *dev); > __used_section(".data.vpci." p) = x > > /* Add vPCI handlers to device. */ > -int __must_check vpci_add_handlers(struct pci_dev *dev); > +int __must_check vpci_add_handlers(struct pci_dev *pdev); > > /* Remove all handlers and free vpci related structures. */ > void vpci_remove_device(struct pci_dev *pdev); Are there any chances of getting an ack?
On Fri, Sep 08, 2023 at 11:13:31AM +0200, Federico Serafini wrote: > Make function declaration consistent with the corresponding definition. > No functional change. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> Acked-by: Roger Pau Monné <roger.pau@citrix.com> Thanks, Roger.
diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index 0b8a2a3c74..d743d96a10 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -26,7 +26,7 @@ typedef int vpci_register_init_t(struct pci_dev *dev); __used_section(".data.vpci." p) = x /* Add vPCI handlers to device. */ -int __must_check vpci_add_handlers(struct pci_dev *dev); +int __must_check vpci_add_handlers(struct pci_dev *pdev); /* Remove all handlers and free vpci related structures. */ void vpci_remove_device(struct pci_dev *pdev);
Make function declaration consistent with the corresponding definition. No functional change. Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> --- xen/include/xen/vpci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)