Message ID | 20230919083553.35981-1-eagle.alexander923@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [v3,1/2] dt-bindings: stm32: document MYD-YA151C-T development board | expand |
On Tue, Sep 19, 2023 at 11:35:52AM +0300, Alexander Shiyan wrote: > Add new entry for MYD-YA151C-T development board. > > Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com> > --- > Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > index 4bf28e717a56..5252b9108ddc 100644 > --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > @@ -140,6 +140,11 @@ properties: > - const: engicam,microgea-stm32mp1 > - const: st,stm32mp157 > > + - description: MyirTech MYD-YA15XC-T SoM based Boards > + items: > + - const: myir,myd-ya151c-t # MYIR MYD-YA151C-T STM32MP151C > + - const: st,stm32mp151 It appears that this file is sorted by soc part number, which would put this entry now in the wrong location. With that changed, Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > + > - description: Octavo OSD32MP15x System-in-Package based boards > items: > - enum: > -- > 2.39.1 >
Hello. I looked through the entire file and saw that the entries were sorted by board name and by SOC part number within the board option. > On Tue, Sep 19, 2023 at 11:35:52AM +0300, Alexander Shiyan wrote: > > Add new entry for MYD-YA151C-T development board. ... > > diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > > index 4bf28e717a56..5252b9108ddc 100644 > > --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > > +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > > @@ -140,6 +140,11 @@ properties: > > - const: engicam,microgea-stm32mp1 > > - const: st,stm32mp157 > > > > + - description: MyirTech MYD-YA15XC-T SoM based Boards > > + items: > > + - const: myir,myd-ya151c-t # MYIR MYD-YA151C-T STM32MP151C > > + - const: st,stm32mp151 > > It appears that this file is sorted by soc part number, which would put > this entry now in the wrong location. > With that changed, > Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Fri, Oct 06, 2023 at 10:18:30AM +0300, Alexander Shiyan wrote: > Hello. > > On Tue, Sep 19, 2023 at 11:35:52AM +0300, Alexander Shiyan wrote: > > > Add new entry for MYD-YA151C-T development board. > ... > > > diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > > > index 4bf28e717a56..5252b9108ddc 100644 > > > --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > > > +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml > > > @@ -140,6 +140,11 @@ properties: > > > - const: engicam,microgea-stm32mp1 > > > - const: st,stm32mp157 > > > > > > + - description: MyirTech MYD-YA15XC-T SoM based Boards > > > + items: > > > + - const: myir,myd-ya151c-t # MYIR MYD-YA151C-T STM32MP151C > > > + - const: st,stm32mp151 > > > > It appears that this file is sorted by soc part number, which would put > > this entry now in the wrong location. > > With that changed, > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > I looked through the entire file and saw that the entries were > sorted by board name and by SOC part number within the board option. I must not be reading the same file you are. The one I looked a is sorted by the SoC compatibles ...mp135 ...mp151 ...mp153 ...mp157 and thereafter by boards.
diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml index 4bf28e717a56..5252b9108ddc 100644 --- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml +++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml @@ -140,6 +140,11 @@ properties: - const: engicam,microgea-stm32mp1 - const: st,stm32mp157 + - description: MyirTech MYD-YA15XC-T SoM based Boards + items: + - const: myir,myd-ya151c-t # MYIR MYD-YA151C-T STM32MP151C + - const: st,stm32mp151 + - description: Octavo OSD32MP15x System-in-Package based boards items: - enum:
Add new entry for MYD-YA151C-T development board. Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com> --- Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 5 +++++ 1 file changed, 5 insertions(+)