diff mbox series

[isar-cip-core] bbb.wks: Add fsuuid value to the rootfs device

Message ID 20230920054357.7957-1-venkata.pyla@toshiba-tsip.com (mailing list archive)
State Accepted
Headers show
Series [isar-cip-core] bbb.wks: Add fsuuid value to the rootfs device | expand

Commit Message

Venkata Pyla Sept. 20, 2023, 5:43 a.m. UTC
From: venkata pyla <venkata.pyla@toshiba-tsip.com>

The filesystem images are not reproducible because the partition UUID
values is generated randomly.

To fix this assigned fixed UUID value to partition.

Fixes: #77

Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
---
 wic/bbb.wks | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Kiszka Sept. 20, 2023, 5:46 a.m. UTC | #1
On 20.09.23 07:43, venkata.pyla@toshiba-tsip.com wrote:
> From: venkata pyla <venkata.pyla@toshiba-tsip.com>
> 
> The filesystem images are not reproducible because the partition UUID
> values is generated randomly.
> 
> To fix this assigned fixed UUID value to partition.
> 
> Fixes: #77
> 
> Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
> ---
>  wic/bbb.wks | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/wic/bbb.wks b/wic/bbb.wks
> index 6131c78..a797e95 100644
> --- a/wic/bbb.wks
> +++ b/wic/bbb.wks
> @@ -9,6 +9,6 @@
>  part --source rawcopy --sourceparams "file=/usr/lib/u-boot/bbb/MLO" --no-table --align 128
>  part --source rawcopy --sourceparams "file=/usr/lib/u-boot/bbb/u-boot.img" --no-table --align 384
>  
> -part / --source rootfs-u-boot --ondisk mmcblk0 --fstype ext4 --mkfs-extraopts "-T default" --label platform --align 1024 --active
> +part / --source rootfs-u-boot --ondisk mmcblk0 --fstype ext4 --mkfs-extraopts "-T default" --label platform --align 1024 --active --fsuuid 1f55d66a-40d8-11ee-be56-0242ac120002
>  
>  bootloader --append "rootwait console=ttyO0,115200"

Thanks, applied.

But at that pace, we may see many more such patches. Should be do this
once now for all our targets?

Jan
Venkata Pyla Sept. 20, 2023, 6:07 a.m. UTC | #2
>-----Original Message-----
>From: Jan Kiszka <jan.kiszka@siemens.com>
>Sent: Wednesday, September 20, 2023 11:16 AM
>To: pyla venkata(TSIP TMIEC ODG Porting) <Venkata.Pyla@toshiba-
>tsip.com>; cip-dev@lists.cip-project.org
>Cc: dinesh kumar(TSIP TMIEC ODG Porting) <dinesh.kumar@toshiba-
>tsip.com>; hayashi kazuhiro(林 和宏 DME ○DIG□MPS○MP4)
><kazuhiro3.hayashi@toshiba.co.jp>
>Subject: Re: [isar-cip-core] bbb.wks: Add fsuuid value to the rootfs device
>
>On 20.09.23 07:43, venkata.pyla@toshiba-tsip.com wrote:
>> From: venkata pyla <venkata.pyla@toshiba-tsip.com>
>>
>> The filesystem images are not reproducible because the partition UUID
>> values is generated randomly.
>>
>> To fix this assigned fixed UUID value to partition.
>>
>> Fixes: #77
>>
>> Signed-off-by: venkata pyla <venkata.pyla@toshiba-tsip.com>
>> ---
>>  wic/bbb.wks | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/wic/bbb.wks b/wic/bbb.wks index 6131c78..a797e95 100644
>> --- a/wic/bbb.wks
>> +++ b/wic/bbb.wks
>> @@ -9,6 +9,6 @@
>>  part --source rawcopy --sourceparams "file=/usr/lib/u-boot/bbb/MLO"
>> --no-table --align 128  part --source rawcopy --sourceparams
>> "file=/usr/lib/u-boot/bbb/u-boot.img" --no-table --align 384
>>
>> -part / --source rootfs-u-boot --ondisk mmcblk0 --fstype ext4
>> --mkfs-extraopts "-T default" --label platform --align 1024 --active
>> +part / --source rootfs-u-boot --ondisk mmcblk0 --fstype ext4
>> +--mkfs-extraopts "-T default" --label platform --align 1024 --active
>> +--fsuuid 1f55d66a-40d8-11ee-be56-0242ac120002
>>
>>  bootloader --append "rootwait console=ttyO0,115200"
>
>Thanks, applied.
>
>But at that pace, we may see many more such patches. Should be do this once
>now for all our targets?

Sure, I will send another patch with fixing other targets as well.

>
>Jan
>
>--
>Siemens AG, Technology
>Linux Expert Center
diff mbox series

Patch

diff --git a/wic/bbb.wks b/wic/bbb.wks
index 6131c78..a797e95 100644
--- a/wic/bbb.wks
+++ b/wic/bbb.wks
@@ -9,6 +9,6 @@ 
 part --source rawcopy --sourceparams "file=/usr/lib/u-boot/bbb/MLO" --no-table --align 128
 part --source rawcopy --sourceparams "file=/usr/lib/u-boot/bbb/u-boot.img" --no-table --align 384
 
-part / --source rootfs-u-boot --ondisk mmcblk0 --fstype ext4 --mkfs-extraopts "-T default" --label platform --align 1024 --active
+part / --source rootfs-u-boot --ondisk mmcblk0 --fstype ext4 --mkfs-extraopts "-T default" --label platform --align 1024 --active --fsuuid 1f55d66a-40d8-11ee-be56-0242ac120002
 
 bootloader --append "rootwait console=ttyO0,115200"