| Message ID | 20230920085715.6905-1-tvrtko.ursulin@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Zap some empty lines | expand |
On Wed, 20 Sep 2023, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Recent refactoring left an unsightly block of empty lines. Remove them. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com> > Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com> One of the harder patches I've reviewed this week. Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/i915_drv.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 87ffc477c3b1..511eba3bbdba 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -646,13 +646,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, > #define IS_TIGERLAKE_UY(i915) \ > IS_SUBPLATFORM(i915, INTEL_TIGERLAKE, INTEL_SUBPLATFORM_UY) > > - > - > - > - > - > - > - > #define IS_XEHPSDV_GRAPHICS_STEP(__i915, since, until) \ > (IS_XEHPSDV(__i915) && IS_GRAPHICS_STEP(__i915, since, until))
> -----Original Message----- > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Tvrtko > Ursulin > Sent: Wednesday, September 20, 2023 2:27 PM > To: Intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Srivatsa, Anusha <anusha.srivatsa@intel.com>; Bhadane, Dnyaneshwar > <dnyaneshwar.bhadane@intel.com>; Sripada, Radhakrishna > <radhakrishna.sripada@intel.com>; Ursulin, Tvrtko <tvrtko.ursulin@intel.com> > Subject: [PATCH] drm/i915: Zap some empty lines > > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Recent refactoring left an unsightly block of empty lines. Remove them. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com> > Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com> LGTM, Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > --- > drivers/gpu/drm/i915/i915_drv.h | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 87ffc477c3b1..511eba3bbdba 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -646,13 +646,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, > #define IS_TIGERLAKE_UY(i915) \ > IS_SUBPLATFORM(i915, INTEL_TIGERLAKE, INTEL_SUBPLATFORM_UY) > > - > - > - > - > - > - > - > #define IS_XEHPSDV_GRAPHICS_STEP(__i915, since, until) \ > (IS_XEHPSDV(__i915) && IS_GRAPHICS_STEP(__i915, since, until)) > > -- > 2.39.2
Hi Tvrtko, On Wed, Sep 20, 2023 at 09:57:15AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Recent refactoring left an unsightly block of empty lines. Remove them. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com> > Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com> as this isn't merged yet: Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi
On 25/09/2023 15:14, Andi Shyti wrote: > Hi Tvrtko, > > On Wed, Sep 20, 2023 at 09:57:15AM +0100, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >> >> Recent refactoring left an unsightly block of empty lines. Remove them. >> >> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> >> Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> >> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com> >> Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > > as this isn't merged yet: > > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thanks, I am catching up with things and this wasn't so important. If you have a spare moment feel free to push it? Regards, Tvrtko
Hi Tvrtko, On Mon, Sep 25, 2023 at 03:28:27PM +0100, Tvrtko Ursulin wrote: > > On 25/09/2023 15:14, Andi Shyti wrote: > > Hi Tvrtko, > > > > On Wed, Sep 20, 2023 at 09:57:15AM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > > > > > Recent refactoring left an unsightly block of empty lines. Remove them. > > > > > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > > Cc: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com> > > > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com> > > > Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com> > > > > as this isn't merged yet: > > > > Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> > > Thanks, I am catching up with things and this wasn't so important. If you > have a spare moment feel free to push it? All right, pushed to drm-intel-next :) Thanks, Andi
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 87ffc477c3b1..511eba3bbdba 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h @@ -646,13 +646,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, #define IS_TIGERLAKE_UY(i915) \ IS_SUBPLATFORM(i915, INTEL_TIGERLAKE, INTEL_SUBPLATFORM_UY) - - - - - - - #define IS_XEHPSDV_GRAPHICS_STEP(__i915, since, until) \ (IS_XEHPSDV(__i915) && IS_GRAPHICS_STEP(__i915, since, until))