| Message ID | 20230824091345.1072650-1-yangyingliang@huawei.com |
|---|---|
| State | Accepted |
| Commit | 5f7cd740a6b657fba775bde744496e5ed21851ca |
| Headers | show |
| Series | [-next] phy: qcom: phy-qcom-m31: fix wrong pointer pass to PTR_ERR() | expand |
On Thu, Aug 24, 2023 at 05:13:45PM +0800, Yang Yingliang wrote: > It should be 'qphy->vreg' passed to PTR_ERR() when devm_regulator_get() fails. > > Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/phy/qualcomm/phy-qcom-m31.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c > index ed08072ca032..99d570f4142a 100644 > --- a/drivers/phy/qualcomm/phy-qcom-m31.c > +++ b/drivers/phy/qualcomm/phy-qcom-m31.c > @@ -256,7 +256,7 @@ static int m31usb_phy_probe(struct platform_device *pdev) > > qphy->vreg = devm_regulator_get(dev, "vdda-phy"); > if (IS_ERR(qphy->vreg)) > - return dev_err_probe(dev, PTR_ERR(qphy->phy), > + return dev_err_probe(dev, PTR_ERR(qphy->vreg), > "failed to get vreg\n"); Reviewed-by: Varadarajan Narayanan <quic_varada@quicinc.com> Thanks Varada > > phy_set_drvdata(qphy->phy, qphy); > -- > 2.25.1 >
On Thu, 24 Aug 2023 17:13:45 +0800, Yang Yingliang wrote: > It should be 'qphy->vreg' passed to PTR_ERR() when devm_regulator_get() fails. > > Applied, thanks! [1/1] phy: qcom: phy-qcom-m31: fix wrong pointer pass to PTR_ERR() commit: 5f7cd740a6b657fba775bde744496e5ed21851ca Best regards,
diff --git a/drivers/phy/qualcomm/phy-qcom-m31.c b/drivers/phy/qualcomm/phy-qcom-m31.c index ed08072ca032..99d570f4142a 100644 --- a/drivers/phy/qualcomm/phy-qcom-m31.c +++ b/drivers/phy/qualcomm/phy-qcom-m31.c @@ -256,7 +256,7 @@ static int m31usb_phy_probe(struct platform_device *pdev) qphy->vreg = devm_regulator_get(dev, "vdda-phy"); if (IS_ERR(qphy->vreg)) - return dev_err_probe(dev, PTR_ERR(qphy->phy), + return dev_err_probe(dev, PTR_ERR(qphy->vreg), "failed to get vreg\n"); phy_set_drvdata(qphy->phy, qphy);
It should be 'qphy->vreg' passed to PTR_ERR() when devm_regulator_get() fails. Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver") Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/phy/qualcomm/phy-qcom-m31.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)