| Message ID | 1695218113-31198-3-git-send-email-quic_msarkar@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | arm64: qcom: sa8775p: add support for EP PCIe | expand |
On 9/20/23 15:55, Mrinmay Sarkar wrote: > Add support for SA8775P SoC to the Qualcomm PCIe Endpoint Controller > driver. > > Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com> > --- This compatible does not bring anything new to the table on its own. Please create a fallback compatible, document it in the bindings and use that. See [1] and [2] for example. Konrad [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml?h=next-20230920 [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/pm7550ba.dtsi?h=next-20230920#n65
On Wed, Sep 20, 2023 at 04:24:30PM +0200, Konrad Dybcio wrote: > > > On 9/20/23 15:55, Mrinmay Sarkar wrote: > > Add support for SA8775P SoC to the Qualcomm PCIe Endpoint Controller > > driver. > > > > Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com> > > --- > This compatible does not bring anything new to the table > on its own. Please create a fallback compatible, document it > in the bindings and use that. See [1] and [2] for example. > Ack. - Mani > Konrad > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml?h=next-20230920 > > [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/pm7550ba.dtsi?h=next-20230920#n65
On 9/20/2023 7:54 PM, Konrad Dybcio wrote: > > > On 9/20/23 15:55, Mrinmay Sarkar wrote: >> Add support for SA8775P SoC to the Qualcomm PCIe Endpoint Controller >> driver. >> >> Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com> >> --- > This compatible does not bring anything new to the table > on its own. Please create a fallback compatible, document it > in the bindings and use that. See [1] and [2] for example. > > Konrad > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml?h=next-20230920 > > [2] > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/pm7550ba.dtsi?h=next-20230920#n65 Hi Konrad, yes as of now this compatible does not bring anything new to the table. recently we got additional feature regarding cache coherency for sa8775p for that we need to add change only for sa8775p. that's why we need to add the compatible for sa8775p. and I will be uploading patch for that in some days. Thanks, Mrinmay
diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c index 8bd8107..be14c5e 100644 --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c @@ -877,6 +877,7 @@ static void qcom_pcie_ep_remove(struct platform_device *pdev) } static const struct of_device_id qcom_pcie_ep_match[] = { + { .compatible = "qcom,sa8775p-pcie-ep", }, { .compatible = "qcom,sdx55-pcie-ep", }, { .compatible = "qcom,sm8450-pcie-ep", }, { }
Add support for SA8775P SoC to the Qualcomm PCIe Endpoint Controller driver. Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com> --- drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + 1 file changed, 1 insertion(+)