mbox series

[v4,0/2] media: Add onsemi MT9M114 camera sensor driver

Message ID 20230920171155.7648-1-laurent.pinchart@ideasonboard.com (mailing list archive)
Headers show
Series media: Add onsemi MT9M114 camera sensor driver | expand

Message

Laurent Pinchart Sept. 20, 2023, 5:11 p.m. UTC
Hello,

This series adds a driver for the onsemi MT9M114 camera sensor. It's all
a pretty standard story, DT bindings are in 1/2, and the driver in 2/2.
Review comments from v3 have all been taken into account as far as I can
tell.

The driver has been tested with an i.MX8MM in CSI-2 mode. Jacopo tested
v2 in parallel mode, but given the number of changes in v3, I haven't
kept the Tested-by tag.

Laurent Pinchart (2):
  media: dt-bindings: media: i2c: Add MT9M114 camera sensor binding
  media: i2c: Add driver for onsemi MT9M114 camera sensor

 .../bindings/media/i2c/onnn,mt9m114.yaml      |  114 +
 MAINTAINERS                                   |    8 +
 drivers/media/i2c/Kconfig                     |   10 +
 drivers/media/i2c/Makefile                    |    1 +
 drivers/media/i2c/mt9m114.c                   | 2481 +++++++++++++++++
 5 files changed, 2614 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
 create mode 100644 drivers/media/i2c/mt9m114.c


base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d

Comments

Laurent Pinchart Sept. 24, 2023, 2:47 p.m. UTC | #1
Hi Hans,

FYI, as the atomisp driver has an mt9m114 driver. There's certainly no
urgency to replace it, but if you have a machine on which you could test
this driver, it could be nice at some point in the future. Any issue you
encounter can be fixed on top of this series (in particular, dynamically
computing the PLL configuration would be very nice).

On Wed, Sep 20, 2023 at 08:11:52PM +0300, Laurent Pinchart wrote:
> Hello,
> 
> This series adds a driver for the onsemi MT9M114 camera sensor. It's all
> a pretty standard story, DT bindings are in 1/2, and the driver in 2/2.
> Review comments from v3 have all been taken into account as far as I can
> tell.
> 
> The driver has been tested with an i.MX8MM in CSI-2 mode. Jacopo tested
> v2 in parallel mode, but given the number of changes in v3, I haven't
> kept the Tested-by tag.
> 
> Laurent Pinchart (2):
>   media: dt-bindings: media: i2c: Add MT9M114 camera sensor binding
>   media: i2c: Add driver for onsemi MT9M114 camera sensor
> 
>  .../bindings/media/i2c/onnn,mt9m114.yaml      |  114 +
>  MAINTAINERS                                   |    8 +
>  drivers/media/i2c/Kconfig                     |   10 +
>  drivers/media/i2c/Makefile                    |    1 +
>  drivers/media/i2c/mt9m114.c                   | 2481 +++++++++++++++++
>  5 files changed, 2614 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
>  create mode 100644 drivers/media/i2c/mt9m114.c
> 
> 
> base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
Hans de Goede Sept. 28, 2023, 3:09 p.m. UTC | #2
Hi,

On 9/24/23 16:47, Laurent Pinchart wrote:
> Hi Hans,
> 
> FYI, as the atomisp driver has an mt9m114 driver. There's certainly no
> urgency to replace it, but if you have a machine on which you could test
> this driver, it could be nice at some point in the future. Any issue you
> encounter can be fixed on top of this series (in particular, dynamically
> computing the PLL configuration would be very nice).

Ok, so I just checked and I believe that the Asus T100TA indeed has
the MT9M114 sensor. So I'll try to give this a test run with atomisp
when I can make / find some time to do so.

Regards,

Hans



> 
> On Wed, Sep 20, 2023 at 08:11:52PM +0300, Laurent Pinchart wrote:
>> Hello,
>>
>> This series adds a driver for the onsemi MT9M114 camera sensor. It's all
>> a pretty standard story, DT bindings are in 1/2, and the driver in 2/2.
>> Review comments from v3 have all been taken into account as far as I can
>> tell.
>>
>> The driver has been tested with an i.MX8MM in CSI-2 mode. Jacopo tested
>> v2 in parallel mode, but given the number of changes in v3, I haven't
>> kept the Tested-by tag.
>>
>> Laurent Pinchart (2):
>>   media: dt-bindings: media: i2c: Add MT9M114 camera sensor binding
>>   media: i2c: Add driver for onsemi MT9M114 camera sensor
>>
>>  .../bindings/media/i2c/onnn,mt9m114.yaml      |  114 +
>>  MAINTAINERS                                   |    8 +
>>  drivers/media/i2c/Kconfig                     |   10 +
>>  drivers/media/i2c/Makefile                    |    1 +
>>  drivers/media/i2c/mt9m114.c                   | 2481 +++++++++++++++++
>>  5 files changed, 2614 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/media/i2c/onnn,mt9m114.yaml
>>  create mode 100644 drivers/media/i2c/mt9m114.c
>>
>>
>> base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
>