| Message ID | 1695612152-123633-1-git-send-email-renyu.zj@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | perf/arm-cmn: Fix the unhandled overflow status of counter 4 to 7 | expand |
On 2023-09-25 04:22, Jing Zhang wrote: > The register por_dt_pmovsr Bits[7:0] indicates overflow from counters 7 > to 0. But in arm_cmn_handle_irq(), only handled the overflow status of > Bits[3:0] which results in unhandled overflow status of counters 4 to 7. > > So let the overflow status of DTC counters 4 to 7 to be handled. Oh dear goodness, how has such a stupid typo managed to exist for 4 years? Truly this is a brown paper bag moment... :( Reviewed-by: Robin Murphy <robin.murphy@arm.com> > Fixes: 0ba64770a2f2 ("perf: Add Arm CMN-600 PMU driver") > Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com> > --- > drivers/perf/arm-cmn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c > index 913dc04..6b50bc5 100644 > --- a/drivers/perf/arm-cmn.c > +++ b/drivers/perf/arm-cmn.c > @@ -1972,7 +1972,7 @@ static irqreturn_t arm_cmn_handle_irq(int irq, void *dev_id) > u64 delta; > int i; > > - for (i = 0; i < CMN_DTM_NUM_COUNTERS; i++) { > + for (i = 0; i < CMN_DT_NUM_COUNTERS; i++) { > if (status & (1U << i)) { > ret = IRQ_HANDLED; > if (WARN_ON(!dtc->counters[i]))
On Mon, 25 Sep 2023 11:22:32 +0800, Jing Zhang wrote: > The register por_dt_pmovsr Bits[7:0] indicates overflow from counters 7 > to 0. But in arm_cmn_handle_irq(), only handled the overflow status of > Bits[3:0] which results in unhandled overflow status of counters 4 to 7. > > So let the overflow status of DTC counters 4 to 7 to be handled. > > > [...] Applied to arm64 (for-next/fixes), thanks! [1/1] perf/arm-cmn: Fix the unhandled overflow status of counter 4 to 7 https://git.kernel.org/arm64/c/7f949f6f54ff Cheers,
diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c index 913dc04..6b50bc5 100644 --- a/drivers/perf/arm-cmn.c +++ b/drivers/perf/arm-cmn.c @@ -1972,7 +1972,7 @@ static irqreturn_t arm_cmn_handle_irq(int irq, void *dev_id) u64 delta; int i; - for (i = 0; i < CMN_DTM_NUM_COUNTERS; i++) { + for (i = 0; i < CMN_DT_NUM_COUNTERS; i++) { if (status & (1U << i)) { ret = IRQ_HANDLED; if (WARN_ON(!dtc->counters[i]))
The register por_dt_pmovsr Bits[7:0] indicates overflow from counters 7 to 0. But in arm_cmn_handle_irq(), only handled the overflow status of Bits[3:0] which results in unhandled overflow status of counters 4 to 7. So let the overflow status of DTC counters 4 to 7 to be handled. Fixes: 0ba64770a2f2 ("perf: Add Arm CMN-600 PMU driver") Signed-off-by: Jing Zhang <renyu.zj@linux.alibaba.com> --- drivers/perf/arm-cmn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)