docs: admin-guide: sysctl: fix details of struct dentry_stat_t

Commit Message

Randy Dunlap Sept. 23, 2023, 7:51 p.m. UTC

Commit c8c0c239d5ab moved struct dentry_stat_t to fs/dcache.c but
did not update its location in Documentation, so update that now.
Also change each struct member from int to long as done in
commit 3942c07ccf98.

Fixes: c8c0c239d5ab ("fs: move dcache sysctls to its own file")
Fixes: 3942c07ccf98 ("fs: bump inode and dentry counters to long")
Signed-off-by: Randy Dunlap <[e-mail]>
Cc: Jonathan Corbet <[e-mail]>
Cc: [e-mail]
Cc: Alexander Viro <[e-mail]>
Cc: Christian Brauner <[e-mail]>
Cc: [e-mail]
Cc: Luis Chamberlain <[e-mail]>
Cc: Arnd Bergmann <[e-mail]>
Cc: Glauber Costa <[e-mail]>
---
 Documentation/admin-guide/sysctl/fs.rst |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

Christian Brauner Sept. 25, 2023, 12:50 p.m. UTC | #1

On Sat, Sep 23, 2023 at 12:51:44PM -0700, Randy Dunlap wrote:
> Commit c8c0c239d5ab moved struct dentry_stat_t to fs/dcache.c but
> did not update its location in Documentation, so update that now.
> Also change each struct member from int to long as done in
> commit 3942c07ccf98.
> 
> Fixes: c8c0c239d5ab ("fs: move dcache sysctls to its own file")
> Fixes: 3942c07ccf98 ("fs: bump inode and dentry counters to long")
> Signed-off-by: Randy Dunlap <[e-mail]>
> Cc: Jonathan Corbet <[e-mail]>
> Cc: [e-mail]
> Cc: Alexander Viro <[e-mail]>
> Cc: Christian Brauner <[e-mail]>
> Cc: [e-mail]
> Cc: Luis Chamberlain <[e-mail]>
> Cc: Arnd Bergmann <[e-mail]>
> Cc: Glauber Costa <[e-mail]>
> ---

Acked-by: Christian Brauner <[e-mail]>

Jonathan Corbet Oct. 3, 2023, 3:28 p.m. UTC | #2

Randy Dunlap <[e-mail]> writes:

> Commit c8c0c239d5ab moved struct dentry_stat_t to fs/dcache.c but
> did not update its location in Documentation, so update that now.
> Also change each struct member from int to long as done in
> commit 3942c07ccf98.
>
> Fixes: c8c0c239d5ab ("fs: move dcache sysctls to its own file")
> Fixes: 3942c07ccf98 ("fs: bump inode and dentry counters to long")
> Signed-off-by: Randy Dunlap <[e-mail]>
> Cc: Jonathan Corbet <[e-mail]>
> Cc: [e-mail]
> Cc: Alexander Viro <[e-mail]>
> Cc: Christian Brauner <[e-mail]>
> Cc: [e-mail]
> Cc: Luis Chamberlain <[e-mail]>
> Cc: Arnd Bergmann <[e-mail]>
> Cc: Glauber Costa <[e-mail]>
> ---
>  Documentation/admin-guide/sysctl/fs.rst |   16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff -- a/Documentation/admin-guide/sysctl/fs.rst b/Documentation/admin-guide/sysctl/fs.rst
> --- a/Documentation/admin-guide/sysctl/fs.rst
> +++ b/Documentation/admin-guide/sysctl/fs.rst
> @@ -42,16 +42,16 @@ pre-allocation or re-sizing of any kerne
>  dentry-state
>  ------------
>  
> -This file shows the values in ``struct dentry_stat``, as defined in
> -``linux/include/linux/dcache.h``::
> +This file shows the values in ``struct dentry_stat_t``, as defined in
> +``fs/dcache.c``::

Applied, thanks.

jon

Patch

diff -- a/Documentation/admin-guide/sysctl/fs.rst b/Documentation/admin-guide/sysctl/fs.rst
--- a/Documentation/admin-guide/sysctl/fs.rst
+++ b/Documentation/admin-guide/sysctl/fs.rst
@@ -42,16 +42,16 @@  pre-allocation or re-sizing of any kerne
 dentry-state
 ------------
 
-This file shows the values in ``struct dentry_stat``, as defined in
-``linux/include/linux/dcache.h``::
+This file shows the values in ``struct dentry_stat_t``, as defined in
+``fs/dcache.c``::
 
   struct dentry_stat_t dentry_stat {
-        int nr_dentry;
-        int nr_unused;
-        int age_limit;         /* age in seconds */
-        int want_pages;        /* pages requested by system */
-        int nr_negative;       /* # of unused negative dentries */
-        int dummy;             /* Reserved for future use */
+        long nr_dentry;
+        long nr_unused;
+        long age_limit;         /* age in seconds */
+        long want_pages;        /* pages requested by system */
+        long nr_negative;       /* # of unused negative dentries */
+        long dummy;             /* Reserved for future use */
   };
 
 Dentries are dynamically allocated and deallocated.