mbox series

[0/8] iommu: Clean up map/unmap ops

Message ID cover.1694525662.git.robin.murphy@arm.com (mailing list archive)
Headers show
Series iommu: Clean up map/unmap ops | expand

Message

Robin Murphy Sept. 12, 2023, 4:18 p.m. UTC
Hi all,

Time to repay a little more from the technical debt pile and actually
finalise another of our half-finished API evolutions, since it turned
out that by now this was dead simple. So much so in fact that I'm in
two minds whether to squash all the driver patches into one or not, as
they're so very mechanical.

Note that the sun50i patch is just a placeholder to make a consistent
series for now, as I'm anticipating a "proper" implementation from
Jernej.

Thanks,
Robin.


Robin Murphy (8):
  iommu/exynos: Update to {map,unmap}_pages
  iommu/omap: Update to {map,unmap}_pages
  iommu/rockchip: Update to {map,unmap}_pages
  iommu/sun50i: Update to {map,unmap}_pages
  iommu/tegra-gart: Update to {map,unmap}_pages
  iommu/tegra-smmu: Update to {map,unmap}_pages
  iommu: Retire map/unmap ops
  iommu: Improve map/unmap sanity checks

 drivers/iommu/exynos-iommu.c   | 10 +++---
 drivers/iommu/iommu.c          | 66 +++++++++-------------------------
 drivers/iommu/omap-iommu.c     | 11 +++---
 drivers/iommu/rockchip-iommu.c | 11 +++---
 drivers/iommu/sun50i-iommu.c   | 10 +++---
 drivers/iommu/tegra-gart.c     | 12 ++++---
 drivers/iommu/tegra-smmu.c     | 12 ++++---
 include/linux/iommu.h          |  6 ----
 8 files changed, 58 insertions(+), 80 deletions(-)

Comments

Joerg Roedel Sept. 25, 2023, 10:05 a.m. UTC | #1
On Tue, Sep 12, 2023 at 05:18:36PM +0100, Robin Murphy wrote:
> Robin Murphy (8):
>   iommu/exynos: Update to {map,unmap}_pages
>   iommu/omap: Update to {map,unmap}_pages
>   iommu/rockchip: Update to {map,unmap}_pages
>   iommu/sun50i: Update to {map,unmap}_pages
>   iommu/tegra-gart: Update to {map,unmap}_pages
>   iommu/tegra-smmu: Update to {map,unmap}_pages
>   iommu: Retire map/unmap ops
>   iommu: Improve map/unmap sanity checks

Applied all except the tegra-gart patch. Tegra-gart has been removed by
Jason in a previous patch. Thanks Robin.
Jernej Škrabec Sept. 25, 2023, 3:33 p.m. UTC | #2
Dne ponedeljek, 25. september 2023 ob 12:05:35 CEST je Joerg Roedel napisal(a):
> On Tue, Sep 12, 2023 at 05:18:36PM +0100, Robin Murphy wrote:
> > Robin Murphy (8):
> >   iommu/exynos: Update to {map,unmap}_pages
> >   iommu/omap: Update to {map,unmap}_pages
> >   iommu/rockchip: Update to {map,unmap}_pages
> >   iommu/sun50i: Update to {map,unmap}_pages
> >   iommu/tegra-gart: Update to {map,unmap}_pages
> >   iommu/tegra-smmu: Update to {map,unmap}_pages
> >   iommu: Retire map/unmap ops
> >   iommu: Improve map/unmap sanity checks
> 
> Applied all except the tegra-gart patch. Tegra-gart has been removed by
> Jason in a previous patch. Thanks Robin.

sun50i is meant to be placeholder (as mentioned in cover letter). It's
replaced by:
https://lore.kernel.org/linux-sunxi/20230912181941.2971036-1-jernej.skrabec@gmail.com/

But I didn't get any feedback if it's ok or there is anything to fix.

Best regards,
Jernej
Joerg Roedel Sept. 26, 2023, 9:23 a.m. UTC | #3
On Mon, Sep 25, 2023 at 05:33:58PM +0200, Jernej Škrabec wrote:
> sun50i is meant to be placeholder (as mentioned in cover letter). It's
> replaced by:
> https://lore.kernel.org/linux-sunxi/20230912181941.2971036-1-jernej.skrabec@gmail.com/

Is the placeholder patch actually breaking the driver or just not
optimal yet?

Regards,

	Joerg
Robin Murphy Sept. 26, 2023, 12:01 p.m. UTC | #4
On 26/09/2023 10:23 am, Joerg Roedel wrote:
> On Mon, Sep 25, 2023 at 05:33:58PM +0200, Jernej Škrabec wrote:
>> sun50i is meant to be placeholder (as mentioned in cover letter). It's
>> replaced by:
>> https://lore.kernel.org/linux-sunxi/20230912181941.2971036-1-jernej.skrabec@gmail.com/
> 
> Is the placeholder patch actually breaking the driver or just not
> optimal yet?

No functional issue, and TBH I think there's no harm in avoiding the 
dependency (I was kind of assuming you would pick this series to the 
core branch, so the "placeholder" status might extend that far too) - it 
should just mean that when you pick Jernej's patch to a topic branch 
you'll get a conflict merging it to core, and the correct resolution 
will be to take everything from that branch and replace my patch.

Cheers,
Robin.
Joerg Roedel Sept. 26, 2023, 2:57 p.m. UTC | #5
On Tue, Sep 26, 2023 at 01:01:28PM +0100, Robin Murphy wrote:
> No functional issue, and TBH I think there's no harm in avoiding the
> dependency (I was kind of assuming you would pick this series to the core
> branch, so the "placeholder" status might extend that far too) - it should
> just mean that when you pick Jernej's patch to a topic branch you'll get a
> conflict merging it to core, and the correct resolution will be to take
> everything from that branch and replace my patch.

Alright, thanks for clarifying. I hereby ask Jernej to base his new
patch on the core branch, once I published it (which should be later
today).

Regards,

	Joerg