| Message ID | 20230921143604.6561-7-jo.vanbulck@cs.kuleuven.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | selftests/sgx: Fix compilation errors | expand |
On Thu Sep 21, 2023 at 5:35 PM EEST, Jo Van Bulck wrote: > Remove redundant push/pop pair that stores and restores the enclave base > address in the test enclave, as it is never used after the pop and can > anyway be easily retrieved via the __encl_base symbol. > > Signed-off-by: Jo Van Bulck <jo.vanbulck@cs.kuleuven.be> > Acked-by: Kai Huang <kai.huang@intel.com> > --- > tools/testing/selftests/sgx/test_encl_bootstrap.S | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/testing/selftests/sgx/test_encl_bootstrap.S b/tools/testing/selftests/sgx/test_encl_bootstrap.S > index 03ae0f57e29d..e0ce993d3f2c 100644 > --- a/tools/testing/selftests/sgx/test_encl_bootstrap.S > +++ b/tools/testing/selftests/sgx/test_encl_bootstrap.S > @@ -55,12 +55,9 @@ encl_entry_core: > push %rax > > push %rcx # push the address after EENTER > - push %rbx # push the enclave base address > > call encl_body > > - pop %rbx # pop the enclave base address > - > /* Clear volatile GPRs, except RAX (EEXIT function). */ > xor %rcx, %rcx > xor %rdx, %rdx > -- > 2.25.1 Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> BR, Jarkko
diff --git a/tools/testing/selftests/sgx/test_encl_bootstrap.S b/tools/testing/selftests/sgx/test_encl_bootstrap.S index 03ae0f57e29d..e0ce993d3f2c 100644 --- a/tools/testing/selftests/sgx/test_encl_bootstrap.S +++ b/tools/testing/selftests/sgx/test_encl_bootstrap.S @@ -55,12 +55,9 @@ encl_entry_core: push %rax push %rcx # push the address after EENTER - push %rbx # push the enclave base address call encl_body - pop %rbx # pop the enclave base address - /* Clear volatile GPRs, except RAX (EEXIT function). */ xor %rcx, %rcx xor %rdx, %rdx