| Message ID | b8b1a3f0-3aca-341c-07ee-389b077a01f7@redhat.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | platform/x86: int3472: don't use gpiod_toggle_active_low() | expand |
On Thu, Sep 28, 2023 at 02:42:50PM +0200, Hans de Goede wrote: > Add a new skl_int3472_gpiod_get_from_temp_lookup() helper. > > This is a preparation patch for removing usage of the deprecated > gpiod_toggle_active_low() and acpi_get_and_request_gpiod() functions. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > [hdegoede@redhat.com] use the new skl_int3472_fill_gpiod_lookup() helper > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Something wrong between authorship and committer and SoB chain. I believe you need to preserve the authorship and add yourself as Co-developed-by: ?
Hi, On 10/1/23 10:42, Andy Shevchenko wrote: > On Thu, Sep 28, 2023 at 02:42:50PM +0200, Hans de Goede wrote: >> Add a new skl_int3472_gpiod_get_from_temp_lookup() helper. >> >> This is a preparation patch for removing usage of the deprecated >> gpiod_toggle_active_low() and acpi_get_and_request_gpiod() functions. >> >> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >> [hdegoede@redhat.com] use the new skl_int3472_fill_gpiod_lookup() helper >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > Something wrong between authorship and committer and SoB chain. > I believe you need to preserve the authorship and add yourself as > Co-developed-by: ? Yes you are correct, I'll prepare a new version of the series with this fixed. Regards, hans
diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c index 351ecf047944..a46c3a206aa3 100644 --- a/drivers/platform/x86/intel/int3472/discrete.c +++ b/drivers/platform/x86/intel/int3472/discrete.c @@ -99,6 +99,32 @@ static int skl_int3472_map_gpio_to_sensor(struct int3472_discrete_device *int347 return 0; } +/* This should *really* only be used when there's no other way... */ +static struct gpio_desc * +skl_int3472_gpiod_get_from_temp_lookup(struct int3472_discrete_device *int3472, + struct acpi_resource_gpio *agpio, + const char *func, u32 polarity) +{ + struct gpio_desc *desc; + int ret; + + struct gpiod_lookup_table *lookup __free(kfree) = + kzalloc(struct_size(lookup, table, 1), GFP_KERNEL); + if (!lookup) + return ERR_PTR(-ENOMEM); + + lookup->dev_id = dev_name(int3472->dev); + ret = skl_int3472_fill_gpiod_lookup(&lookup->table[0], agpio, func, polarity); + if (ret) + return ERR_PTR(ret); + + gpiod_add_lookup_table(lookup); + desc = gpiod_get(int3472->dev, func, GPIOD_OUT_LOW); + gpiod_remove_lookup_table(lookup); + + return desc; +} + static void int3472_get_func_and_polarity(u8 type, const char **func, u32 *polarity) { switch (type) {