| Message ID | 20230930001933.2660-4-salil.mehta@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add architecture agnostic code to support vCPU Hotplug | expand |
On Sat, 30 Sep 2023 01:19:26 +0100 Salil Mehta <salil.mehta@huawei.com> wrote: > ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG > support has been enabled for particular architecture. Add cpu_hotplug_hw_init() > stub to avoid compilation break. > > Signed-off-by: Salil Mehta <salil.mehta@huawei.com> Seems reasonable. For the other similar cases a stub isn't needed because GED is built when CONFIG_ACPI_HW_REDUCED=y and that select ACPI_MEMORY_HOTPLUG and ACPI_NVDIMM You could do the same for the CPU hotplug case and instantiate a potentially useless memory region etc. This seems more sensible to me Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > hw/acpi/acpi-cpu-hotplug-stub.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/hw/acpi/acpi-cpu-hotplug-stub.c b/hw/acpi/acpi-cpu-hotplug-stub.c > index 3fc4b14c26..c6c61bb9cd 100644 > --- a/hw/acpi/acpi-cpu-hotplug-stub.c > +++ b/hw/acpi/acpi-cpu-hotplug-stub.c > @@ -19,6 +19,12 @@ void legacy_acpi_cpu_hotplug_init(MemoryRegion *parent, Object *owner, > return; > } > > +void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner, > + CPUHotplugState *state, hwaddr base_addr) > +{ > + return; > +} > + > void acpi_cpu_ospm_status(CPUHotplugState *cpu_st, ACPIOSTInfoList ***list) > { > return;
On 9/30/23 10:19, Salil Mehta wrote: > ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG > support has been enabled for particular architecture. Add cpu_hotplug_hw_init() > stub to avoid compilation break. > > Signed-off-by: Salil Mehta <salil.mehta@huawei.com> > --- > hw/acpi/acpi-cpu-hotplug-stub.c | 6 ++++++ > 1 file changed, 6 insertions(+) > Reviewed-by: Gavin Shan <gshan@redhat.com> > diff --git a/hw/acpi/acpi-cpu-hotplug-stub.c b/hw/acpi/acpi-cpu-hotplug-stub.c > index 3fc4b14c26..c6c61bb9cd 100644 > --- a/hw/acpi/acpi-cpu-hotplug-stub.c > +++ b/hw/acpi/acpi-cpu-hotplug-stub.c > @@ -19,6 +19,12 @@ void legacy_acpi_cpu_hotplug_init(MemoryRegion *parent, Object *owner, > return; > } > > +void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner, > + CPUHotplugState *state, hwaddr base_addr) > +{ > + return; ^^^^^^ > +} > + I guess the return is the outcome by following the pattern of other functions ;-) > void acpi_cpu_ospm_status(CPUHotplugState *cpu_st, ACPIOSTInfoList ***list) > { > return; Thanks, Gavin
> From: Jonathan Cameron <jonathan.cameron@huawei.com> > Sent: Monday, October 2, 2023 5:01 PM > To: Salil Mehta <salil.mehta@huawei.com> > Cc: qemu-devel@nongnu.org; qemu-arm@nongnu.org; maz@kernel.org; jean- > philippe@linaro.org; lpieralisi@kernel.org; peter.maydell@linaro.org; > richard.henderson@linaro.org; imammedo@redhat.com; andrew.jones@linux.dev; > david@redhat.com; philmd@linaro.org; eric.auger@redhat.com; > oliver.upton@linux.dev; pbonzini@redhat.com; mst@redhat.com; > will@kernel.org; gshan@redhat.com; rafael@kernel.org; > alex.bennee@linaro.org; linux@armlinux.org.uk; > darren@os.amperecomputing.com; ilkka@os.amperecomputing.com; > vishnu@os.amperecomputing.com; karl.heubaum@oracle.com; > miguel.luis@oracle.com; salil.mehta@opnsrc.net; zhukeqian > <zhukeqian1@huawei.com>; wangxiongfeng (C) <wangxiongfeng2@huawei.com>; > wangyanan (Y) <wangyanan55@huawei.com>; jiakernel2@gmail.com; > maobibo@loongson.cn; lixianglai@loongson.cn; Linuxarm <linuxarm@huawei.com> > Subject: Re: [PATCH V2 03/10] hw/acpi: Add ACPI CPU hotplug init stub > > On Sat, 30 Sep 2023 01:19:26 +0100 > Salil Mehta <salil.mehta@huawei.com> wrote: > > > ACPI CPU hotplug related initialization should only happen if > ACPI_CPU_HOTPLUG > > support has been enabled for particular architecture. Add > cpu_hotplug_hw_init() > > stub to avoid compilation break. > > > > Signed-off-by: Salil Mehta <salil.mehta@huawei.com> > Seems reasonable. For the other similar cases a stub isn't needed > because GED is built when CONFIG_ACPI_HW_REDUCED=y and > that select ACPI_MEMORY_HOTPLUG and ACPI_NVDIMM > > You could do the same for the CPU hotplug case and instantiate > a potentially useless memory region etc. This seems more sensible to me > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Thanks Salil. > > hw/acpi/acpi-cpu-hotplug-stub.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/hw/acpi/acpi-cpu-hotplug-stub.c b/hw/acpi/acpi-cpu-hotplug- > stub.c > > index 3fc4b14c26..c6c61bb9cd 100644 > > --- a/hw/acpi/acpi-cpu-hotplug-stub.c > > +++ b/hw/acpi/acpi-cpu-hotplug-stub.c > > @@ -19,6 +19,12 @@ void legacy_acpi_cpu_hotplug_init(MemoryRegion > *parent, Object *owner, > > return; > > } > > > > +void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner, > > + CPUHotplugState *state, hwaddr base_addr) > > +{ > > + return; > > +} > > + > > void acpi_cpu_ospm_status(CPUHotplugState *cpu_st, ACPIOSTInfoList > ***list) > > { > > return;
> From: Gavin Shan <gshan@redhat.com> > Sent: Tuesday, October 3, 2023 12:25 AM > To: Salil Mehta <salil.mehta@huawei.com>; qemu-devel@nongnu.org; qemu- > arm@nongnu.org > Cc: maz@kernel.org; jean-philippe@linaro.org; Jonathan Cameron > <jonathan.cameron@huawei.com>; lpieralisi@kernel.org; > peter.maydell@linaro.org; richard.henderson@linaro.org; > imammedo@redhat.com; andrew.jones@linux.dev; david@redhat.com; > philmd@linaro.org; eric.auger@redhat.com; oliver.upton@linux.dev; > pbonzini@redhat.com; mst@redhat.com; will@kernel.org; rafael@kernel.org; > alex.bennee@linaro.org; linux@armlinux.org.uk; > darren@os.amperecomputing.com; ilkka@os.amperecomputing.com; > vishnu@os.amperecomputing.com; karl.heubaum@oracle.com; > miguel.luis@oracle.com; salil.mehta@opnsrc.net; zhukeqian > <zhukeqian1@huawei.com>; wangxiongfeng (C) <wangxiongfeng2@huawei.com>; > wangyanan (Y) <wangyanan55@huawei.com>; jiakernel2@gmail.com; > maobibo@loongson.cn; lixianglai@loongson.cn; Linuxarm <linuxarm@huawei.com> > Subject: Re: [PATCH V2 03/10] hw/acpi: Add ACPI CPU hotplug init stub > > > On 9/30/23 10:19, Salil Mehta wrote: > > ACPI CPU hotplug related initialization should only happen if > ACPI_CPU_HOTPLUG > > support has been enabled for particular architecture. Add > cpu_hotplug_hw_init() > > stub to avoid compilation break. > > > > Signed-off-by: Salil Mehta <salil.mehta@huawei.com> > > --- > > hw/acpi/acpi-cpu-hotplug-stub.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > Reviewed-by: Gavin Shan <gshan@redhat.com> Thanks Salil. > > > diff --git a/hw/acpi/acpi-cpu-hotplug-stub.c b/hw/acpi/acpi-cpu-hotplug- > stub.c > > index 3fc4b14c26..c6c61bb9cd 100644 > > --- a/hw/acpi/acpi-cpu-hotplug-stub.c > > +++ b/hw/acpi/acpi-cpu-hotplug-stub.c > > @@ -19,6 +19,12 @@ void legacy_acpi_cpu_hotplug_init(MemoryRegion > *parent, Object *owner, > > return; > > } > > > > +void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner, > > + CPUHotplugState *state, hwaddr base_addr) > > +{ > > + return; > ^^^^^^ > > +} > > + > > I guess the return is the outcome by following the pattern of other > functions ;-) I can remove it. :)
diff --git a/hw/acpi/acpi-cpu-hotplug-stub.c b/hw/acpi/acpi-cpu-hotplug-stub.c index 3fc4b14c26..c6c61bb9cd 100644 --- a/hw/acpi/acpi-cpu-hotplug-stub.c +++ b/hw/acpi/acpi-cpu-hotplug-stub.c @@ -19,6 +19,12 @@ void legacy_acpi_cpu_hotplug_init(MemoryRegion *parent, Object *owner, return; } +void cpu_hotplug_hw_init(MemoryRegion *as, Object *owner, + CPUHotplugState *state, hwaddr base_addr) +{ + return; +} + void acpi_cpu_ospm_status(CPUHotplugState *cpu_st, ACPIOSTInfoList ***list) { return;
ACPI CPU hotplug related initialization should only happen if ACPI_CPU_HOTPLUG support has been enabled for particular architecture. Add cpu_hotplug_hw_init() stub to avoid compilation break. Signed-off-by: Salil Mehta <salil.mehta@huawei.com> --- hw/acpi/acpi-cpu-hotplug-stub.c | 6 ++++++ 1 file changed, 6 insertions(+)