| Message ID | 20231002193544.14529-1-rdunlap@infradead.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 566aeed6871ac2189b5bfe03e1a5b3b7be5eca38 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: lan743x: also select PHYLIB | expand |
On Mon, Oct 02, 2023 at 12:35:44PM -0700, Randy Dunlap wrote: > Since FIXED_PHY depends on PHYLIB, PHYLIB needs to be set to avoid > a kconfig warning: > > WARNING: unmet direct dependencies detected for FIXED_PHY > Depends on [n]: NETDEVICES [=y] && PHYLIB [=n] > Selected by [y]: > - LAN743X [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROCHIP [=y] && PCI [=y] && PTP_1588_CLOCK_OPTIONAL [=y] > > Fixes: 73c4d1b307ae ("net: lan743x: select FIXED_PHY") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Closes: lore.kernel.org/r/202309261802.JPbRHwti-lkp@intel.com Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Simon Horman <horms@kernel.org> # build-tested
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 2 Oct 2023 12:35:44 -0700 you wrote: > Since FIXED_PHY depends on PHYLIB, PHYLIB needs to be set to avoid > a kconfig warning: > > WARNING: unmet direct dependencies detected for FIXED_PHY > Depends on [n]: NETDEVICES [=y] && PHYLIB [=n] > Selected by [y]: > - LAN743X [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROCHIP [=y] && PCI [=y] && PTP_1588_CLOCK_OPTIONAL [=y] > > [...] Here is the summary with links: - [v2] net: lan743x: also select PHYLIB https://git.kernel.org/netdev/net/c/566aeed6871a You are awesome, thank you!
diff -- a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig --- a/drivers/net/ethernet/microchip/Kconfig +++ b/drivers/net/ethernet/microchip/Kconfig @@ -46,6 +46,7 @@ config LAN743X tristate "LAN743x support" depends on PCI depends on PTP_1588_CLOCK_OPTIONAL + select PHYLIB select FIXED_PHY select CRC16 select CRC32
Since FIXED_PHY depends on PHYLIB, PHYLIB needs to be set to avoid a kconfig warning: WARNING: unmet direct dependencies detected for FIXED_PHY Depends on [n]: NETDEVICES [=y] && PHYLIB [=n] Selected by [y]: - LAN743X [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROCHIP [=y] && PCI [=y] && PTP_1588_CLOCK_OPTIONAL [=y] Fixes: 73c4d1b307ae ("net: lan743x: select FIXED_PHY") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Reported-by: kernel test robot <lkp@intel.com> Closes: lore.kernel.org/r/202309261802.JPbRHwti-lkp@intel.com Cc: Bryan Whitehead <bryan.whitehead@microchip.com> Cc: UNGLinuxDriver@microchip.com Cc: Simon Horman <horms@kernel.org> Cc: netdev@vger.kernel.org Cc: "David S. Miller" <davem@davemloft.net> Cc: Eric Dumazet <edumazet@google.com> Cc: Jakub Kicinski <kuba@kernel.org> Cc: Paolo Abeni <pabeni@redhat.com> --- v2: Also Cc: netdev and Microchip people; drivers/net/ethernet/microchip/Kconfig | 1 + 1 file changed, 1 insertion(+)