diff mbox series

[v2] ufs: core: correct clear tm error log

Message ID 20231003022002.25578-1-peter.wang@mediatek.com (mailing list archive)
State Accepted
Headers show
Series [v2] ufs: core: correct clear tm error log | expand

Commit Message

Peter Wang (王信友) Oct. 3, 2023, 2:20 a.m. UTC 
From: Peter Wang <peter.wang@mediatek.com>

The clear tm function error log is inverted.

Fixes: 4693fad7d6d4 ("scsi: ufs: core: Log error handler activity")
Signed-off-by: Peter Wang <peter.wang@mediatek.com>
---
 drivers/ufs/core/ufshcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bart Van Assche Oct. 3, 2023, 5:28 p.m. UTC | #1 
On 10/2/23 19:20, peter.wang@mediatek.com wrote:
> The clear tm function error log is inverted.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Stanley Jhu Oct. 4, 2023, 1:31 a.m. UTC | #2 
On Tue, Oct 3, 2023 at 10:20 AM <peter.wang@mediatek.com> wrote:
>
> From: Peter Wang <peter.wang@mediatek.com>
>
> The clear tm function error log is inverted.
>
> Fixes: 4693fad7d6d4 ("scsi: ufs: core: Log error handler activity")
> Signed-off-by: Peter Wang <peter.wang@mediatek.com>

Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Martin K. Petersen Oct. 10, 2023, 2:09 a.m. UTC | #3 
On Tue, 03 Oct 2023 10:20:02 +0800, peter.wang@mediatek.com wrote:

> The clear tm function error log is inverted.
> 
> 

Applied to 6.6/scsi-fixes, thanks!

[1/1] ufs: core: correct clear tm error log
      https://git.kernel.org/mkp/scsi/c/a20c4350c6a1
diff mbox series

Patch

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index c2df07545f96..8382e8cfa414 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -6895,7 +6895,7 @@  static int ufshcd_clear_tm_cmd(struct ufs_hba *hba, int tag)
 			mask, 0, 1000, 1000);
 
 	dev_err(hba->dev, "Clearing task management function with tag %d %s\n",
-		tag, err ? "succeeded" : "failed");
+		tag, err < 0 ? "failed" : "succeeded");
 
 out:
 	return err;