mbox series

[0/2] Fix usage of GETPC(), variable shadowing

Message ID 20231004123957.1732915-1-bcain@quicinc.com (mailing list archive)
Headers show
Series Fix usage of GETPC(), variable shadowing | expand

Message

Brian Cain Oct. 4, 2023, 12:39 p.m. UTC 
Matheus' patch has previously been reviewed, but I based my -Wshadow
patch on his.  So I'm submitting the series for review.

Brian Cain (1):
  target/hexagon: fix some occurrences of -Wshadow=local

Matheus Tavares Bernardino (1):
  target/hexagon: move GETPC() calls to top level helpers

 target/hexagon/imported/alu.idef |  6 +--
 target/hexagon/macros.h          | 19 ++++----
 target/hexagon/mmvec/macros.h    |  2 +-
 target/hexagon/op_helper.c       | 84 ++++++++++++--------------------
 target/hexagon/op_helper.h       |  9 ----
 target/hexagon/translate.c       | 10 ++--
 6 files changed, 50 insertions(+), 80 deletions(-)

Comments

Anton Johansson Oct. 4, 2023, 3:11 p.m. UTC | #1 
On 04/10/23, Brian Cain wrote:
> Matheus' patch has previously been reviewed, but I based my -Wshadow
> patch on his.  So I'm submitting the series for review.
> 
> Brian Cain (1):
>   target/hexagon: fix some occurrences of -Wshadow=local
> 
> Matheus Tavares Bernardino (1):
>   target/hexagon: move GETPC() calls to top level helpers
> 
>  target/hexagon/imported/alu.idef |  6 +--
>  target/hexagon/macros.h          | 19 ++++----
>  target/hexagon/mmvec/macros.h    |  2 +-
>  target/hexagon/op_helper.c       | 84 ++++++++++++--------------------
>  target/hexagon/op_helper.h       |  9 ----
>  target/hexagon/translate.c       | 10 ++--
>  6 files changed, 50 insertions(+), 80 deletions(-)
> 
> -- 
> 2.25.1
> 

Both patches:
Reviewed-by: Anton Johansson <anjo@rev.ng>
Tested-by: Anton Johansson <anjo@rev.ng>
Markus Armbruster Oct. 5, 2023, 6:05 a.m. UTC | #2 
Brian Cain <bcain@quicinc.com> writes:

> Matheus' patch has previously been reviewed, but I based my -Wshadow
> patch on his.  So I'm submitting the series for review.

I'm not queueing these, because it's more than just shadowing.  I trust
your PR will arrive in due time :)

Thanks!