| Message ID | 20230927023357.9883-2-j-keerthy@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: ti: k3-j7: Add the ESM & main domain watchdog nodes | expand |
On 27/09/23 08:03, Keerthy wrote: > Patch adds the ESM instances for j721s2. It has 3 instances. > One in the main domain and two in the mcu-wakeup domian. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 7 +++++++ > arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 14 ++++++++++++++ > 2 files changed, 21 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi > index 084f8f5b6699..8a717b592238 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi > @@ -1695,4 +1695,11 @@ > dss_ports: ports { > }; > }; > + > + main_esm: esm@700000 { > + compatible = "ti,j721e-esm"; > + reg = <0x00 0x700000 0x00 0x1000>; > + ti,esm-pins = <688>, <689>; > + bootph-pre-ram; Similar to other k3-*.dts here and elsewhere bootph-all Better drop them altogether, and lets have a single patch for the j721s2 platform to add bootph* flags as necessary. > + }; > }; > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > index 2ddad9318554..4b29418a6076 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > @@ -655,4 +655,18 @@ > power-domains = <&k3_pds 154 TI_SCI_PD_SHARED>; > #thermal-sensor-cells = <1>; > }; > + > + mcu_esm: esm@40800000 { > + compatible = "ti,j721e-esm"; > + reg = <0x00 0x40800000 0x00 0x1000>; > + ti,esm-pins = <95>; > + bootph-pre-ram; > + }; > + > + wkup_esm: esm@42080000 { > + compatible = "ti,j721e-esm"; > + reg = <0x00 0x42080000 0x00 0x1000>; > + ti,esm-pins = <63>; > + bootph-pre-ram; > + }; > };
On 10/3/2023 12:20 PM, Vignesh Raghavendra wrote: > > > On 27/09/23 08:03, Keerthy wrote: >> Patch adds the ESM instances for j721s2. It has 3 instances. >> One in the main domain and two in the mcu-wakeup domian. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 7 +++++++ >> arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 14 ++++++++++++++ >> 2 files changed, 21 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi >> index 084f8f5b6699..8a717b592238 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi >> @@ -1695,4 +1695,11 @@ >> dss_ports: ports { >> }; >> }; >> + >> + main_esm: esm@700000 { >> + compatible = "ti,j721e-esm"; >> + reg = <0x00 0x700000 0x00 0x1000>; >> + ti,esm-pins = <688>, <689>; >> + bootph-pre-ram; > > > Similar to other k3-*.dts here and elsewhere > bootph-all > > > Better drop them altogether, and lets have a single patch for the j721s2 > platform to add bootph* flags as necessary. Okay. > > >> + }; >> }; >> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi >> index 2ddad9318554..4b29418a6076 100644 >> --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi >> @@ -655,4 +655,18 @@ >> power-domains = <&k3_pds 154 TI_SCI_PD_SHARED>; >> #thermal-sensor-cells = <1>; >> }; >> + >> + mcu_esm: esm@40800000 { >> + compatible = "ti,j721e-esm"; >> + reg = <0x00 0x40800000 0x00 0x1000>; >> + ti,esm-pins = <95>; >> + bootph-pre-ram; >> + }; >> + >> + wkup_esm: esm@42080000 { >> + compatible = "ti,j721e-esm"; >> + reg = <0x00 0x42080000 0x00 0x1000>; >> + ti,esm-pins = <63>; >> + bootph-pre-ram; >> + }; >> }; >
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi index 084f8f5b6699..8a717b592238 100644 --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi @@ -1695,4 +1695,11 @@ dss_ports: ports { }; }; + + main_esm: esm@700000 { + compatible = "ti,j721e-esm"; + reg = <0x00 0x700000 0x00 0x1000>; + ti,esm-pins = <688>, <689>; + bootph-pre-ram; + }; }; diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi index 2ddad9318554..4b29418a6076 100644 --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi @@ -655,4 +655,18 @@ power-domains = <&k3_pds 154 TI_SCI_PD_SHARED>; #thermal-sensor-cells = <1>; }; + + mcu_esm: esm@40800000 { + compatible = "ti,j721e-esm"; + reg = <0x00 0x40800000 0x00 0x1000>; + ti,esm-pins = <95>; + bootph-pre-ram; + }; + + wkup_esm: esm@42080000 { + compatible = "ti,j721e-esm"; + reg = <0x00 0x42080000 0x00 0x1000>; + ti,esm-pins = <63>; + bootph-pre-ram; + }; };
Patch adds the ESM instances for j721s2. It has 3 instances. One in the main domain and two in the mcu-wakeup domian. Signed-off-by: Keerthy <j-keerthy@ti.com> --- arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 7 +++++++ arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 14 ++++++++++++++ 2 files changed, 21 insertions(+)