| Message ID | 20231003183603.3887546-1-jesse.brandeburg@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | intel: format specifier cleanups | expand |
On Tue, Oct 03, 2023 at 11:36:01AM -0700, Jesse Brandeburg wrote: > Clean up some warnings from the W=1 build which moves the intel > directory back to "clean" state. This mostly involved converting to > using ethtool_sprintf where appropriate and kasprintf in other places. > > The second patch goes the extra mile and cleans up -Wformat=2 warnings > as suggested by Alex Lobakin, since those flags will likely be turned on > as well. > > gcc-12 runs clean after these changes, and clang-15 still has some minor > complaints as mentioned in patch-2. > > Jesse Brandeburg (2): > intel: fix string truncation warnings > intel: fix format warnings > > .../net/ethernet/intel/i40e/i40e_ethtool.c | 6 ++- > .../net/ethernet/intel/iavf/iavf_ethtool.c | 8 ++-- > .../net/ethernet/intel/iavf/iavf_virtchnl.c | 22 ++++------- > drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 ++-- > drivers/net/ethernet/intel/ice/ice_ptp.c | 4 +- > drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 +- > drivers/net/ethernet/intel/igb/igb_main.c | 37 +++++++++---------- > drivers/net/ethernet/intel/igc/igc_ethtool.c | 5 ++- > .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 +- > 9 files changed, 46 insertions(+), 51 deletions(-) For series, Reviewed-by: Simon Horman <horms@kernel.org> Tested-by: Simon Horman <horms@kernel.org> # build-tested
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Simon Horman > Sent: Wednesday, October 4, 2023 3:46 PM > To: Brandeburg, Jesse <jesse.brandeburg@intel.com> > Cc: netdev@vger.kernel.org; Christophe JAILLET > <christophe.jaillet@wanadoo.fr>; intel-wired-lan@lists.osuosl.org; Kitszel, > Przemyslaw <przemyslaw.kitszel@intel.com> > Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 0/2] intel: format specifier > cleanups > > On Tue, Oct 03, 2023 at 11:36:01AM -0700, Jesse Brandeburg wrote: > > Clean up some warnings from the W=1 build which moves the intel > > directory back to "clean" state. This mostly involved converting to > > using ethtool_sprintf where appropriate and kasprintf in other places. > > > > The second patch goes the extra mile and cleans up -Wformat=2 warnings > > as suggested by Alex Lobakin, since those flags will likely be turned > > on as well. > > > > gcc-12 runs clean after these changes, and clang-15 still has some > > minor complaints as mentioned in patch-2. > > > > Jesse Brandeburg (2): > > intel: fix string truncation warnings > > intel: fix format warnings > > > > .../net/ethernet/intel/i40e/i40e_ethtool.c | 6 ++- > > .../net/ethernet/intel/iavf/iavf_ethtool.c | 8 ++-- > > .../net/ethernet/intel/iavf/iavf_virtchnl.c | 22 ++++------- > > drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 ++-- > > drivers/net/ethernet/intel/ice/ice_ptp.c | 4 +- > > drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 +- > > drivers/net/ethernet/intel/igb/igb_main.c | 37 +++++++++---------- > > drivers/net/ethernet/intel/igc/igc_ethtool.c | 5 ++- > > .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 +- > > 9 files changed, 46 insertions(+), 51 deletions(-) > > For series, > > > Reviewed-by: Simon Horman <horms@kernel.org> > Tested-by: Simon Horman <horms@kernel.org> # build-tested > > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Romanowski, Rafal > Sent: Friday, October 6, 2023 5:16 PM > To: Simon Horman <horms@kernel.org>; Brandeburg, Jesse > <jesse.brandeburg@intel.com> > Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; Christophe > JAILLET <christophe.jaillet@wanadoo.fr>; Kitszel, Przemyslaw > <przemyslaw.kitszel@intel.com> > Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 0/2] intel: format specifier > cleanups > > > -----Original Message----- > > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf > > Of Simon Horman > > Sent: Wednesday, October 4, 2023 3:46 PM > > To: Brandeburg, Jesse <jesse.brandeburg@intel.com> > > Cc: netdev@vger.kernel.org; Christophe JAILLET > > <christophe.jaillet@wanadoo.fr>; intel-wired-lan@lists.osuosl.org; > > Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com> > > Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 0/2] intel: format > > specifier cleanups > > > > On Tue, Oct 03, 2023 at 11:36:01AM -0700, Jesse Brandeburg wrote: > > > Clean up some warnings from the W=1 build which moves the intel > > > directory back to "clean" state. This mostly involved converting to > > > using ethtool_sprintf where appropriate and kasprintf in other places. > > > > > > The second patch goes the extra mile and cleans up -Wformat=2 > > > warnings as suggested by Alex Lobakin, since those flags will likely > > > be turned on as well. > > > > > > gcc-12 runs clean after these changes, and clang-15 still has some > > > minor complaints as mentioned in patch-2. > > > > > > Jesse Brandeburg (2): > > > intel: fix string truncation warnings > > > intel: fix format warnings > > > > > > .../net/ethernet/intel/i40e/i40e_ethtool.c | 6 ++- > > > .../net/ethernet/intel/iavf/iavf_ethtool.c | 8 ++-- > > > .../net/ethernet/intel/iavf/iavf_virtchnl.c | 22 ++++------- > > > drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 ++-- > > > drivers/net/ethernet/intel/ice/ice_ptp.c | 4 +- > > > drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 +- > > > drivers/net/ethernet/intel/igb/igb_main.c | 37 +++++++++---------- > > > drivers/net/ethernet/intel/igc/igc_ethtool.c | 5 ++- > > > .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 +- > > > 9 files changed, 46 insertions(+), 51 deletions(-) > > > > For series, > > > > > > Reviewed-by: Simon Horman <horms@kernel.org> > > Tested-by: Simon Horman <horms@kernel.org> # build-tested > > > > _______________________________________________ > > Intel-wired-lan mailing list > > Intel-wired-lan@osuosl.org > > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan > > > Tested-by: Rafal Romanowski <rafal.romanowski@intel.com> > > > > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>