diff mbox series

[v4,1/1] platform/x86: asus-wireless: Replace open coded acpi_match_device()

Message ID 20231007081230.3555681-1-andriy.shevchenko@linux.intel.com (mailing list archive)
State Changes Requested, archived
Headers show
Series [v4,1/1] platform/x86: asus-wireless: Replace open coded acpi_match_device() | expand

Commit Message

Andy Shevchenko Oct. 7, 2023, 8:12 a.m. UTC 
Replace open coded acpi_match_device() in asus_wireless_add().

Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

v4: used proper API, added tag (Hans)
v3: rewrote error path logic (Hans)
v2: fixed compilation error

 drivers/platform/x86/asus-wireless.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

Comments

Ilpo Järvinen Oct. 9, 2023, 11:33 a.m. UTC | #1 
On Sat, 7 Oct 2023, Andy Shevchenko wrote:

> Replace open coded acpi_match_device() in asus_wireless_add().

Could you update this and shortlog too to match the patch (the same 
applies also to the other similar patch you've inflight).
diff mbox series

Patch

diff --git a/drivers/platform/x86/asus-wireless.c b/drivers/platform/x86/asus-wireless.c
index abf01e00b799..41227bf95878 100644
--- a/drivers/platform/x86/asus-wireless.c
+++ b/drivers/platform/x86/asus-wireless.c
@@ -148,16 +148,12 @@  static int asus_wireless_add(struct acpi_device *adev)
 	if (err)
 		return err;
 
-	for (id = device_ids; id->id[0]; id++) {
-		if (!strcmp((char *) id->id, acpi_device_hid(adev))) {
-			data->hswc_params =
-				(const struct hswc_params *)id->driver_data;
-			break;
-		}
-	}
-	if (!data->hswc_params)
+	id = acpi_match_acpi_device(device_ids, adev);
+	if (!id)
 		return 0;
 
+	data->hswc_params = (const struct hswc_params *)id->driver_data;
+
 	data->wq = create_singlethread_workqueue("asus_wireless_workqueue");
 	if (!data->wq)
 		return -ENOMEM;