| Message ID | 20231009124210.1064021-2-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/5] csky: remove unused cmd_vdso_install | expand |
----- Ursprüngliche Mail ----- > Von: "masahiroy" <masahiroy@kernel.org> > An: "linux-kbuild" <linux-kbuild@vger.kernel.org> > CC: "linux-kernel" <linux-kernel@vger.kernel.org>, "linux-arm-kernel" <linux-arm-kernel@lists.infradead.org>, > linux-csky@vger.kernel.org, "linux-parisc" <linux-parisc@vger.kernel.org>, linux-riscv@lists.infradead.org, > linux-s390@vger.kernel.org, "linux-um" <linux-um@lists.infradead.org>, "loongarch" <loongarch@lists.linux.dev>, > "sparclinux" <sparclinux@vger.kernel.org>, "x86" <x86@kernel.org>, "masahiroy" <masahiroy@kernel.org>, "anton ivanov" > <anton.ivanov@cambridgegreys.com>, "bp" <bp@alien8.de>, "dave hansen" <dave.hansen@linux.intel.com>, "hpa" > <hpa@zytor.com>, "mingo" <mingo@redhat.com>, "Johannes Berg" <johannes@sipsolutions.net>, "richard" <richard@nod.at>, > "tglx" <tglx@linutronix.de> > Gesendet: Montag, 9. Oktober 2023 14:42:07 > Betreff: [PATCH 2/5] UML: remove unused cmd_vdso_install > You cannot run this code because arch/um/Makefile does not define the > vdso_install target. > > It appears that this code was blindly copied from another architecture. > > Remove the dead code. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Acked-by: Richard Weinberger <richard@nod.at> Thanks, //richard
diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile index 6825e146a62f..b86d634730b2 100644 --- a/arch/x86/um/vdso/Makefile +++ b/arch/x86/um/vdso/Makefile @@ -67,15 +67,3 @@ quiet_cmd_vdso = VDSO $@ VDSO_LDFLAGS = -fPIC -shared -Wl,--hash-style=sysv -z noexecstack GCOV_PROFILE := n - -# -# Install the unstripped copy of vdso*.so listed in $(vdso-install-y). -# -quiet_cmd_vdso_install = INSTALL $@ - cmd_vdso_install = cp $(obj)/$@.dbg $(MODLIB)/vdso/$@ -$(vdso-install-y): %.so: $(obj)/%.so.dbg FORCE - @mkdir -p $(MODLIB)/vdso - $(call cmd,vdso_install) - -PHONY += vdso_install $(vdso-install-y) -vdso_install: $(vdso-install-y)
You cannot run this code because arch/um/Makefile does not define the vdso_install target. It appears that this code was blindly copied from another architecture. Remove the dead code. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- arch/x86/um/vdso/Makefile | 12 ------------ 1 file changed, 12 deletions(-)