| Message ID | 20231009135833.17880-4-pbrobinson@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Cleanup some BRCMSTB Kconfig options | expand |
On Mon, Oct 9, 2023, at 15:58, Peter Robinson wrote: > Depend on the explicit SoC defines rather than generic > architectures like most of the rest of the HW drivers do. > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > --- > drivers/bus/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > index c98dd6ca2629..e6742998f372 100644 > --- a/drivers/bus/Kconfig > +++ b/drivers/bus/Kconfig > @@ -31,7 +31,7 @@ config ARM_INTEGRATOR_LM > > config BRCMSTB_GISB_ARB > tristate "Broadcom STB GISB bus arbiter" > - depends on ARM || ARM64 || MIPS > + depends on ARCH_BRCMSTB || BMIPS_GENERIC If there are no compile time dependencies, it might be good to also add "|| COMPILE_TEST" to the dependency and have the drivers built in an x86_64 allmodconfig. Arnd
From: Florian Fainelli <f.fainelli@gmail.com> On Mon, 9 Oct 2023 14:58:19 +0100, Peter Robinson <pbrobinson@gmail.com> wrote: > Depend on the explicit SoC defines rather than generic > architectures like most of the rest of the HW drivers do. > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > --- Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks! -- Florian
On 10/9/23 07:25, Arnd Bergmann wrote: > On Mon, Oct 9, 2023, at 15:58, Peter Robinson wrote: >> Depend on the explicit SoC defines rather than generic >> architectures like most of the rest of the HW drivers do. >> >> Signed-off-by: Peter Robinson <pbrobinson@gmail.com> >> --- >> drivers/bus/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig >> index c98dd6ca2629..e6742998f372 100644 >> --- a/drivers/bus/Kconfig >> +++ b/drivers/bus/Kconfig >> @@ -31,7 +31,7 @@ config ARM_INTEGRATOR_LM >> >> config BRCMSTB_GISB_ARB >> tristate "Broadcom STB GISB bus arbiter" >> - depends on ARM || ARM64 || MIPS >> + depends on ARCH_BRCMSTB || BMIPS_GENERIC > > If there are no compile time dependencies, it might be good > to also add "|| COMPILE_TEST" to the dependency > and have the drivers built in an x86_64 allmodconfig. Agreed, I did apply Peter's patch because I think this can be a separate patch. Thanks!
diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig index c98dd6ca2629..e6742998f372 100644 --- a/drivers/bus/Kconfig +++ b/drivers/bus/Kconfig @@ -31,7 +31,7 @@ config ARM_INTEGRATOR_LM config BRCMSTB_GISB_ARB tristate "Broadcom STB GISB bus arbiter" - depends on ARM || ARM64 || MIPS + depends on ARCH_BRCMSTB || BMIPS_GENERIC default ARCH_BRCMSTB || BMIPS_GENERIC help Driver for the Broadcom Set Top Box System-on-a-chip internal bus
Depend on the explicit SoC defines rather than generic architectures like most of the rest of the HW drivers do. Signed-off-by: Peter Robinson <pbrobinson@gmail.com> --- drivers/bus/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)