| Message ID | 20231009022048.35475-3-zhenzhong.duan@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vfio: memory leak fix and code cleanup | expand |
On 9/10/23 04:20, Zhenzhong Duan wrote: > No need to double-cast, call VFIO_AP_DEVICE() on DeviceState. > > No functional changes. > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com> > --- > hw/vfio/ap.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com> On 10/8/23 22:20, Zhenzhong Duan wrote: > No need to double-cast, call VFIO_AP_DEVICE() on DeviceState. > > No functional changes. > > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com> > --- > hw/vfio/ap.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c > index 22e564f4f7..e083a19eac 100644 > --- a/hw/vfio/ap.c > +++ b/hw/vfio/ap.c > @@ -156,8 +156,7 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp) > { > int ret; > Error *err = NULL; > - APDevice *apdev = AP_DEVICE(dev); > - VFIOAPDevice *vapdev = VFIO_AP_DEVICE(apdev); > + VFIOAPDevice *vapdev = VFIO_AP_DEVICE(dev); > VFIODevice *vbasedev = &vapdev->vdev; > > vbasedev->name = g_path_get_basename(vbasedev->sysfsdev); > @@ -195,8 +194,7 @@ error: > > static void vfio_ap_unrealize(DeviceState *dev) > { > - APDevice *apdev = AP_DEVICE(dev); > - VFIOAPDevice *vapdev = VFIO_AP_DEVICE(apdev); > + VFIOAPDevice *vapdev = VFIO_AP_DEVICE(dev); > > vfio_ap_unregister_irq_notifier(vapdev, VFIO_AP_REQ_IRQ_INDEX); > vfio_detach_device(&vapdev->vdev); > @@ -211,8 +209,7 @@ static Property vfio_ap_properties[] = { > static void vfio_ap_reset(DeviceState *dev) > { > int ret; > - APDevice *apdev = AP_DEVICE(dev); > - VFIOAPDevice *vapdev = VFIO_AP_DEVICE(apdev); > + VFIOAPDevice *vapdev = VFIO_AP_DEVICE(dev); > > ret = ioctl(vapdev->vdev.fd, VFIO_DEVICE_RESET); > if (ret) {
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index 22e564f4f7..e083a19eac 100644 --- a/hw/vfio/ap.c +++ b/hw/vfio/ap.c @@ -156,8 +156,7 @@ static void vfio_ap_realize(DeviceState *dev, Error **errp) { int ret; Error *err = NULL; - APDevice *apdev = AP_DEVICE(dev); - VFIOAPDevice *vapdev = VFIO_AP_DEVICE(apdev); + VFIOAPDevice *vapdev = VFIO_AP_DEVICE(dev); VFIODevice *vbasedev = &vapdev->vdev; vbasedev->name = g_path_get_basename(vbasedev->sysfsdev); @@ -195,8 +194,7 @@ error: static void vfio_ap_unrealize(DeviceState *dev) { - APDevice *apdev = AP_DEVICE(dev); - VFIOAPDevice *vapdev = VFIO_AP_DEVICE(apdev); + VFIOAPDevice *vapdev = VFIO_AP_DEVICE(dev); vfio_ap_unregister_irq_notifier(vapdev, VFIO_AP_REQ_IRQ_INDEX); vfio_detach_device(&vapdev->vdev); @@ -211,8 +209,7 @@ static Property vfio_ap_properties[] = { static void vfio_ap_reset(DeviceState *dev) { int ret; - APDevice *apdev = AP_DEVICE(dev); - VFIOAPDevice *vapdev = VFIO_AP_DEVICE(apdev); + VFIOAPDevice *vapdev = VFIO_AP_DEVICE(dev); ret = ioctl(vapdev->vdev.fd, VFIO_DEVICE_RESET); if (ret) {
No need to double-cast, call VFIO_AP_DEVICE() on DeviceState. No functional changes. Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com> --- hw/vfio/ap.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)