| Message ID | 20230922100747.17045-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mm/list_lru: Remove unused function | expand |
On (23/09/22 18:07), Jiapeng Chong wrote: > The function are defined in the list_lru.c file, but not called > elsewhere, so delete the unused function. > > mm/list_lru.c:64:1: warning: unused function 'list_lru_from_kmem'. It seems that this breaks linux-next bisectability: --- mm/list_lru.c:98:7: error: implicit declaration of function 'list_lru_from_kmem' is invalid in C99 [-Werror,-Wimplicit-function-declaration] l = list_lru_from_kmem(lru, nid, item, &memcg); ^ mm/list_lru.c:98:5: warning: incompatible integer to pointer conversion assigning to 'struct list_lru_one *' from 'int' [-Wint-conversion] l = list_lru_from_kmem(lru, nid, item, &memcg); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mm/list_lru.c:121:7: error: implicit declaration of function 'list_lru_from_kmem' is invalid in C99 [-Werror,-Wimplicit-function-declaration] l = list_lru_from_kmem(lru, nid, item, NULL); ^ mm/list_lru.c:121:5: warning: incompatible integer to pointer conversion assigning to 'struct list_lru_one *' from 'int' [-Wint-conversion] l = list_lru_from_kmem(lru, nid, item, NULL); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings and 2 errors generated.
diff --git a/mm/list_lru.c b/mm/list_lru.c index 37c5c2ef6c0e..800f171d2c23 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -60,27 +60,6 @@ list_lru_from_memcg_idx(struct list_lru *lru, int nid, int idx) return &lru->node[nid].lru; } -static inline struct list_lru_one * -list_lru_from_kmem(struct list_lru *lru, int nid, void *ptr, - struct mem_cgroup **memcg_ptr) -{ - struct list_lru_node *nlru = &lru->node[nid]; - struct list_lru_one *l = &nlru->lru; - struct mem_cgroup *memcg = NULL; - - if (!list_lru_memcg_aware(lru)) - goto out; - - memcg = mem_cgroup_from_slab_obj(ptr); - if (!memcg) - goto out; - - l = list_lru_from_memcg_idx(lru, nid, memcg_kmem_id(memcg)); -out: - if (memcg_ptr) - *memcg_ptr = memcg; - return l; -} #else static void list_lru_register(struct list_lru *lru) { @@ -105,15 +84,6 @@ list_lru_from_memcg_idx(struct list_lru *lru, int nid, int idx) { return &lru->node[nid].lru; } - -static inline struct list_lru_one * -list_lru_from_kmem(struct list_lru *lru, int nid, void *ptr, - struct mem_cgroup **memcg_ptr) -{ - if (memcg_ptr) - *memcg_ptr = NULL; - return &lru->node[nid].lru; -} #endif /* CONFIG_MEMCG_KMEM */ bool list_lru_add(struct list_lru *lru, struct list_head *item)
The function are defined in the list_lru.c file, but not called elsewhere, so delete the unused function. mm/list_lru.c:64:1: warning: unused function 'list_lru_from_kmem'. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6677 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- mm/list_lru.c | 30 ------------------------------ 1 file changed, 30 deletions(-)