| Message ID | 20231012061127.95637-1-abel.vesa@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset | expand |
On 10/11/2023 11:11 PM, Abel Vesa wrote: > According to documentation, it has increments of 4, not 8. > > Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support") > Reported-by: Umnathi Chalicheemala <quic_uchalich@quicinc.com> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> Thanks Abel. Reviewed-by: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com> > --- > drivers/soc/qcom/llcc-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c > index 674abd0d6700..fb4085b7cb19 100644 > --- a/drivers/soc/qcom/llcc-qcom.c > +++ b/drivers/soc/qcom/llcc-qcom.c > @@ -47,7 +47,7 @@ > #define LLCC_TRP_STATUSn(n) (4 + n * SZ_4K) > #define LLCC_TRP_ATTR0_CFGn(n) (0x21000 + SZ_8 * n) > #define LLCC_TRP_ATTR1_CFGn(n) (0x21004 + SZ_8 * n) > -#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_8 * n) > +#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_4 * n) > > #define LLCC_TRP_SCID_DIS_CAP_ALLOC 0x21f00 > #define LLCC_TRP_PCB_ACT 0x21f04
On 10/12/23 08:11, Abel Vesa wrote: > According to documentation, it has increments of 4, not 8. > > Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support") > Reported-by: Umnathi Chalicheemala <quic_uchalich@quicinc.com> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c index 674abd0d6700..fb4085b7cb19 100644 --- a/drivers/soc/qcom/llcc-qcom.c +++ b/drivers/soc/qcom/llcc-qcom.c @@ -47,7 +47,7 @@ #define LLCC_TRP_STATUSn(n) (4 + n * SZ_4K) #define LLCC_TRP_ATTR0_CFGn(n) (0x21000 + SZ_8 * n) #define LLCC_TRP_ATTR1_CFGn(n) (0x21004 + SZ_8 * n) -#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_8 * n) +#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_4 * n) #define LLCC_TRP_SCID_DIS_CAP_ALLOC 0x21f00 #define LLCC_TRP_PCB_ACT 0x21f04
According to documentation, it has increments of 4, not 8. Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support") Reported-by: Umnathi Chalicheemala <quic_uchalich@quicinc.com> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- drivers/soc/qcom/llcc-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)