| Message ID | 20231009124210.1064021-3-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/5] csky: remove unused cmd_vdso_install | expand |
Hi Masahiro, On 10/9/23 14:42, Masahiro Yamada wrote: > 'make ARCH=parisc vdso_install' has never worked. It attempts to > descend into arch/parisc/kernel/vdso/, which does not exist. > > The command just fails: > > scripts/Makefile.build:41: arch/parisc/kernel/vdso/Makefile: No such file or directory > > The second line is also meaningless because parisc does not define > CONFIG_COMPAT_VDSO. > > It appears that this code was copied from another architecture without > proper adaptation. Yes. > Remove the broken code. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Thanks for cleaning this up and making it consistent across the architectures. Acked-by: Helge Deller <deller@gmx.de> # parisc In case you do a v2 version of the patch, would you add to arch/parisc/Makefile (otherwise I can send a follow-up patch in the parisc git tree): vdso-install-y += arch/parisc/kernel/vdso32/vdso32.so vdso-install-$(CONFIG_64BIT) += arch/parisc/kernel/vdso64/vdso64.so Thanks! Helge
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile index 968ebe17494c..4222fa73c34a 100644 --- a/arch/parisc/Makefile +++ b/arch/parisc/Makefile @@ -177,13 +177,6 @@ vdso_prepare: prepare0 $(Q)$(MAKE) $(build)=arch/parisc/kernel/vdso32 include/generated/vdso32-offsets.h endif -PHONY += vdso_install - -vdso_install: - $(Q)$(MAKE) $(build)=arch/parisc/kernel/vdso $@ - $(if $(CONFIG_COMPAT_VDSO), \ - $(Q)$(MAKE) $(build)=arch/parisc/kernel/vdso32 $@) - install: KBUILD_IMAGE := vmlinux zinstall: KBUILD_IMAGE := vmlinuz install zinstall:
'make ARCH=parisc vdso_install' has never worked. It attempts to descend into arch/parisc/kernel/vdso/, which does not exist. The command just fails: scripts/Makefile.build:41: arch/parisc/kernel/vdso/Makefile: No such file or directory The second line is also meaningless because parisc does not define CONFIG_COMPAT_VDSO. It appears that this code was copied from another architecture without proper adaptation. Remove the broken code. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- arch/parisc/Makefile | 7 ------- 1 file changed, 7 deletions(-)