mbox series

[v2,0/2] PCI: qcom: Enable ASPM on host bridge and devices

Message ID 20231010155914.9516-1-manivannan.sadhasivam@linaro.org (mailing list archive)
Headers show
Series PCI: qcom: Enable ASPM on host bridge and devices | expand

Message

Manivannan Sadhasivam Oct. 10, 2023, 3:59 p.m. UTC 
Hi,

This series enables ASPM by default on the host bridge and devices of selected
Qcom platforms.

The motivation behind enabling ASPM in the controller driver is provided in the
commit message of patch 2/2.

This series has been tested on SC8280-CRD and Lenovo Thinkpad X13s laptop
and it helped save ~0.6W of power during runtime.

- Mani

Changes in v2:

* Rebased on top of v6.6-rc1

Manivannan Sadhasivam (2):
  PCI: dwc: Add host_post_init() callback
  PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops

 .../pci/controller/dwc/pcie-designware-host.c |  3 ++
 drivers/pci/controller/dwc/pcie-designware.h  |  1 +
 drivers/pci/controller/dwc/pcie-qcom.c        | 28 +++++++++++++++++++
 3 files changed, 32 insertions(+)

Comments

Konrad Dybcio Oct. 10, 2023, 4:25 p.m. UTC | #1 
On 10/10/23 17:59, Manivannan Sadhasivam wrote:
> Hi,
> 
> This series enables ASPM by default on the host bridge and devices of selected
> Qcom platforms.
> 
> The motivation behind enabling ASPM in the controller driver is provided in the
> commit message of patch 2/2.
> 
> This series has been tested on SC8280-CRD and Lenovo Thinkpad X13s laptop
> and it helped save ~0.6W of power during runtime.
That's a lot of power, thanks for looking into this!

Konrad
Krzysztof Wilczyński Oct. 14, 2023, 8:32 p.m. UTC | #2 
Hello,

> This series enables ASPM by default on the host bridge and devices of selected
> Qcom platforms.
> 
> The motivation behind enabling ASPM in the controller driver is provided in the
> commit message of patch 2/2.
> 
> This series has been tested on SC8280-CRD and Lenovo Thinkpad X13s laptop
> and it helped save ~0.6W of power during runtime.

Applied to controller/aspm, thank you!

[1/2] PCI: dwc: Add host_post_init() callback
      https://git.kernel.org/pci/pci/c/a78794562fcb
[2/2] PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops
      https://git.kernel.org/pci/pci/c/9f4f3dfad8cf

	Krzysztof