[v2,0/3] Add RTC for MStar SSD20xD SoCs

Message

Romain Perier Sept. 13, 2023, 3:16 p.m. UTC

This patches series adds a new driver for the RTC found in the Mstar
SSD202D SoCs. It adds a basic rtc driver, the corresponding devicetree
bindings.

The rtctest (from selftests) has been passed on this driver, with the
following output:

# rtctest 
TAP version 13
1..8
# Starting 8 tests from 1 test cases.
#  RUN           rtc.date_read ...
# rtctest.c:52:date_read:Current RTC date/time is 17/05/2023 15:58:12.
#            OK  rtc.date_read
ok 1 rtc.date_read
#  RUN           rtc.date_read_loop ...
# rtctest.c:95:date_read_loop:Continuously reading RTC time for 30s (with 11ms breaks after every read).
# rtctest.c:122:date_read_loop:Performed 888 RTC time reads.
#            OK  rtc.date_read_loop
ok 2 rtc.date_read_loop
#  RUN           rtc.uie_read ...
# rtctest.c:137:uie_read:skip update IRQs not supported.
#            OK  rtc.uie_read
ok 3 rtc.uie_read
#  RUN           rtc.uie_select ...
# rtctest.c:166:uie_select:skip update IRQs not supported.
#            OK  rtc.uie_select
ok 4 rtc.uie_select
#  RUN           rtc.alarm_alm_set ...
# rtctest.c:214:alarm_alm_set:skip alarms are not supported.
#            OK  rtc.alarm_alm_set
ok 5 rtc.alarm_alm_set
#  RUN           rtc.alarm_wkalm_set ...
# rtctest.c:274:alarm_wkalm_set:skip alarms are not supported.
#            OK  rtc.alarm_wkalm_set
ok 6 rtc.alarm_wkalm_set
#  RUN           rtc.alarm_alm_set_minute ...
# rtctest.c:324:alarm_alm_set_minute:skip alarms are not supported.
#            OK  rtc.alarm_alm_set_minute
ok 7 rtc.alarm_alm_set_minute
#  RUN           rtc.alarm_wkalm_set_minute ...
# rtctest.c:384:alarm_wkalm_set_minute:skip alarms are not supported.
#            OK  rtc.alarm_wkalm_set_minute
ok 8 rtc.alarm_wkalm_set_minute
# PASSED: 8 / 8 tests passed.
# Totals: pass:8 fail:0 xfail:0 xpass:0 skip:0 error:0

Changes since v1:
- Changed the compatible from mstar,ssd20xd-rtc to mstar,ssd20d-rtc.
  So the driver, its documentation and the commit messages have been
  reworked accordingly.
- Re-worked the dt-binding, I have also simplified the commit message
- Re-worked the commit message for the driver
- Remove redundant logging message for the user in the driver, as
  requested by the subsystem maintainer. As these messages are helpful
  for debugging purpose, I have switched these to dev_dbg().
- Updated the list of maintainers (sorry for that).

Romain Perier (3):
  rtc: Add support for the SSD202D RTC
  dt-bindings: rtc: Add Mstar SSD202D RTC
  ARM: dts: mstar: Enable rtc for SSD202D

 .../bindings/rtc/mstar,ssd202d-rtc.yaml       |  35 +++
 .../boot/dts/sigmastar/mstar-infinity2m.dtsi  |   5 +
 drivers/rtc/Kconfig                           |  11 +
 drivers/rtc/Makefile                          |   1 +
 drivers/rtc/rtc-ssd202d.c                     | 249 ++++++++++++++++++
 5 files changed, 301 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rtc/mstar,ssd202d-rtc.yaml
 create mode 100644 drivers/rtc/rtc-ssd202d.c

Comments

Alexandre Belloni Oct. 16, 2023, 2:55 p.m. UTC | #1

On Wed, 13 Sep 2023 17:16:03 +0200, Romain Perier wrote:
> This patches series adds a new driver for the RTC found in the Mstar
> SSD202D SoCs. It adds a basic rtc driver, the corresponding devicetree
> bindings.
> 
> The rtctest (from selftests) has been passed on this driver, with the
> following output:
> 
> [...]

Applied, thanks!

[1/3] rtc: Add support for the SSD202D RTC
      commit: ebf6255868e6141c737cacb8d62b0b347f344877
[2/3] dt-bindings: rtc: Add Mstar SSD202D RTC
      commit: cfb67623ce281e045ec11e3eddb1b68b879b53a1

Best regards,

Romain Perier Oct. 17, 2023, 6:09 a.m. UTC | #2

Le lun. 16 oct. 2023 à 16:55, Alexandre Belloni
<[e-mail]> a écrit :
>
>
> On Wed, 13 Sep 2023 17:16:03 +0200, Romain Perier wrote:
> > This patches series adds a new driver for the RTC found in the Mstar
> > SSD202D SoCs. It adds a basic rtc driver, the corresponding devicetree
> > bindings.
> >
> > The rtctest (from selftests) has been passed on this driver, with the
> > following output:
> >
> > [...]
>
> Applied, thanks!

Hi,

Thanks!

>
> [1/3] rtc: Add support for the SSD202D RTC
>       commit: ebf6255868e6141c737cacb8d62b0b347f344877
> [2/3] dt-bindings: rtc: Add Mstar SSD202D RTC
>       commit: cfb67623ce281e045ec11e3eddb1b68b879b53a1
>
> Best regards,

Ah , you also merged dt-bindings, Conor (from dt maintainers) prefers
trivial-rtc.yaml, it makes sense with the current driver.
I planned to make the change for trivial-rtc in v3, so I can adapt the
commit and rename  mstar,ssd202d-rtc.yaml to trivial-rtc.yaml, what do
you think ?

Regards,
Romain



>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Alexandre Belloni Oct. 18, 2023, 8:27 a.m. UTC | #3

On 17/10/2023 08:09:10+0200, Romain Perier wrote:
> Le lun. 16 oct. 2023 à 16:55, Alexandre Belloni
> <[e-mail]> a écrit :
> >
> >
> > On Wed, 13 Sep 2023 17:16:03 +0200, Romain Perier wrote:
> > > This patches series adds a new driver for the RTC found in the Mstar
> > > SSD202D SoCs. It adds a basic rtc driver, the corresponding devicetree
> > > bindings.
> > >
> > > The rtctest (from selftests) has been passed on this driver, with the
> > > following output:
> > >
> > > [...]
> >
> > Applied, thanks!
> 
> Hi,
> 
> Thanks!
> 
> >
> > [1/3] rtc: Add support for the SSD202D RTC
> >       commit: ebf6255868e6141c737cacb8d62b0b347f344877
> > [2/3] dt-bindings: rtc: Add Mstar SSD202D RTC
> >       commit: cfb67623ce281e045ec11e3eddb1b68b879b53a1
> >
> > Best regards,
> 
> Ah , you also merged dt-bindings, Conor (from dt maintainers) prefers
> trivial-rtc.yaml, it makes sense with the current driver.
> I planned to make the change for trivial-rtc in v3, so I can adapt the
> commit and rename  mstar,ssd202d-rtc.yaml to trivial-rtc.yaml, what do
> you think ?
> 

This is fine as-is.