mbox series

[GIT,PULL,FOR,6.7] CSI2RX, mostly camera sensor sensor patches

Message ID ZSaXrKkhP4AOH+Rh@valkosipuli.retiisi.eu (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL,FOR,6.7] CSI2RX, mostly camera sensor sensor patches | expand

Pull-request

git://linuxtv.org/sailus/media_tree.git tags/for-6.7-3.1-signed

Message

Sakari Ailus Oct. 11, 2023, 12:40 p.m. UTC 
Hi Hans, Mauro,

Here's another set of patches for 6.7. Included are, in particular:

- DT binding improvements by Jacopo,
- Pratyush's nand Jai's CSI2RX driver
- Fixes for recently merged CCS patches and mt9m114 driver
- Miscellaneous small stuff

Please pull.


The following changes since commit a1766a4fd83befa0b34d932d532e7ebb7fab1fa7:

  media: imon: fix access to invalid resource for the second interface (2023-10-07 10:55:48 +0200)

are available in the Git repository at:

  git://linuxtv.org/sailus/media_tree.git tags/for-6.7-3.1-signed

for you to fetch changes up to f4f5a574664f77796613401ccb9cc1d01a546dbd:

  media: ccs: Fix a (harmless) lockdep warning (2023-10-11 15:37:41 +0300)

----------------------------------------------------------------
V4L2 patches for 6.7

----------------------------------------------------------------
Jacopo Mondi (6):
      media: dt-bindings: hynix,hi846: Add video-interface-devices properties
      media: dt-bindings: ovti,ov02a10: Allow props from video-interface-devices
      media: dt-bindings: ovti,ov4689: Allow props from video-interface-devices
      media: dt-bindings: ovti,ov5640: Allow props from video-interface-devices
      media: dt-bindings: sony,imx214: Allow props from video-interface-devices
      media: dt-bindings: sony,imx415: Allow props from video-interface-devices

Jai Luthra (2):
      media: dt-bindings: cadence-csi2rx: Add TI compatible string
      media: ti: Add CSI2RX support for J721E

Laurent Pinchart (1):
      media: i2c: mt9m114: Fix missing error unwind in probe()

Pratyush Yadav (11):
      media: dt-bindings: Make sure items in data-lanes are unique
      media: cadence: csi2rx: Unregister v4l2 async notifier
      media: cadence: csi2rx: Cleanup media entity properly
      media: cadence: csi2rx: Add get_fmt and set_fmt pad ops
      media: cadence: csi2rx: Configure DPHY using link freq
      media: cadence: csi2rx: Soft reset the streams before starting capture
      media: cadence: csi2rx: Set the STOP bit when stopping a stream
      media: cadence: csi2rx: Fix stream data configuration
      media: cadence: csi2rx: Populate subdev devnode
      media: cadence: csi2rx: Add link validation
      media: dt-bindings: Add TI J721E CSI2RX

Ricardo B. Marliere (1):
      staging: media: ipu3: remove ftrace-like logging

Sakari Ailus (2):
      media: ccs: Rework initialising sub-device state
      media: ccs: Fix a (harmless) lockdep warning

Umang Jain (1):
      media: Documentation: ccs: Fix spelling mistake

 .../devicetree/bindings/media/cdns,csi2rx.yaml     |    1 +
 .../devicetree/bindings/media/i2c/hynix,hi846.yaml |    7 +-
 .../bindings/media/i2c/ovti,ov02a10.yaml           |    8 +-
 .../devicetree/bindings/media/i2c/ovti,ov4689.yaml |    6 +-
 .../devicetree/bindings/media/i2c/ovti,ov5640.yaml |    7 +-
 .../devicetree/bindings/media/i2c/sony,imx214.yaml |    2 +-
 .../devicetree/bindings/media/i2c/sony,imx415.yaml |   10 +-
 .../bindings/media/ti,j721e-csi2rx-shim.yaml       |  100 ++
 .../bindings/media/video-interfaces.yaml           |    1 +
 Documentation/driver-api/media/drivers/ccs/ccs.rst |    2 +-
 MAINTAINERS                                        |    7 +
 drivers/media/i2c/ccs/ccs-core.c                   |   62 +-
 drivers/media/i2c/mt9m114.c                        |    4 +-
 drivers/media/platform/cadence/cdns-csi2rx.c       |  176 ++-
 drivers/media/platform/ti/Kconfig                  |   12 +
 drivers/media/platform/ti/Makefile                 |    1 +
 drivers/media/platform/ti/j721e-csi2rx/Makefile    |    2 +
 .../media/platform/ti/j721e-csi2rx/j721e-csi2rx.c  | 1159 ++++++++++++++++++++
 drivers/staging/media/ipu3/ipu3.c                  |    6 -
 19 files changed, 1506 insertions(+), 67 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml
 create mode 100644 drivers/media/platform/ti/j721e-csi2rx/Makefile
 create mode 100644 drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c

Comments

Jenkins Oct. 11, 2023, 1:41 p.m. UTC | #1 
From: builder@linuxtv.org

Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/ZSaXrKkhP4AOH+Rh@valkosipuli.retiisi.eu/
Build log: https://builder.linuxtv.org/job/patchwork/347311/
Build time: 00:32:17
Link: https://lore.kernel.org/linux-media/ZSaXrKkhP4AOH+Rh@valkosipuli.retiisi.eu

gpg: Signature made Wed 11 Oct 2023 12:37:54 PM UTC
gpg:                using DSA key 53AC58A5F5948636C04A1BF8141DFA54A1EC8DEA
gpg:                issuer "sakari.ailus@linux.intel.com"
gpg: Good signature from "Sakari Ailus <sakari.ailus@linux.intel.com>" [full]

Summary: got 3/24 patches with issues, being 1 at build time

Error/warnings:

patches/0001-staging-media-ipu3-remove-ftrace-like-logging.patch:

    allyesconfig: return code #0:
	../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr]
	../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr]
	../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples
	../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:446 gc0310_s_stream() warn: missing error code 'ret'
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2779 atomisp_cp_dvs_6axis_config() warn: missing unwind goto?
	../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:2878 atomisp_cp_morph_table() warn: missing unwind goto?

    allyesconfig: return code #0:
	../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto?
	../drivers/media/usb/dvb-usb-v2/af9035.c: ../drivers/media/usb/dvb-usb-v2/af9035.c:467 af9035_i2c_master_xfer() warn: inconsistent returns '&d->i2c_mutex'.
	  Locked on  : 326,387
	  Unlocked on: 465,467
	SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures
	../drivers/media/test-drivers/vivid/vivid-core.c: ../drivers/media/test-drivers/vivid/vivid-core.c:1974 vivid_create_instance() parse error: turning off implications after 60 seconds
	../drivers/media/i2c/mt9m114.c: ../drivers/media/i2c/mt9m114.c:2381 mt9m114_probe() warn: missing unwind goto?
	../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687.
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2438 dvb_register() parse error: turning off implications after 60 seconds
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2517 dvb_register() parse error: OOM: 3013952Kb sm_state_count = 1755691
	../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2517 dvb_register() parse error: __split_smt: function too hairy.  Giving up after 63 seconds
	../drivers/media/pci/cx25821/cx25821-medusa-video.c: ../drivers/media/pci/cx25821/cx25821-medusa-video.c:399 medusa_set_videostandard() parse error: OOM: 3003988Kb sm_state_count = 2158
	../drivers/media/pci/cx25821/cx25821-medusa-video.c: ../drivers/media/pci/cx25821/cx25821-medusa-video.c:399 medusa_set_videostandard() parse error: __split_smt: function too hairy.  Giving up after 3 seconds
	../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2792 mxc_jpeg_probe() warn: missing unwind goto?
	../drivers/media/pci/mgb4/mgb4_sysfs_out.c: ../drivers/media/pci/mgb4/mgb4_sysfs_out.c:118 video_source_store() warn: potential spectre issue 'mgbdev->vin' [r] (local cap)
	../drivers/media/pci/mgb4/mgb4_sysfs_out.c: ../drivers/media/pci/mgb4/mgb4_sysfs_out.c:122 video_source_store() warn: possible spectre second half.  'loopin_new'
	../drivers/media/usb/uvc/uvc_v4l2.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../include/linux/rcuwait.h, ...):
	SPARSE:../drivers/media/usb/uvc/uvc_v4l2.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
	../drivers/media/pci/ivtv/ivtvfb.c: note: in included file (through ../arch/x86/include/asm/uaccess.h, ../include/linux/uaccess.h, ../include/linux/sched/task.h, ../include/linux/sched/signal.h, ../drivers/media/pci/ivtv/ivtv-driver.h):
	SPARSE:../drivers/media/pci/ivtv/ivtvfb.c ../arch/x86/include/asm/uaccess_64.h:88:24: warning: cast removes address space '__user' of expression
	../drivers/media/usb/em28xx/em28xx-video.c: ../drivers/media/usb/em28xx/em28xx-video.c:2831 em28xx_v4l2_init() parse error: turning off implications after 60 seconds

patches/0014-media-dt-bindings-Add-TI-J721E-CSI2RX.patch:

   checkpatch.pl:
	$ cat patches/0014-media-dt-bindings-Add-TI-J721E-CSI2RX.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:22: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

patches/0015-media-ti-Add-CSI2RX-support-for-J721E.patch:

   checkpatch.pl:
	$ cat patches/0015-media-ti-Add-CSI2RX-support-for-J721E.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
	-:65: WARNING: please write a help paragraph that fully describes the config symbol
Jai Luthra Oct. 17, 2023, 7:50 a.m. UTC | #2 
Hi Sakari, Hans, Mauro,

On Oct 11, 2023 at 12:40:12 +0000, Sakari Ailus wrote:
> Hi Hans, Mauro,
> 
> Here's another set of patches for 6.7. Included are, in particular:
> 
> - DT binding improvements by Jacopo,
> - Pratyush's nand Jai's CSI2RX driver

I have posted two minor fixes for warnings reported by Intel LKP bot 
introduced by my CSI series.

1. https://lore.kernel.org/linux-media/20231013-maintainers_path-v1-1-e28bdcc96ef2@ti.com/
2. https://lore.kernel.org/linux-media/20231017-cdns_phy_config-v1-1-583243d1c187@ti.com/

Hopefully these can be applied before the PR is sent out for 6.7-rc1.

--
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

> - Fixes for recently merged CCS patches and mt9m114 driver
> - Miscellaneous small stuff
> 
> Please pull.
> 
> 
> The following changes since commit a1766a4fd83befa0b34d932d532e7ebb7fab1fa7:
> 
>   media: imon: fix access to invalid resource for the second interface (2023-10-07 10:55:48 +0200)
> 
> are available in the Git repository at:
> 
>   git://linuxtv.org/sailus/media_tree.git tags/for-6.7-3.1-signed
> 
> for you to fetch changes up to f4f5a574664f77796613401ccb9cc1d01a546dbd:
> 
>   media: ccs: Fix a (harmless) lockdep warning (2023-10-11 15:37:41 +0300)
> 
> ----------------------------------------------------------------
> V4L2 patches for 6.7
> 
> ----------------------------------------------------------------
> Jacopo Mondi (6):
>       media: dt-bindings: hynix,hi846: Add video-interface-devices properties
>       media: dt-bindings: ovti,ov02a10: Allow props from video-interface-devices
>       media: dt-bindings: ovti,ov4689: Allow props from video-interface-devices
>       media: dt-bindings: ovti,ov5640: Allow props from video-interface-devices
>       media: dt-bindings: sony,imx214: Allow props from video-interface-devices
>       media: dt-bindings: sony,imx415: Allow props from video-interface-devices
> 
> Jai Luthra (2):
>       media: dt-bindings: cadence-csi2rx: Add TI compatible string
>       media: ti: Add CSI2RX support for J721E
> 
> Laurent Pinchart (1):
>       media: i2c: mt9m114: Fix missing error unwind in probe()
> 
> Pratyush Yadav (11):
>       media: dt-bindings: Make sure items in data-lanes are unique
>       media: cadence: csi2rx: Unregister v4l2 async notifier
>       media: cadence: csi2rx: Cleanup media entity properly
>       media: cadence: csi2rx: Add get_fmt and set_fmt pad ops
>       media: cadence: csi2rx: Configure DPHY using link freq
>       media: cadence: csi2rx: Soft reset the streams before starting capture
>       media: cadence: csi2rx: Set the STOP bit when stopping a stream
>       media: cadence: csi2rx: Fix stream data configuration
>       media: cadence: csi2rx: Populate subdev devnode
>       media: cadence: csi2rx: Add link validation
>       media: dt-bindings: Add TI J721E CSI2RX
> 
> Ricardo B. Marliere (1):
>       staging: media: ipu3: remove ftrace-like logging
> 
> Sakari Ailus (2):
>       media: ccs: Rework initialising sub-device state
>       media: ccs: Fix a (harmless) lockdep warning
> 
> Umang Jain (1):
>       media: Documentation: ccs: Fix spelling mistake
> 
>  .../devicetree/bindings/media/cdns,csi2rx.yaml     |    1 +
>  .../devicetree/bindings/media/i2c/hynix,hi846.yaml |    7 +-
>  .../bindings/media/i2c/ovti,ov02a10.yaml           |    8 +-
>  .../devicetree/bindings/media/i2c/ovti,ov4689.yaml |    6 +-
>  .../devicetree/bindings/media/i2c/ovti,ov5640.yaml |    7 +-
>  .../devicetree/bindings/media/i2c/sony,imx214.yaml |    2 +-
>  .../devicetree/bindings/media/i2c/sony,imx415.yaml |   10 +-
>  .../bindings/media/ti,j721e-csi2rx-shim.yaml       |  100 ++
>  .../bindings/media/video-interfaces.yaml           |    1 +
>  Documentation/driver-api/media/drivers/ccs/ccs.rst |    2 +-
>  MAINTAINERS                                        |    7 +
>  drivers/media/i2c/ccs/ccs-core.c                   |   62 +-
>  drivers/media/i2c/mt9m114.c                        |    4 +-
>  drivers/media/platform/cadence/cdns-csi2rx.c       |  176 ++-
>  drivers/media/platform/ti/Kconfig                  |   12 +
>  drivers/media/platform/ti/Makefile                 |    1 +
>  drivers/media/platform/ti/j721e-csi2rx/Makefile    |    2 +
>  .../media/platform/ti/j721e-csi2rx/j721e-csi2rx.c  | 1159 ++++++++++++++++++++
>  drivers/staging/media/ipu3/ipu3.c                  |    6 -
>  19 files changed, 1506 insertions(+), 67 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/media/ti,j721e-csi2rx-shim.yaml
>  create mode 100644 drivers/media/platform/ti/j721e-csi2rx/Makefile
>  create mode 100644 drivers/media/platform/ti/j721e-csi2rx/j721e-csi2rx.c
> 
> -- 
> Sakari Ailus
Sakari Ailus Oct. 17, 2023, 7:56 a.m. UTC | #3 
Hi Jai,

On Tue, Oct 17, 2023 at 01:20:56PM +0530, Jai Luthra wrote:
> Hi Sakari, Hans, Mauro,
> 
> On Oct 11, 2023 at 12:40:12 +0000, Sakari Ailus wrote:
> > Hi Hans, Mauro,
> > 
> > Here's another set of patches for 6.7. Included are, in particular:
> > 
> > - DT binding improvements by Jacopo,
> > - Pratyush's nand Jai's CSI2RX driver
> 
> I have posted two minor fixes for warnings reported by Intel LKP bot 
> introduced by my CSI series.
> 
> 1. https://lore.kernel.org/linux-media/20231013-maintainers_path-v1-1-e28bdcc96ef2@ti.com/
> 2. https://lore.kernel.org/linux-media/20231017-cdns_phy_config-v1-1-583243d1c187@ti.com/
> 
> Hopefully these can be applied before the PR is sent out for 6.7-rc1.

I'll pick these later today.