| Message ID | 20230925131720.7672-1-mark-pk.tsai@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] ARM: vfp: Add missing VFP instructions to neon_support_hook | expand |
On Mon, 2023-09-25 at 21:17 +0800, Mark-PK Tsai wrote: > Add the missing "Unconditional Advanced SIMD and floating-point > instructions" in [1] to the VFP undef hook. > > This commit addresses the issue reported in [2], where > executing the vudot instruction on a platform with FEAT_DotProd > support resulted in an undefined instruction error. > > Link: > https://developer.arm.com/documentation/ddi0597/2023-06/?lang=en [1] > Link: > https://lore.kernel.org/lkml/20230920083907.30479-1-mark-pk.tsai@mediatek.com/ > [2] > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com> > --- > arch/arm/vfp/vfpmodule.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c > index 7e8773a2d99d..b68efe643a12 100644 > --- a/arch/arm/vfp/vfpmodule.c > +++ b/arch/arm/vfp/vfpmodule.c > @@ -800,6 +800,24 @@ static struct undef_hook neon_support_hook[] = > {{ > .cpsr_mask = PSR_T_BIT, > .cpsr_val = PSR_T_BIT, > .fn = vfp_support_entry, > +}, { > + .instr_mask = 0xff000800, > + .instr_val = 0xfc000800, > + .cpsr_mask = 0, > + .cpsr_val = 0, > + .fn = vfp_support_entry, > +}, { > + .instr_mask = 0xff000800, > + .instr_val = 0xfd000800, > + .cpsr_mask = 0, > + .cpsr_val = 0, > + .fn = vfp_support_entry, > +}, { > + .instr_mask = 0xff000800, > + .instr_val = 0xfe000800, > + .cpsr_mask = 0, > + .cpsr_val = 0, > + .fn = vfp_support_entry, > }}; Could someone please kindly review this patch? Thanks.
On Wed, Oct 11, 2023 at 10:51 AM Mark-PK Tsai (蔡沛剛) <Mark-PK.Tsai@mediatek.com> wrote: > > On Mon, 2023-09-25 at 21:17 +0800, Mark-PK Tsai wrote: > > Add the missing "Unconditional Advanced SIMD and floating-point > > instructions" in [1] to the VFP undef hook. > > > > This commit addresses the issue reported in [2], where > > executing the vudot instruction on a platform with FEAT_DotProd > > support resulted in an undefined instruction error. > > > > Link: > > https://developer.arm.com/documentation/ddi0597/2023-06/?lang=en [1] > > Link: > > https://lore.kernel.org/lkml/20230920083907.30479-1-mark-pk.tsai@mediatek.com/ > > [2] > > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com> > > --- > > arch/arm/vfp/vfpmodule.c | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c > > index 7e8773a2d99d..b68efe643a12 100644 > > --- a/arch/arm/vfp/vfpmodule.c > > +++ b/arch/arm/vfp/vfpmodule.c > > @@ -800,6 +800,24 @@ static struct undef_hook neon_support_hook[] = > > {{ > > .cpsr_mask = PSR_T_BIT, > > .cpsr_val = PSR_T_BIT, > > .fn = vfp_support_entry, > > +}, { > > + .instr_mask = 0xff000800, > > + .instr_val = 0xfc000800, > > + .cpsr_mask = 0, > > + .cpsr_val = 0, > > + .fn = vfp_support_entry, > > +}, { > > + .instr_mask = 0xff000800, > > + .instr_val = 0xfd000800, > > + .cpsr_mask = 0, > > + .cpsr_val = 0, > > + .fn = vfp_support_entry, > > +}, { > > + .instr_mask = 0xff000800, > > + .instr_val = 0xfe000800, > > + .cpsr_mask = 0, > > + .cpsr_val = 0, > > + .fn = vfp_support_entry, > > }}; > > Could someone please kindly review this patch? > Thanks. I tested on unisoc sharkl3 platform, and no problems occurred. Tested-by: Xuewen Yan <xuewen.yan@unisoc.com> Thanks!
On Wed, Oct 11, 2023 at 02:49:44AM +0000, Mark-PK Tsai (蔡沛剛) wrote: > On Mon, 2023-09-25 at 21:17 +0800, Mark-PK Tsai wrote: > > Add the missing "Unconditional Advanced SIMD and floating-point > > instructions" in [1] to the VFP undef hook. > > > > This commit addresses the issue reported in [2], where > > executing the vudot instruction on a platform with FEAT_DotProd > > support resulted in an undefined instruction error. > > > > Link: > > https://developer.arm.com/documentation/ddi0597/2023-06/?lang=en [1] > > Link: > > https://lore.kernel.org/lkml/20230920083907.30479-1-mark-pk.tsai@mediatek.com/ > > [2] > > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com> > > --- > > arch/arm/vfp/vfpmodule.c | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c > > index 7e8773a2d99d..b68efe643a12 100644 > > --- a/arch/arm/vfp/vfpmodule.c > > +++ b/arch/arm/vfp/vfpmodule.c > > @@ -800,6 +800,24 @@ static struct undef_hook neon_support_hook[] = > > {{ > > .cpsr_mask = PSR_T_BIT, > > .cpsr_val = PSR_T_BIT, > > .fn = vfp_support_entry, > > +}, { > > + .instr_mask = 0xff000800, > > + .instr_val = 0xfc000800, > > + .cpsr_mask = 0, > > + .cpsr_val = 0, > > + .fn = vfp_support_entry, > > +}, { > > + .instr_mask = 0xff000800, > > + .instr_val = 0xfd000800, > > + .cpsr_mask = 0, > > + .cpsr_val = 0, > > + .fn = vfp_support_entry, > > +}, { > > + .instr_mask = 0xff000800, > > + .instr_val = 0xfe000800, > > + .cpsr_mask = 0, > > + .cpsr_val = 0, > > + .fn = vfp_support_entry, > > }}; > > Could someone please kindly review this patch? > Thanks. And if someone drops it into the patch system then it might get applied before the merge window. Thanks.
diff --git a/arch/arm/vfp/vfpmodule.c b/arch/arm/vfp/vfpmodule.c index 7e8773a2d99d..b68efe643a12 100644 --- a/arch/arm/vfp/vfpmodule.c +++ b/arch/arm/vfp/vfpmodule.c @@ -800,6 +800,24 @@ static struct undef_hook neon_support_hook[] = {{ .cpsr_mask = PSR_T_BIT, .cpsr_val = PSR_T_BIT, .fn = vfp_support_entry, +}, { + .instr_mask = 0xff000800, + .instr_val = 0xfc000800, + .cpsr_mask = 0, + .cpsr_val = 0, + .fn = vfp_support_entry, +}, { + .instr_mask = 0xff000800, + .instr_val = 0xfd000800, + .cpsr_mask = 0, + .cpsr_val = 0, + .fn = vfp_support_entry, +}, { + .instr_mask = 0xff000800, + .instr_val = 0xfe000800, + .cpsr_mask = 0, + .cpsr_val = 0, + .fn = vfp_support_entry, }}; static struct undef_hook vfp_support_hook = {
Add the missing "Unconditional Advanced SIMD and floating-point instructions" in [1] to the VFP undef hook. This commit addresses the issue reported in [2], where executing the vudot instruction on a platform with FEAT_DotProd support resulted in an undefined instruction error. Link: https://developer.arm.com/documentation/ddi0597/2023-06/?lang=en [1] Link: https://lore.kernel.org/lkml/20230920083907.30479-1-mark-pk.tsai@mediatek.com/ [2] Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com> --- arch/arm/vfp/vfpmodule.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)