mbox series

[v12,00/11] Add VIRTIO sound card

Message ID cover.1697709630.git.manos.pitsidianakis@linaro.org (mailing list archive)
Headers show
Series Add VIRTIO sound card | expand

Message

Manos Pitsidianakis Oct. 19, 2023, 10:03 a.m. UTC 
This patch series adds an audio device implementing the recent virtio
sound spec (1.2) and a corresponding PCI wrapper device.

v12 can be found online at:

https://gitlab.com/epilys/qemu/-/tree/virtio-snd-v12

Ref c660c8427853d90784a89b6f3b0c31e19cc3be95

Main differences with v11 patch series [^v11]:

- Moved devices from hw/virtio under hw/audio.

v10[^v10] -> v11[^v11]
======================

- Rebased against upstream, which has minor changes to the AUD_* API.
- Fixed noise in playback because of invalid bounds when accessing the
  audio data in the VirtQueueElement.
- Refactor invalid I/O message queue flushing into separate function.
- Removed attempt to write unwritten bytes to QEMU sound backend when
  flushing: it should only happen when the stream STARTs.
- Set latency_bytes to buffer size when returning TX I/O message because
  it happens immediately after writing the last bytes to the QEMU
  backend, therefore there might be up to <buffer size> bytes to be
  played before all the buffer data has finished playing.
- Addressed [^v10] review comments:
  - Refactored VirtIOSoundPCMBuffer return code into a function instead
    of using goto labels in output/input audio callbacks. (Suggested by
    <philmd@linaro.org>)

v9[^v9] -> v10[^v10]
====================

- Addressed [^v9] review comments.
- Copy buffer data just before playing it on the host instead of when
  the IO message arrives. This in most cases takes care of the buffer
  not being populated with data from the guest application when it
  firsts arrives.

v8[^v8] -> v9[^v9]
==================

- Addressed [^v8] review comments.
- Add cpu_to_le32(_) and le32_to_cpu(_) conversions for messages from/to
  the guest according to the virtio spec.
- Inlined some functions and types to reduce review complexity.
- Corrected the replies to IO messages; now both Playback and Capture
  work correctly for me. (If you hear cracks in pulseaudio+guest, try
  pipewire+guest).

v7[^v7] -> v8[^v8]
==================

- Addressed [^v7] review comments.
  Functions that were called from more than one place for code re-use
  are not created until they are actually needed.
- Fixed cases where block->offset was not respected in Playback

v6[^v6] -> v7[^v7]
==================

- Removed minor stale/duplicate code.
- Addressed [^v6] review comments.
  Notably, the audio driver name is now `virtio` instead of
  `virtio-sound`.
- Fixed some invalid pointer logic.
- Fixed minor typos and updated documentation.

v5[^v5] -> v6[^v6]
==================

- Free any existing PCM stream resources before allocating a new one.
- Add docs.

v4[^v4] -> v5[^v5]
==================

- Use ERRP_GUARD() to propagate errors.
- Use virtio_add_feature() instead of XORing constants.
- Use %zu format specifier for size_t.

v3[^v3] -> v4[^v4]
==================

- Addressed review style comments.
- Split patches for easier review.

v2[^v2] -> v3[^v3]
==================

- Addressed review comments.

v1[^v1] -> v2[^v2]
==================

- Split virtio-snd and virtio-snd-pci devices to two commits
- Added audio capture support

Previously:

[^v11]:
https://lore.kernel.org/qemu-devel/cover.1696935992.git.manos.pitsidianakis@linaro.org/
[^v10]:
https://lore.kernel.org/qemu-devel/cover.1695996196.git.manos.pitsidianakis@linaro.org/
[^v9]:
https://lore.kernel.org/qemu-devel/cover.1694588927.git.manos.pitsidianakis@linaro.org/
[^v8]:
https://lore.kernel.org/qemu-devel/cover.1693252037.git.manos.pitsidianakis@linaro.org/
[^v7]:
https://lore.kernel.org/qemu-devel/cover.1692731646.git.manos.pitsidianakis@linaro.org/
[^v6]:
https://lore.kernel.org/qemu-devel/cover.1692089917.git.manos.pitsidianakis@linaro.org/
[^v5]:
https://lore.kernel.org/qemu-devel/cover.1690626150.git.manos.pitsidianakis@linaro.org/
[^v4]:
https://lore.kernel.org/qemu-devel/cover.1689857559.git.manos.pitsidianakis@linaro.org/
[^v3]:
https://lore.kernel.org/qemu-devel/cover.1689692765.git.manos.pitsidianakis@linaro.org/
[^v2]:
https://lore.kernel.org/qemu-devel/cover.1686238728.git.manos.pitsidianakis@linaro.org/
[^v1]:
https://lore.kernel.org/qemu-devel/20230526204845.673031-1-manos.pitsidianakis@linaro.org/

Emmanouil Pitsidianakis (11):
  Add virtio-sound device stub
  Add virtio-sound-pci device
  virtio-sound: handle control messages and streams
  virtio-sound: handle VIRTIO_SND_R_PCM_INFO request
  virtio-sound: handle VIRTIO_SND_R_PCM_{START,STOP}
  virtio-sound: handle VIRTIO_SND_R_PCM_SET_PARAMS
  virtio-sound: handle VIRTIO_SND_R_PCM_PREPARE
  virtio-sound: handle VIRTIO_SND_R_PCM_RELEASE
  virtio-sound: implement audio output (TX)
  virtio-sound: implement audio capture (RX)
  docs/system: add basic virtio-snd documentation

 MAINTAINERS                        |    9 +
 docs/system/device-emulation.rst   |    1 +
 docs/system/devices/virtio-snd.rst |   49 +
 hw/audio/Kconfig                   |    5 +
 hw/audio/meson.build               |    2 +
 hw/audio/trace-events              |   20 +
 hw/audio/virtio-snd-pci.c          |   93 ++
 hw/audio/virtio-snd.c              | 1409 ++++++++++++++++++++++++++++
 include/hw/audio/virtio-snd.h      |  235 +++++
 system/qdev-monitor.c              |    1 +
 10 files changed, 1824 insertions(+)
 create mode 100644 docs/system/devices/virtio-snd.rst
 create mode 100644 hw/audio/virtio-snd-pci.c
 create mode 100644 hw/audio/virtio-snd.c
 create mode 100644 include/hw/audio/virtio-snd.h


base-commit: deaca3fd30d3a8829160f8d3705d65ad83176800

Comments

Alex Bennée Oct. 19, 2023, 2:37 p.m. UTC | #1 
Emmanouil Pitsidianakis <manos.pitsidianakis@linaro.org> writes:

> This patch series adds an audio device implementing the recent virtio
> sound spec (1.2) and a corresponding PCI wrapper device.
>
> v12 can be found online at:
>
> https://gitlab.com/epilys/qemu/-/tree/virtio-snd-v12
>
> Ref c660c8427853d90784a89b6f3b0c31e19cc3be95
>
> Main differences with v11 patch series [^v11]:
>
> - Moved devices from hw/virtio under hw/audio.


OK I've tested record and playback and everything seems to be working
fine so have a:

Tested-by: Alex Bennée <alex.bennee@linaro.org>

for the series.

Gerd,

Are you happy to merge?