| Message ID | 20231019194514.2115506-1-willy@infradead.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Put seq_buf on a diet | expand |
On Thu, 19 Oct 2023 20:45:13 +0100 "Matthew Wilcox (Oracle)" <willy@infradead.org> wrote: > Prompted by the recent mails on ksummit, let's actually try to make this > work this time. We need a container for manipulating strings easily, > and seq_buf is the closest thing we have to it. The only problem I have > with it is the readpos that is only useful for the tracing code today. > So move it from the seq_buf to the tracing code. > > We should go further with this patch series, including using seq_buf > within vsprintf, but if we can't get over this hurdle first, I'm not > going to waste my time on this again. > > Matthew Wilcox (Oracle) (1): > trace: Move readpos from seq_buf to trace_seq > > include/linux/seq_buf.h | 5 +---- > include/linux/trace_seq.h | 2 ++ > kernel/trace/trace.c | 10 +++++----- > kernel/trace/trace_seq.c | 6 +++++- > lib/seq_buf.c | 13 +++++-------- > 5 files changed, 18 insertions(+), 18 deletions(-) > Thanks Matthew, I'll pull this in and add it to my for-next queue (after testing) -- Steve
On Thu, 19 Oct 2023 17:14:39 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > On Thu, 19 Oct 2023 20:45:13 +0100 > "Matthew Wilcox (Oracle)" <willy@infradead.org> wrote: > > > Prompted by the recent mails on ksummit, let's actually try to make this > > work this time. We need a container for manipulating strings easily, > > and seq_buf is the closest thing we have to it. The only problem I have > > with it is the readpos that is only useful for the tracing code today. > > So move it from the seq_buf to the tracing code. > > > > We should go further with this patch series, including using seq_buf > > within vsprintf, but if we can't get over this hurdle first, I'm not > > going to waste my time on this again. > > > > Matthew Wilcox (Oracle) (1): > > trace: Move readpos from seq_buf to trace_seq > > > > include/linux/seq_buf.h | 5 +---- > > include/linux/trace_seq.h | 2 ++ > > kernel/trace/trace.c | 10 +++++----- > > kernel/trace/trace_seq.c | 6 +++++- > > lib/seq_buf.c | 13 +++++-------- > > 5 files changed, 18 insertions(+), 18 deletions(-) > > > > Thanks Matthew, I'll pull this in and add it to my for-next queue (after > testing) Actually, Can you resend it, and Cc: linux-trace-kernel@vger.kernel.org so that it goes into patchwork. Thanks! -- Steve