diff mbox series

crypto: qcom-rng - Add missing dependency on hw_random

Message ID 20231016-qcom_rng-v1-1-1a7d7856651e@apitzsch.eu (mailing list archive)
State Not Applicable
Headers show
Series crypto: qcom-rng - Add missing dependency on hw_random | expand

Commit Message

André Apitzsch Oct. 16, 2023, 5:45 p.m. UTC 
This should fix the undefined reference:

> /usr/bin/aarch64-alpine-linux-musl-ld: Unexpected GOT/PLT entries detected!
> /usr/bin/aarch64-alpine-linux-musl-ld: Unexpected run-time procedure linkages detected!
> /usr/bin/aarch64-alpine-linux-musl-ld: drivers/crypto/qcom-rng.o: in function `qcom_rng_probe':
> qcom-rng.c:(.text+0x130): undefined reference to `devm_hwrng_register'

Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support")
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
 drivers/crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 4d0515b235dec789578d135a5db586b25c5870cb
change-id: 20231016-qcom_rng-e46c8a8628bb

Best regards,

Comments

Neil Armstrong Oct. 17, 2023, 7:12 a.m. UTC | #1 
On 16/10/2023 19:45, André Apitzsch wrote:
> This should fix the undefined reference:
> 
>> /usr/bin/aarch64-alpine-linux-musl-ld: Unexpected GOT/PLT entries detected!
>> /usr/bin/aarch64-alpine-linux-musl-ld: Unexpected run-time procedure linkages detected!
>> /usr/bin/aarch64-alpine-linux-musl-ld: drivers/crypto/qcom-rng.o: in function `qcom_rng_probe':
>> qcom-rng.c:(.text+0x130): undefined reference to `devm_hwrng_register'
> 
> Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support")
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
> ---
>   drivers/crypto/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index c761952f0dc6..79c3bb9c99c3 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -601,6 +601,7 @@ config CRYPTO_DEV_QCE_SW_MAX_LEN
>   config CRYPTO_DEV_QCOM_RNG
>   	tristate "Qualcomm Random Number Generator Driver"
>   	depends on ARCH_QCOM || COMPILE_TEST
> +	depends on HW_RANDOM
>   	select CRYPTO_RNG
>   	help
>   	  This driver provides support for the Random Number
> 
> ---
> base-commit: 4d0515b235dec789578d135a5db586b25c5870cb
> change-id: 20231016-qcom_rng-e46c8a8628bb
> 
> Best regards,

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Herbert Xu Oct. 20, 2023, 5:58 a.m. UTC | #2 
André Apitzsch <git@apitzsch.eu> wrote:
> This should fix the undefined reference:
> 
>> /usr/bin/aarch64-alpine-linux-musl-ld: Unexpected GOT/PLT entries detected!
>> /usr/bin/aarch64-alpine-linux-musl-ld: Unexpected run-time procedure linkages detected!
>> /usr/bin/aarch64-alpine-linux-musl-ld: drivers/crypto/qcom-rng.o: in function `qcom_rng_probe':
>> qcom-rng.c:(.text+0x130): undefined reference to `devm_hwrng_register'
> 
> Fixes: f29cd5bb64c2 ("crypto: qcom-rng - Add hw_random interface support")
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
> ---
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Patch applied.  Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index c761952f0dc6..79c3bb9c99c3 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -601,6 +601,7 @@  config CRYPTO_DEV_QCE_SW_MAX_LEN
 config CRYPTO_DEV_QCOM_RNG
 	tristate "Qualcomm Random Number Generator Driver"
 	depends on ARCH_QCOM || COMPILE_TEST
+	depends on HW_RANDOM
 	select CRYPTO_RNG
 	help
 	  This driver provides support for the Random Number