| Message ID | 98443e951c5c51fc0dbedf1e530d1c27e564e19e.1698053876.git.nicola.vetrini@bugseng.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix or deviate various instances of missing declarations | expand |
On 23.10.2023 11:56, Nicola Vetrini wrote: > The stub definition of 'consoled_guest_tx' can be removed, since its > its single caller uses the implementation built with PV_SHIM enabled. > > Fixes: 5ef49f185c2d ("x86/pv-shim: shadow PV console's page for L2 DomU") > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> Where did Stefano's R-b go? Jan
On 23/10/2023 12:21, Jan Beulich wrote: > On 23.10.2023 11:56, Nicola Vetrini wrote: >> The stub definition of 'consoled_guest_tx' can be removed, since its >> its single caller uses the implementation built with PV_SHIM enabled. >> >> Fixes: 5ef49f185c2d ("x86/pv-shim: shadow PV console's page for L2 >> DomU") >> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> > > Where did Stefano's R-b go? > > Jan I didn't notice it. Nothing has changed since, so it should be included
diff --git a/xen/include/xen/consoled.h b/xen/include/xen/consoled.h index fd5d220a8aca..2b30516b3a0a 100644 --- a/xen/include/xen/consoled.h +++ b/xen/include/xen/consoled.h @@ -3,18 +3,11 @@ #include <public/io/console.h> -#ifdef CONFIG_PV_SHIM - void consoled_set_ring_addr(struct xencons_interface *ring); struct xencons_interface *consoled_get_ring_addr(void); size_t consoled_guest_rx(void); size_t consoled_guest_tx(char c); -#else - -size_t consoled_guest_tx(char c) { return 0; } - -#endif /* !CONFIG_PV_SHIM */ #endif /* __XEN_CONSOLED_H__ */ /* * Local variables:
The stub definition of 'consoled_guest_tx' can be removed, since its its single caller uses the implementation built with PV_SHIM enabled. Fixes: 5ef49f185c2d ("x86/pv-shim: shadow PV console's page for L2 DomU") Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> --- xen/include/xen/consoled.h | 7 ------- 1 file changed, 7 deletions(-)