| Message ID | 20231023114449.2362147-2-srasheed@marvell.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Cleanup and optimizations to transmit code | expand |
| Context | Check | Description |
|---|---|---|
| netdev/series_format | success | Posting correctly formatted |
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 9 this patch: 9 |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/build_clang | success | Errors and warnings before: 1388 this patch: 1388 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/deprecated_api | success | None detected |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 1388 this patch: 1388 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 19 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
> -----Original Message----- > From: Shinas Rasheed <srasheed@marvell.com> > Sent: Monday, October 23, 2023 1:45 PM > To: netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: hgani@marvell.com; vimleshk@marvell.com; Gallen, Erwan <egallen@redhat.com>; mschmidt <mschmidt@redhat.com>; > pabeni@redhat.com; horms@kernel.org; kuba@kernel.org; davem@davemloft.net; Shinas Rasheed <srasheed@marvell.com>; > Veerasenareddy Burru <vburru@marvell.com>; Sathesh Edara <sedara@marvell.com>; Eric Dumazet <edumazet@google.com> > Subject: [PATCH net-next 1/3] octeon_ep: remove dma sync in trasmit path > > Cleanup dma sync calls for scatter gather > mappings in trasmit path > > Signed-off-by: Shinas Rasheed <srasheed@marvell.com> Hi Shinas, The commit msg only says what changed without justification. What is the reasoning behind those changes? > --- > drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c > index 552970c7dec0..bf1e376a4232 100644 > --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c > +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c > @@ -869,9 +869,6 @@ static netdev_tx_t octep_start_xmit(struct sk_buff *skb, > if (dma_mapping_error(iq->dev, dma)) > goto dma_map_err; > > - dma_sync_single_for_cpu(iq->dev, tx_buffer->sglist_dma, > - OCTEP_SGLIST_SIZE_PER_PKT, > - DMA_TO_DEVICE); > memset(sglist, 0, OCTEP_SGLIST_SIZE_PER_PKT); > sglist[0].len[3] = len; > sglist[0].dma_ptr[0] = dma; > @@ -891,10 +888,6 @@ static netdev_tx_t octep_start_xmit(struct sk_buff *skb, > frag++; > si++; > } > - dma_sync_single_for_device(iq->dev, tx_buffer->sglist_dma, > - OCTEP_SGLIST_SIZE_PER_PKT, > - DMA_TO_DEVICE); > - > hw_desc->dptr = tx_buffer->sglist_dma; > } > > -- > 2.25.1 >
diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c index 552970c7dec0..bf1e376a4232 100644 --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c @@ -869,9 +869,6 @@ static netdev_tx_t octep_start_xmit(struct sk_buff *skb, if (dma_mapping_error(iq->dev, dma)) goto dma_map_err; - dma_sync_single_for_cpu(iq->dev, tx_buffer->sglist_dma, - OCTEP_SGLIST_SIZE_PER_PKT, - DMA_TO_DEVICE); memset(sglist, 0, OCTEP_SGLIST_SIZE_PER_PKT); sglist[0].len[3] = len; sglist[0].dma_ptr[0] = dma; @@ -891,10 +888,6 @@ static netdev_tx_t octep_start_xmit(struct sk_buff *skb, frag++; si++; } - dma_sync_single_for_device(iq->dev, tx_buffer->sglist_dma, - OCTEP_SGLIST_SIZE_PER_PKT, - DMA_TO_DEVICE); - hw_desc->dptr = tx_buffer->sglist_dma; }
Cleanup dma sync calls for scatter gather mappings in trasmit path Signed-off-by: Shinas Rasheed <srasheed@marvell.com> --- drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 7 ------- 1 file changed, 7 deletions(-)