| Message ID | 1698052857-6918-5-git-send-email-quic_zhenhuah@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | soc/arm64: qcom: add initial version of memory dump | expand |
On 23/10/2023 11:20, Zhenhua Huang wrote: > Enable Qcom Memory Dump driver to allow storing debugging s/Qcom/Qualcomm/ > information after crash by firmware, including cache > contents, internal memory, registers. Which boards and SoCs need it? This is a defconfig for all platforms, not for Qualcomm only. > Best regards, Krzysztof
On 2023/10/23 17:32, Krzysztof Kozlowski wrote: > On 23/10/2023 11:20, Zhenhua Huang wrote: >> Enable Qcom Memory Dump driver to allow storing debugging > > s/Qcom/Qualcomm/ Thanks. > >> information after crash by firmware, including cache >> contents, internal memory, registers. > > Which boards and SoCs need it? This is a defconfig for all platforms, > not for Qualcomm only. Currently I'm enabling it for sm8250, further will enable for other targets. Yes, it's a defconfig for all platforms, do you mean I can enable it other defconfig file, or? > >> > > > Best regards, > Krzysztof > Thanks, Zhenhua
On 23/10/2023 13:43, Zhenhua Huang wrote: > > > On 2023/10/23 17:32, Krzysztof Kozlowski wrote: >> On 23/10/2023 11:20, Zhenhua Huang wrote: >>> Enable Qcom Memory Dump driver to allow storing debugging >> >> s/Qcom/Qualcomm/ > > Thanks. > >> >>> information after crash by firmware, including cache >>> contents, internal memory, registers. >> >> Which boards and SoCs need it? This is a defconfig for all platforms, >> not for Qualcomm only. > > Currently I'm enabling it for sm8250, further will enable for other > targets. Yes, it's a defconfig for all platforms, do you mean I can > enable it other defconfig file, or? > I meant your commit msg should provide justification, e.g. which boards supported by this defconfig are using it. Best regards, Krzysztof
On 2023/10/23 19:47, Krzysztof Kozlowski wrote: > On 23/10/2023 13:43, Zhenhua Huang wrote: >> >> >> On 2023/10/23 17:32, Krzysztof Kozlowski wrote: >>> On 23/10/2023 11:20, Zhenhua Huang wrote: >>>> Enable Qcom Memory Dump driver to allow storing debugging >>> >>> s/Qcom/Qualcomm/ >> >> Thanks. >> >>> >>>> information after crash by firmware, including cache >>>> contents, internal memory, registers. >>> >>> Which boards and SoCs need it? This is a defconfig for all platforms, >>> not for Qualcomm only. >> >> Currently I'm enabling it for sm8250, further will enable for other >> targets. Yes, it's a defconfig for all platforms, do you mean I can >> enable it other defconfig file, or? >> > > I meant your commit msg should provide justification, e.g. which boards > supported by this defconfig are using it. Clear now, Thanks very much! Thanks, Zhenhua > > Best regards, > Krzysztof >
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 5315789..99a8c81 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -1301,6 +1301,7 @@ CONFIG_QCOM_COMMAND_DB=y CONFIG_QCOM_CPR=y CONFIG_QCOM_GENI_SE=y CONFIG_QCOM_LLCC=m +CONFIG_QCOM_MEMORY_DUMP=y CONFIG_QCOM_OCMEM=m CONFIG_QCOM_PMIC_GLINK=m CONFIG_QCOM_RMTFS_MEM=m
Enable Qcom Memory Dump driver to allow storing debugging information after crash by firmware, including cache contents, internal memory, registers. Signed-off-by: Zhenhua Huang <quic_zhenhuah@quicinc.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)