| Message ID | 20231021112711.660606-1-jiri@resnulli.us (mailing list archive) |
|---|---|
| Headers | show |
| Series | devlink: finish conversion to generated split_ops | expand |
On 10/21/2023 4:27 AM, Jiri Pirko wrote: > From: Jiri Pirko <jiri@nvidia.com> > > This patchset converts the remaining genetlink commands to generated > split_ops and removes the existing small_ops arrays entirely > alongside with shared netlink attribute policy. > > Patches #1-#6 are just small preparations and small fixes on multiple > places. Note that couple of patches contain the "Fixes" > tag but no need to put them into -net tree. > Patch #7 is a simple rename preparation > Patch #8 is the main one in this set and adds actual definitions of cmds > in to yaml file. > Patches #9-#10 finalize the change removing bits that are no longer in > use. > > --- Everything in this version looks good to me. Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > v2->v3: > - just small fix and rebase in patch #2 > v1->v2: > - see individual patches for changelog > - patch #3 is new > - patch "netlink: specs: devlink: fix reply command values" was removed > from the set and sent separately to -net > > Jiri Pirko (10): > genetlink: don't merge dumpit split op for different cmds into single > iter > tools: ynl-gen: introduce support for bitfield32 attribute type > tools: ynl-gen: render rsp_parse() helpers if cmd has only dump op > netlink: specs: devlink: remove reload-action from devlink-get cmd > reply > netlink: specs: devlink: make dont-validate single line > devlink: make devlink_flash_overwrite enum named one > devlink: rename netlink callback to be aligned with the generated ones > netlink: specs: devlink: add the remaining command to generate > complete split_ops > devlink: remove duplicated netlink callback prototypes > devlink: remove netlink small_ops > > Documentation/netlink/genetlink-legacy.yaml | 2 +- > Documentation/netlink/specs/devlink.yaml | 1604 +++++- > .../netlink/genetlink-legacy.rst | 2 +- > include/uapi/linux/devlink.h | 2 +- > net/devlink/dev.c | 10 +- > net/devlink/devl_internal.h | 64 - > net/devlink/dpipe.c | 14 +- > net/devlink/health.c | 24 +- > net/devlink/linecard.c | 3 +- > net/devlink/netlink.c | 328 +- > net/devlink/netlink_gen.c | 757 ++- > net/devlink/netlink_gen.h | 64 +- > net/devlink/param.c | 14 +- > net/devlink/port.c | 11 +- > net/devlink/rate.c | 6 +- > net/devlink/region.c | 8 +- > net/devlink/resource.c | 4 +- > net/devlink/sb.c | 17 +- > net/devlink/trap.c | 9 +- > net/netlink/genetlink.c | 3 +- > tools/net/ynl/generated/devlink-user.c | 5075 +++++++++++++++-- > tools/net/ynl/generated/devlink-user.h | 4213 ++++++++++++-- > tools/net/ynl/lib/ynl.c | 6 + > tools/net/ynl/lib/ynl.h | 1 + > tools/net/ynl/lib/ynl.py | 13 +- > tools/net/ynl/ynl-gen-c.py | 50 +- > 26 files changed, 10644 insertions(+), 1660 deletions(-) >
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sat, 21 Oct 2023 13:27:01 +0200 you wrote: > From: Jiri Pirko <jiri@nvidia.com> > > This patchset converts the remaining genetlink commands to generated > split_ops and removes the existing small_ops arrays entirely > alongside with shared netlink attribute policy. > > Patches #1-#6 are just small preparations and small fixes on multiple > places. Note that couple of patches contain the "Fixes" > tag but no need to put them into -net tree. > Patch #7 is a simple rename preparation > Patch #8 is the main one in this set and adds actual definitions of cmds > in to yaml file. > Patches #9-#10 finalize the change removing bits that are no longer in > use. > > [...] Here is the summary with links: - [net-next,v3,01/10] genetlink: don't merge dumpit split op for different cmds into single iter https://git.kernel.org/netdev/net-next/c/f862ed2d0bf0 - [net-next,v3,02/10] tools: ynl-gen: introduce support for bitfield32 attribute type https://git.kernel.org/netdev/net-next/c/4e2846fd6684 - [net-next,v3,03/10] tools: ynl-gen: render rsp_parse() helpers if cmd has only dump op https://git.kernel.org/netdev/net-next/c/2260d39cd01a - [net-next,v3,04/10] netlink: specs: devlink: remove reload-action from devlink-get cmd reply https://git.kernel.org/netdev/net-next/c/c48066b0cc2c - [net-next,v3,05/10] netlink: specs: devlink: make dont-validate single line https://git.kernel.org/netdev/net-next/c/6cc8ad97c101 - [net-next,v3,06/10] devlink: make devlink_flash_overwrite enum named one https://git.kernel.org/netdev/net-next/c/e3570f040836 - [net-next,v3,07/10] devlink: rename netlink callback to be aligned with the generated ones https://git.kernel.org/netdev/net-next/c/53590934ba95 - [net-next,v3,08/10] netlink: specs: devlink: add the remaining command to generate complete split_ops https://git.kernel.org/netdev/net-next/c/f2f9dd164db0 - [net-next,v3,09/10] devlink: remove duplicated netlink callback prototypes https://git.kernel.org/netdev/net-next/c/15c80e7a53d2 - [net-next,v3,10/10] devlink: remove netlink small_ops https://git.kernel.org/netdev/net-next/c/cebe7306073d You are awesome, thank you!
From: Jiri Pirko <jiri@nvidia.com> This patchset converts the remaining genetlink commands to generated split_ops and removes the existing small_ops arrays entirely alongside with shared netlink attribute policy. Patches #1-#6 are just small preparations and small fixes on multiple places. Note that couple of patches contain the "Fixes" tag but no need to put them into -net tree. Patch #7 is a simple rename preparation Patch #8 is the main one in this set and adds actual definitions of cmds in to yaml file. Patches #9-#10 finalize the change removing bits that are no longer in use. --- v2->v3: - just small fix and rebase in patch #2 v1->v2: - see individual patches for changelog - patch #3 is new - patch "netlink: specs: devlink: fix reply command values" was removed from the set and sent separately to -net Jiri Pirko (10): genetlink: don't merge dumpit split op for different cmds into single iter tools: ynl-gen: introduce support for bitfield32 attribute type tools: ynl-gen: render rsp_parse() helpers if cmd has only dump op netlink: specs: devlink: remove reload-action from devlink-get cmd reply netlink: specs: devlink: make dont-validate single line devlink: make devlink_flash_overwrite enum named one devlink: rename netlink callback to be aligned with the generated ones netlink: specs: devlink: add the remaining command to generate complete split_ops devlink: remove duplicated netlink callback prototypes devlink: remove netlink small_ops Documentation/netlink/genetlink-legacy.yaml | 2 +- Documentation/netlink/specs/devlink.yaml | 1604 +++++- .../netlink/genetlink-legacy.rst | 2 +- include/uapi/linux/devlink.h | 2 +- net/devlink/dev.c | 10 +- net/devlink/devl_internal.h | 64 - net/devlink/dpipe.c | 14 +- net/devlink/health.c | 24 +- net/devlink/linecard.c | 3 +- net/devlink/netlink.c | 328 +- net/devlink/netlink_gen.c | 757 ++- net/devlink/netlink_gen.h | 64 +- net/devlink/param.c | 14 +- net/devlink/port.c | 11 +- net/devlink/rate.c | 6 +- net/devlink/region.c | 8 +- net/devlink/resource.c | 4 +- net/devlink/sb.c | 17 +- net/devlink/trap.c | 9 +- net/netlink/genetlink.c | 3 +- tools/net/ynl/generated/devlink-user.c | 5075 +++++++++++++++-- tools/net/ynl/generated/devlink-user.h | 4213 ++++++++++++-- tools/net/ynl/lib/ynl.c | 6 + tools/net/ynl/lib/ynl.h | 1 + tools/net/ynl/lib/ynl.py | 13 +- tools/net/ynl/ynl-gen-c.py | 50 +- 26 files changed, 10644 insertions(+), 1660 deletions(-)