[v9,0/22] Refactoring Microchip PCIe driver and add StarFive PCIe

Message

Minda Chen Oct. 20, 2023, 10:43 a.m. UTC

This patchset final purpose is add PCIe driver for StarFive JH7110 SoC.
JH7110 using PLDA XpressRICH PCIe IP. Microchip PolarFire Using the
same IP and have commit their codes, which are mixed with PLDA
controller codes and Microchip platform codes.

For re-use the PLDA controller codes, I request refactoring microchip
codes, move PLDA common codes to PLDA files.
Desigware and Cadence is good example for refactoring codes.

----------------------------------------------------------
The refactoring patches total number is 16,(patch 1-16)
which do NOT contain changing logic of codes.

These patches just contain three type basic operations.
(rename, modify codes to support starfive platform, and moving to common file)
If these patched are all be reviewed. They can be accepted first.

Refactoring patches can be devided to different groups
1. (patch 1- 3 is the prepare work of refactoring)
patch1 is move PLDA XpressRICH PCIe host common properties dt-binding
       docs from microchip,pcie-host.yaml
patch2 is move PolarFire codes to PLDA directory.
patch3 is move PLDA IP register macros to plda-pcie.h

2. (patch4 - 6 is processing and re-use PCIe host instance)
patch4 is add bridge_addr field to PCIe host instance.
patch5 is rename data structure in microchip codes.
patch6 is moving two data structures to head file

3. (patch 7 - 9 are for re-use two PCIe setup function)
patch7 is rename two setup functions in microchip codes, prepare to move
to common file.
patch8 is change the arguments of plda_pcie_setup_iomems()
patch9 is move the two setup functions to common file pcie-plda-host.c

4.(patch 11 - 16 are for re-use interupt processing codes)
patch11 is rename the IRQ related functions, prepare to move to
pcie-plda-host.c
patch 12 - 15 is modify the interrupt event codes, preparing for support starfive
and microchip two platforms.
patch16 is move IRQ related functions to pcie-plda-host.c

------------------------------------------------------------
The remainder patches (patch 17 -20) are not refactoring patch.
They are for adding StarFive codes and dont modify the microchip's
codes.

patch17 is Add PLDA event interrupt codes and host init/deinit functions.
patch18 is add StarFive JH7110 PCIe dt-binding doc.
patch19 is add StarFive JH7110 Soc PCIe codes.
patch20 is Starfive dts config

This patchset is base on v6.6-rc6

previous version:
v3:https://patchwork.kernel.org/project/linux-pci/cover/[e-mail]/
v4:https://patchwork.kernel.org/project/linux-pci/cover/[e-mail]/
v5:https://patchwork.kernel.org/project/linux-pci/cover/[e-mail]/
v6:https://patchwork.kernel.org/project/linux-pci/cover/[e-mail]/
v7:https://patchwork.kernel.org/project/linux-pci/cover/[e-mail]/
v8:https://patchwork.kernel.org/project/linux-pci/cover/[e-mail]/

change:
  v9:
   v8 patch 10 squash to v9 patch 12, v8 patch 18 squash to v9 patch 16.
   patch 4 - 16: Add new review tags and add more accurate commit messages.
   patch 17: move the plda_pcie_host_init/deinit from patch 19. Make
plda driver become to whole driver.

  v8:
    The patch description in cover-letter has been changed.

    v7 patch 4 split to v8 patch 4 - 6.
        (It is patches about re-use pcie host data structure, new patches just contain one
	function modification. It is more reguluar and easier to review).

    patch 7- 9: modify the commit messages and add reason of
		modifcation.
    patch10- 16 :
             Add review tag and add more commit messages to declear the
	     reason of modifying the codes.
    patch17: plda_handle_events() using bit mask macro. The function are
	     easier to read.

  v7:
    patch17: fix the build warning.
    patch19: Some format changes (Emil's comment)
    patch20: change the pcie node sequences by alphabetical
             delete the "interupt-parent" in pcie node.

  v6:
    v5 patch 4 split to patch 4 -9. New patches just contain one
function modification. It is more reguluar.
    patch 9: Just move the two setup functions only
    patch 19 : draw a graph of PLDA local register, make it easier to
review the codes.
    v5 patch 7 split to patch 10- 16. Each patch just contain one
function modification. It is more regular.
    patch 10: rename IRQ related functions.
    patch 11 - 15 : modify the events codes, total five patch.
    patch 16: move IRQ related functions to pcie-plda-host.c
    patch 19- 20 using "linux,pci-domain" dts setting.

  v5:
    patch 10 -16:
    	- Some variables names changed (evt->event).
    	- plda_handle_event() using a unify callback function to get events
num.
	- Add plda_event_ops data structure.
    patch 19:
	Add plda_event_ops instances.

  v4:
    patch 3:
    	Copy the interrupt events macros to pcie-plda-host.c
    patch 14:
    	get_events() change in patch 7. Patch 8 is just move the codes.
    other change:
	All the functions in commit message add (). 
  v3:
    patch 2- 17:
      - splite refactoring patches to multiple patch.
      - rename plda_pcie to plda_pcie_rp. Maybe other vendor will
        upstream PLDA ep codes.
    patch 18:
      - Remove the redundant reference.
      - move the offset value to codes in starfive,stg-syscon
      - change reset-gpio to prest-gpio.
    patch 19:
      - Add 100ms delay after preset for PCIe 6.0 spec.
      - stg-syscon related modification.
    patch 20:
      - Add dts configure.


Minda Chen (20):
  dt-bindings: PCI: Add PLDA XpressRICH PCIe host common properties
  PCI: microchip: Move pcie-microchip-host.c to plda directory
  PCI: microchip: Move PLDA IP register macros to pcie-plda.h
  PCI: microchip: Add bridge_addr field to struct mc_pcie
  PCI: microchip: Rename two PCIe data structures
  PCI: microchip: Move PCIe host data structure to plda-pcie.h
  PCI: microchip: Rename two setup functions
  PCI: microchip: Change the argument of plda_pcie_setup_iomems()
  PCI: microchip: Move setup functions to pcie-plda-host.c
  PCI: microchip: Rename interrupt related functions
  PCI: microchip: Add num_events field to struct plda_pcie_rp
  PCI: microchip: Add request_event_irq() callback function
  PCI: microchip: Add INTx and MSI event num to struct plda_event
  PCI: microchip: Add get_events() callback function
  PCI: microchip: Add event IRQ domain ops to struct plda_event
  PCI: microchip: Move IRQ functions to pcie-plda-host.c
  PCI: plda: Add event interrupt codes and host init/deinit functions
  dt-bindings: PCI: Add StarFive JH7110 PCIe controller
  PCI: starfive: Add JH7110 PCIe controller
  riscv: dts: starfive: add PCIe dts configuration for JH7110

 .../bindings/pci/microchip,pcie-host.yaml     |  55 +-
 .../pci/plda,xpressrich3-axi-common.yaml      |  75 ++
 .../bindings/pci/starfive,jh7110-pcie.yaml    | 120 ++++
 MAINTAINERS                                   |  19 +-
 .../jh7110-starfive-visionfive-2.dtsi         |  64 ++
 arch/riscv/boot/dts/starfive/jh7110.dtsi      |  86 +++
 drivers/pci/controller/Kconfig                |   9 +-
 drivers/pci/controller/Makefile               |   2 +-
 drivers/pci/controller/plda/Kconfig           |  30 +
 drivers/pci/controller/plda/Makefile          |   4 +
 .../{ => plda}/pcie-microchip-host.c          | 602 ++--------------
 drivers/pci/controller/plda/pcie-plda-host.c  | 656 ++++++++++++++++++
 drivers/pci/controller/plda/pcie-plda.h       | 268 +++++++
 drivers/pci/controller/plda/pcie-starfive.c   | 448 ++++++++++++
 14 files changed, 1834 insertions(+), 604 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pci/plda,xpressrich3-axi-common.yaml
 create mode 100644 Documentation/devicetree/bindings/pci/starfive,jh7110-pcie.yaml
 create mode 100644 drivers/pci/controller/plda/Kconfig
 create mode 100644 drivers/pci/controller/plda/Makefile
 rename drivers/pci/controller/{ => plda}/pcie-microchip-host.c (54%)
 create mode 100644 drivers/pci/controller/plda/pcie-plda-host.c
 create mode 100644 drivers/pci/controller/plda/pcie-plda.h
 create mode 100644 drivers/pci/controller/plda/pcie-starfive.c


base-commit: 58720809f52779dc0f08e53e54b014209d13eebb

Comments

Krzysztof Kozlowski Oct. 20, 2023, 11:04 a.m. UTC | #1

On 20/10/2023 12:43, Minda Chen wrote:
> Add PLDA XpressRICH PCIe host common properties dt-binding doc.
> Microchip PolarFire PCIe host using PLDA IP.
> Move common properties from Microchip PolarFire PCIe host
> to PLDA files.
> 
> Signed-off-by: Minda Chen <[e-mail]>
> Reviewed-by: Hal Feng <[e-mail]>
> Reviewed-by: Conor Dooley <[e-mail]>
> Reviewed-by: Rob Herring <[e-mail]>
> ---
>  .../bindings/pci/microchip,pcie-host.yaml     | 55 +-------------
>  .../pci/plda,xpressrich3-axi-common.yaml      | 75 +++++++++++++++++++

Where was this patch reviewed?

Best regards,
Krzysztof

Minda Chen Oct. 23, 2023, 1:04 a.m. UTC | #2

On 2023/10/20 19:04, Krzysztof Kozlowski wrote:
> On 20/10/2023 12:43, Minda Chen wrote:
>> Add PLDA XpressRICH PCIe host common properties dt-binding doc.
>> Microchip PolarFire PCIe host using PLDA IP.
>> Move common properties from Microchip PolarFire PCIe host
>> to PLDA files.
>> 
>> Signed-off-by: Minda Chen <[e-mail]>
>> Reviewed-by: Hal Feng <[e-mail]>
>> Reviewed-by: Conor Dooley <[e-mail]>
>> Reviewed-by: Rob Herring <[e-mail]>
>> ---
>>  .../bindings/pci/microchip,pcie-host.yaml     | 55 +-------------
>>  .../pci/plda,xpressrich3-axi-common.yaml      | 75 +++++++++++++++++++
> 
> Where was this patch reviewed?
> 
> Best regards,
> Krzysztof
> 
This Conor's review tag. v2 : https://patchwork.kernel.org/project/linux-pci/patch/[e-mail]/
This is Rob's review tag v3: https://patchwork.kernel.org/project/linux-pci/patch/[e-mail]/

John Clark Oct. 24, 2023, 3:09 a.m. UTC | #3

> On 2023/10/20 19:04, Krzysztof Kozlowski wrote:
>> On 20/10/2023 12:43, Minda Chen wrote:
>>> Add PLDA XpressRICH PCIe host common properties dt-binding doc.
>>> Microchip PolarFire PCIe host using PLDA IP.
>>> Move common properties from Microchip PolarFire PCIe host
>>> to PLDA files.
>>>
>>> Signed-off-by: Minda Chen <[e-mail]>
>>> Reviewed-by: Hal Feng <[e-mail]>
>>> Reviewed-by: Conor Dooley <[e-mail]>
>>> Reviewed-by: Rob Herring <[e-mail]>
>>> ---
>>>   .../bindings/pci/microchip,pcie-host.yaml     | 55 +-------------
>>>   .../pci/plda,xpressrich3-axi-common.yaml      | 75 +++++++++++++++++++
>> Where was this patch reviewed?
>>
>> Best regards,
>> Krzysztof
>>
> This Conor's review tag. v2 : https://patchwork.kernel.org/project/linux-pci/patch/[e-mail]/
> This is Rob's review tag v3: https://patchwork.kernel.org/project/linux-pci/patch/[e-mail]/

Tested-by: John Clark <[e-mail]>: 
https://github.com/inindev/visionfive2/tree/main/kernel/patches

Conor Dooley Oct. 25, 2023, 10:28 a.m. UTC | #4

Hi John,

On Mon, Oct 23, 2023 at 11:09:50PM -0400, John Clark wrote:
> > On 2023/10/20 19:04, Krzysztof Kozlowski wrote:
> > > On 20/10/2023 12:43, Minda Chen wrote:
> > > > Add PLDA XpressRICH PCIe host common properties dt-binding doc.
> > > > Microchip PolarFire PCIe host using PLDA IP.
> > > > Move common properties from Microchip PolarFire PCIe host
> > > > to PLDA files.
> > > > 
> > > > Signed-off-by: Minda Chen <[e-mail]>
> > > > Reviewed-by: Hal Feng <[e-mail]>
> > > > Reviewed-by: Conor Dooley <[e-mail]>
> > > > Reviewed-by: Rob Herring <[e-mail]>
> > > > ---
> > > >   .../bindings/pci/microchip,pcie-host.yaml     | 55 +-------------
> > > >   .../pci/plda,xpressrich3-axi-common.yaml      | 75 +++++++++++++++++++
> > > Where was this patch reviewed?
> > > 
> > > Best regards,
> > > Krzysztof
> > > 
> > This Conor's review tag. v2 : https://patchwork.kernel.org/project/linux-pci/patch/[e-mail]/
> > This is Rob's review tag v3: https://patchwork.kernel.org/project/linux-pci/patch/[e-mail]/
> 
> Tested-by: John Clark <[e-mail]>:
> https://github.com/inindev/visionfive2/tree/main/kernel/patches

I suspect you don't mean that you tested this individual dt-binding, but
rather that you tested the whole series. If so, you should probably
provide this tested-by against the cover-letter instead of this bindings
patch.

Cheers,
Conor.

Krzysztof Kozlowski Oct. 25, 2023, 10:41 a.m. UTC | #5

On 25/10/2023 12:28, Conor Dooley wrote:
> Hi John,
> 
> On Mon, Oct 23, 2023 at 11:09:50PM -0400, John Clark wrote:
>>> On 2023/10/20 19:04, Krzysztof Kozlowski wrote:
>>>> On 20/10/2023 12:43, Minda Chen wrote:
>>>>> Add PLDA XpressRICH PCIe host common properties dt-binding doc.
>>>>> Microchip PolarFire PCIe host using PLDA IP.
>>>>> Move common properties from Microchip PolarFire PCIe host
>>>>> to PLDA files.
>>>>>
>>>>> Signed-off-by: Minda Chen <[e-mail]>
>>>>> Reviewed-by: Hal Feng <[e-mail]>
>>>>> Reviewed-by: Conor Dooley <[e-mail]>
>>>>> Reviewed-by: Rob Herring <[e-mail]>
>>>>> ---
>>>>>   .../bindings/pci/microchip,pcie-host.yaml     | 55 +-------------
>>>>>   .../pci/plda,xpressrich3-axi-common.yaml      | 75 +++++++++++++++++++
>>>> Where was this patch reviewed?
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>>
>>> This Conor's review tag. v2 : https://patchwork.kernel.org/project/linux-pci/patch/[e-mail]/
>>> This is Rob's review tag v3: https://patchwork.kernel.org/project/linux-pci/patch/[e-mail]/
>>
>> Tested-by: John Clark <[e-mail]>:
>> https://github.com/inindev/visionfive2/tree/main/kernel/patches
> 
> I suspect you don't mean that you tested this individual dt-binding, but
> rather that you tested the whole series. If so, you should probably
> provide this tested-by against the cover-letter instead of this bindings
> patch.

Yeah, otherwise I would like to hear how do you test bindings (other
than dt_binding_check which is something similar to testing as compiling
code).

Best regards,
Krzysztof

John Clark Oct. 25, 2023, 1:16 p.m. UTC | #6

That is correct, I tested the entire series against Linux 6.6-rc7 and 
confirmed that pcie/nvme/usb work on the VisionFive2 device. I was 
unable to test the Microchip side of the equation. I will be more clear 
as to what I verified if I comment in the future.

John Clark


On 10/25/23 6:41 AM, Krzysztof Kozlowski wrote:
> On 25/10/2023 12:28, Conor Dooley wrote:
>> Hi John,
>>
>> On Mon, Oct 23, 2023 at 11:09:50PM -0400, John Clark wrote:
>>>> On 2023/10/20 19:04, Krzysztof Kozlowski wrote:
>>>>> On 20/10/2023 12:43, Minda Chen wrote:
>>>>>> Add PLDA XpressRICH PCIe host common properties dt-binding doc.
>>>>>> Microchip PolarFire PCIe host using PLDA IP.
>>>>>> Move common properties from Microchip PolarFire PCIe host
>>>>>> to PLDA files.
>>>>>>
>>>>>> Signed-off-by: Minda Chen <[e-mail]>
>>>>>> Reviewed-by: Hal Feng <[e-mail]>
>>>>>> Reviewed-by: Conor Dooley <[e-mail]>
>>>>>> Reviewed-by: Rob Herring <[e-mail]>
>>>>>> ---
>>>>>>    .../bindings/pci/microchip,pcie-host.yaml     | 55 +-------------
>>>>>>    .../pci/plda,xpressrich3-axi-common.yaml      | 75 +++++++++++++++++++
>>>>> Where was this patch reviewed?
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>> This Conor's review tag. v2 : https://patchwork.kernel.org/project/linux-pci/patch/[e-mail]/
>>>> This is Rob's review tag v3: https://patchwork.kernel.org/project/linux-pci/patch/[e-mail]/
>>> Tested-by: John Clark <[e-mail]>:
>>> https://github.com/inindev/visionfive2/tree/main/kernel/patches
>> I suspect you don't mean that you tested this individual dt-binding, but
>> rather that you tested the whole series. If so, you should probably
>> provide this tested-by against the cover-letter instead of this bindings
>> patch.
> Yeah, otherwise I would like to hear how do you test bindings (other
> than dt_binding_check which is something similar to testing as compiling
> code).
>
> Best regards,
> Krzysztof
>