| Message ID | 20231024000724.57714-4-hsinyi@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add a few mt8183 follower boards. | expand |
On Mon, Oct 23, 2023 at 05:02:26PM -0700, Hsin-Yi Wang wrote: > Add makomo sku0 and sku1 which uses different audio codec. > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > Documentation/devicetree/bindings/arm/mediatek.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index fe8c488a3207..b131e0bdbf01 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -250,6 +250,18 @@ properties: > - google,kodama-sku32 > - const: google,kodama > - const: mediatek,mt8183 > + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2) > + items: > + - const: google,makomo-rev4-sku0 > + - const: google,makomo-rev5-sku0 With these bindings, how does one describe a makomo-rev5-sku0? What you have here is only suitable for describing the makomo-rev4-sku0. Cheers, Conor. > + - const: google,makomo > + - const: mediatek,mt8183 > + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2) > + items: > + - const: google,makomo-rev4-sku1 > + - const: google,makomo-rev5-sku1 > + - const: google,makomo > + - const: mediatek,mt8183 > - description: Google Willow (Acer Chromebook 311 C722/C722T) > items: > - enum: > -- > 2.42.0.758.gaed0368e0e-goog >
On Tue, Oct 24, 2023 at 8:17 AM Conor Dooley <conor@kernel.org> wrote: > > On Mon, Oct 23, 2023 at 05:02:26PM -0700, Hsin-Yi Wang wrote: > > Add makomo sku0 and sku1 which uses different audio codec. > > > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > > --- > > Documentation/devicetree/bindings/arm/mediatek.yaml | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > > index fe8c488a3207..b131e0bdbf01 100644 > > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > > @@ -250,6 +250,18 @@ properties: > > - google,kodama-sku32 > > - const: google,kodama > > - const: mediatek,mt8183 > > + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2) > > + items: > > + - const: google,makomo-rev4-sku0 > > + - const: google,makomo-rev5-sku0 > > With these bindings, how does one describe a makomo-rev5-sku0? > What you have here is only suitable for describing the makomo-rev4-sku0. > makomo-rev5-sku0 and makomo-rev4-sku0 uses the same dts: compatible = "google,makomo-rev4-sku0", "google,makomo-rev5-sku0", "google,makomo", "mediatek,mt8183"; In this case, can bindings be listed like that? > Cheers, > Conor. > > > + - const: google,makomo > > + - const: mediatek,mt8183 > > + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2) > > + items: > > + - const: google,makomo-rev4-sku1 > > + - const: google,makomo-rev5-sku1 > > + - const: google,makomo > > + - const: mediatek,mt8183 > > - description: Google Willow (Acer Chromebook 311 C722/C722T) > > items: > > - enum: > > -- > > 2.42.0.758.gaed0368e0e-goog > >
On Tue, Oct 24, 2023 at 11:22:00AM -0700, Hsin-Yi Wang wrote: > On Tue, Oct 24, 2023 at 8:17 AM Conor Dooley <conor@kernel.org> wrote: > > > > On Mon, Oct 23, 2023 at 05:02:26PM -0700, Hsin-Yi Wang wrote: > > > Add makomo sku0 and sku1 which uses different audio codec. > > > > > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > > > --- > > > Documentation/devicetree/bindings/arm/mediatek.yaml | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > > > index fe8c488a3207..b131e0bdbf01 100644 > > > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > > > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > > > @@ -250,6 +250,18 @@ properties: > > > - google,kodama-sku32 > > > - const: google,kodama > > > - const: mediatek,mt8183 > > > + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2) > > > + items: > > > + - const: google,makomo-rev4-sku0 > > > + - const: google,makomo-rev5-sku0 > > > > With these bindings, how does one describe a makomo-rev5-sku0? > > What you have here is only suitable for describing the makomo-rev4-sku0. > > > makomo-rev5-sku0 and makomo-rev4-sku0 uses the same dts: > > compatible = "google,makomo-rev4-sku0", "google,makomo-rev5-sku0", > "google,makomo", "mediatek,mt8183"; > > In this case, can bindings be listed like that? On a rev5-sku0, the first compatible should be the most specific one, which would mean: compatible = "google,makomo-rev5-sku0", "google,makomo", "mediatek,mt8183"; I said the same on other google laptop bindings before, but I'm not really happy with these compatible configurations, that seem conjured up to suit your firmware. It'd make far more sense to me to have a setup that permitted: compatible = "google,makomo-sku0-rev5", "google,makomo-sku0", "google,makomo", "mediatek,mt8183"; and compatible = "google,makomo-sku0-rev4", "google,makomo-sku0", "google,makomo", "mediatek,mt8183"; Cheers, Conor. > > > + - const: google,makomo > > > + - const: mediatek,mt8183 > > > + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2) > > > + items: > > > + - const: google,makomo-rev4-sku1 > > > + - const: google,makomo-rev5-sku1 > > > + - const: google,makomo > > > + - const: mediatek,mt8183 > > > - description: Google Willow (Acer Chromebook 311 C722/C722T) > > > items: > > > - enum: > > > -- > > > 2.42.0.758.gaed0368e0e-goog > > >
On 24/10/2023 20:22, Hsin-Yi Wang wrote: > On Tue, Oct 24, 2023 at 8:17 AM Conor Dooley <conor@kernel.org> wrote: >> >> On Mon, Oct 23, 2023 at 05:02:26PM -0700, Hsin-Yi Wang wrote: >>> Add makomo sku0 and sku1 which uses different audio codec. >>> >>> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> >>> --- >>> Documentation/devicetree/bindings/arm/mediatek.yaml | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml >>> index fe8c488a3207..b131e0bdbf01 100644 >>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml >>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml >>> @@ -250,6 +250,18 @@ properties: >>> - google,kodama-sku32 >>> - const: google,kodama >>> - const: mediatek,mt8183 >>> + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2) >>> + items: >>> + - const: google,makomo-rev4-sku0 >>> + - const: google,makomo-rev5-sku0 >> >> With these bindings, how does one describe a makomo-rev5-sku0? >> What you have here is only suitable for describing the makomo-rev4-sku0. >> > makomo-rev5-sku0 and makomo-rev4-sku0 uses the same dts: > > compatible = "google,makomo-rev4-sku0", "google,makomo-rev5-sku0", > "google,makomo", "mediatek,mt8183"; > > In this case, can bindings be listed like that? If they use the same DTS, then I would expect rev5 (as newer model, more specific) followed by rev4 (older). Best regards, Krzysztof
On Wed, Oct 25, 2023 at 7:49 AM Conor Dooley <conor@kernel.org> wrote: > > On Tue, Oct 24, 2023 at 11:22:00AM -0700, Hsin-Yi Wang wrote: > > On Tue, Oct 24, 2023 at 8:17 AM Conor Dooley <conor@kernel.org> wrote: > > > > > > On Mon, Oct 23, 2023 at 05:02:26PM -0700, Hsin-Yi Wang wrote: > > > > Add makomo sku0 and sku1 which uses different audio codec. > > > > > > > > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > > > > --- > > > > Documentation/devicetree/bindings/arm/mediatek.yaml | 12 ++++++++++++ > > > > 1 file changed, 12 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > > > > index fe8c488a3207..b131e0bdbf01 100644 > > > > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > > > > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > > > > @@ -250,6 +250,18 @@ properties: > > > > - google,kodama-sku32 > > > > - const: google,kodama > > > > - const: mediatek,mt8183 > > > > + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2) > > > > + items: > > > > + - const: google,makomo-rev4-sku0 > > > > + - const: google,makomo-rev5-sku0 > > > > > > With these bindings, how does one describe a makomo-rev5-sku0? > > > What you have here is only suitable for describing the makomo-rev4-sku0. > > > > > makomo-rev5-sku0 and makomo-rev4-sku0 uses the same dts: > > > > compatible = "google,makomo-rev4-sku0", "google,makomo-rev5-sku0", > > "google,makomo", "mediatek,mt8183"; > > > > In this case, can bindings be listed like that? > > On a rev5-sku0, the first compatible should be the most specific one, > which would mean: > > compatible = "google,makomo-rev5-sku0", "google,makomo", "mediatek,mt8183"; > > I said the same on other google laptop bindings before, but I'm not > really happy with these compatible configurations, that seem conjured up > to suit your firmware. It'd make far more sense to me to have a setup > that permitted: > compatible = "google,makomo-sku0-rev5", "google,makomo-sku0", "google,makomo", "mediatek,mt8183"; > and > compatible = "google,makomo-sku0-rev4", "google,makomo-sku0", "google,makomo", "mediatek,mt8183"; > The actual compatible is like: google,makomo-rev4-sku1 google,makomo-sku1 google,makomo-rev4 google,makomo So I think I can remove the rev here, and just let them match with google,makomo-skuX, since rev4/rev5 share the same dts. > Cheers, > Conor. > > > > > + - const: google,makomo > > > > + - const: mediatek,mt8183 > > > > + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2) > > > > + items: > > > > + - const: google,makomo-rev4-sku1 > > > > + - const: google,makomo-rev5-sku1 > > > > + - const: google,makomo > > > > + - const: mediatek,mt8183 > > > > - description: Google Willow (Acer Chromebook 311 C722/C722T) > > > > items: > > > > - enum: > > > > -- > > > > 2.42.0.758.gaed0368e0e-goog > > > >
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index fe8c488a3207..b131e0bdbf01 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -250,6 +250,18 @@ properties: - google,kodama-sku32 - const: google,kodama - const: mediatek,mt8183 + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2) + items: + - const: google,makomo-rev4-sku0 + - const: google,makomo-rev5-sku0 + - const: google,makomo + - const: mediatek,mt8183 + - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2) + items: + - const: google,makomo-rev4-sku1 + - const: google,makomo-rev5-sku1 + - const: google,makomo + - const: mediatek,mt8183 - description: Google Willow (Acer Chromebook 311 C722/C722T) items: - enum:
Add makomo sku0 and sku1 which uses different audio codec. Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> --- Documentation/devicetree/bindings/arm/mediatek.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)