mbox series

[net-next,0/9] Intel Wired LAN Driver Updates for 2023-10-23 (iavf)

Message ID 20231023230826.531858-1-jacob.e.keller@intel.com (mailing list archive)
Headers show
Series Intel Wired LAN Driver Updates for 2023-10-23 (iavf) | expand

Message

Jacob Keller Oct. 23, 2023, 11:08 p.m. UTC
This series includes iAVF driver cleanups from Michal Schmidt.

Michal removes and updates stale comments, fixes some locking anti-patterns,
improves handling of resets when the PF is slow, avoids unnecessary
duplication of netdev state, refactors away some duplicate code, and finally
removes the never-actually-used client interface.

Michal Schmidt (9):
  iavf: fix comments about old bit locks
  iavf: simplify mutex_trylock+sleep loops
  iavf: in iavf_down, don't queue watchdog_task if comms failed
  iavf: in iavf_down, disable queues when removing the driver
  iavf: fix the waiting time for initial reset
  iavf: rely on netdev's own registered state
  iavf: use unregister_netdev
  iavf: add a common function for undoing the interrupt scheme
  iavf: delete the iavf client interface

 drivers/net/ethernet/intel/iavf/Makefile      |   2 +-
 drivers/net/ethernet/intel/iavf/iavf.h        |  28 -
 drivers/net/ethernet/intel/iavf/iavf_client.c | 578 ------------------
 drivers/net/ethernet/intel/iavf/iavf_client.h | 169 -----
 drivers/net/ethernet/intel/iavf/iavf_main.c   | 139 +----
 .../net/ethernet/intel/iavf/iavf_virtchnl.c   |  14 -
 6 files changed, 29 insertions(+), 901 deletions(-)
 delete mode 100644 drivers/net/ethernet/intel/iavf/iavf_client.c
 delete mode 100644 drivers/net/ethernet/intel/iavf/iavf_client.h


base-commit: d6e48462e88fe7efc78b455ecde5b0ca43ec50b7

Comments

Jacob Keller Oct. 27, 2023, 4:58 p.m. UTC | #1
On 10/23/2023 4:08 PM, Jacob Keller wrote:
> This series includes iAVF driver cleanups from Michal Schmidt.
> 
> Michal removes and updates stale comments, fixes some locking anti-patterns,
> improves handling of resets when the PF is slow, avoids unnecessary
> duplication of netdev state, refactors away some duplicate code, and finally
> removes the never-actually-used client interface.
> 
> Michal Schmidt (9):
>   iavf: fix comments about old bit locks
>   iavf: simplify mutex_trylock+sleep loops
>   iavf: in iavf_down, don't queue watchdog_task if comms failed
>   iavf: in iavf_down, disable queues when removing the driver
>   iavf: fix the waiting time for initial reset
>   iavf: rely on netdev's own registered state
>   iavf: use unregister_netdev
>   iavf: add a common function for undoing the interrupt scheme
>   iavf: delete the iavf client interface
> 
>  drivers/net/ethernet/intel/iavf/Makefile      |   2 +-
>  drivers/net/ethernet/intel/iavf/iavf.h        |  28 -
>  drivers/net/ethernet/intel/iavf/iavf_client.c | 578 ------------------
>  drivers/net/ethernet/intel/iavf/iavf_client.h | 169 -----
>  drivers/net/ethernet/intel/iavf/iavf_main.c   | 139 +----
>  .../net/ethernet/intel/iavf/iavf_virtchnl.c   |  14 -
>  6 files changed, 29 insertions(+), 901 deletions(-)
>  delete mode 100644 drivers/net/ethernet/intel/iavf/iavf_client.c
>  delete mode 100644 drivers/net/ethernet/intel/iavf/iavf_client.h
> 
> 
> base-commit: d6e48462e88fe7efc78b455ecde5b0ca43ec50b7


Since we pulled the fix out into net, I assume I should resend a rebased
v2 of this series?

Thanks,
Jake
Jakub Kicinski Oct. 27, 2023, 5:41 p.m. UTC | #2
On Fri, 27 Oct 2023 09:58:38 -0700 Jacob Keller wrote:
> Since we pulled the fix out into net, I assume I should resend a rebased
> v2 of this series?

Yes, please