| Message ID | 20231030082858.30321-4-itoral@igalia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | V3D module changes for Pi5 | expand |
Hi Iago, Am 30.10.23 um 09:28 schrieb Iago Toral Quiroga: > BCM2712, Raspberry Pi 5's SoC, contains a V3D core. So add its specific > compatible to the bindings. > > v2: new, requested by Stefan Wahren. Thanks for sending this but the line above belongs below --- since it's not relevant after the patch has been applied. > > Signed-off-by: Iago Toral Quiroga <itoral@igalia.com> Unfortunately this patch will be ignored because the relevant devicetree people are missing to give their Ack. Please use scripts/get_maintainers.pl Best regards > --- > Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml > index dae55b8a267b..dc078ceeca9a 100644 > --- a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml > +++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml > @@ -17,6 +17,7 @@ properties: > compatible: > enum: > - brcm,2711-v3d > + - brcm,2712-v3d > - brcm,7268-v3d > - brcm,7278-v3d >
El lun, 30-10-2023 a las 10:57 +0100, Stefan Wahren escribió: > Hi Iago, > > Am 30.10.23 um 09:28 schrieb Iago Toral Quiroga: > > BCM2712, Raspberry Pi 5's SoC, contains a V3D core. So add its > > specific > > compatible to the bindings. > > > > v2: new, requested by Stefan Wahren. > Thanks for sending this but the line above belongs below --- since > it's > not relevant after the patch has been applied. > > > > Signed-off-by: Iago Toral Quiroga <itoral@igalia.com> > Unfortunately this patch will be ignored because the relevant > devicetree > people are missing to give their Ack. > > Please use scripts/get_maintainers.pl > Sorry about that, my bad, should I resend the patch (as part of a v3) or is it enough to add the relevant maintainers in a reply to the original v2 patch? Iago > Best regards > > --- > > Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm- > > v3d.yaml b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml > > index dae55b8a267b..dc078ceeca9a 100644 > > --- a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml > > +++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml > > @@ -17,6 +17,7 @@ properties: > > compatible: > > enum: > > - brcm,2711-v3d > > + - brcm,2712-v3d > > - brcm,7268-v3d > > - brcm,7278-v3d > > > >
Hi Iago, Am 30.10.23 um 11:18 schrieb Iago Toral: > El lun, 30-10-2023 a las 10:57 +0100, Stefan Wahren escribió: >> Hi Iago, >> >> Am 30.10.23 um 09:28 schrieb Iago Toral Quiroga: >>> BCM2712, Raspberry Pi 5's SoC, contains a V3D core. So add its >>> specific >>> compatible to the bindings. >>> >>> v2: new, requested by Stefan Wahren. >> Thanks for sending this but the line above belongs below --- since >> it's >> not relevant after the patch has been applied. >>> Signed-off-by: Iago Toral Quiroga <itoral@igalia.com> >> Unfortunately this patch will be ignored because the relevant >> devicetree >> people are missing to give their Ack. >> >> Please use scripts/get_maintainers.pl >> > Sorry about that, my bad, should I resend the patch (as part of a v3) > or is it enough to add the relevant maintainers in a reply to the > original v2 patch? since the merge window for 6.7 is open, please resent as part of v3. > > Iago > >> Best regards >>> --- >>> Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm- >>> v3d.yaml b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml >>> index dae55b8a267b..dc078ceeca9a 100644 >>> --- a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml >>> +++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml >>> @@ -17,6 +17,7 @@ properties: >>> compatible: >>> enum: >>> - brcm,2711-v3d >>> + - brcm,2712-v3d >>> - brcm,7268-v3d >>> - brcm,7278-v3d >>> >>
On 30/10/2023 09:28, Iago Toral Quiroga wrote: > BCM2712, Raspberry Pi 5's SoC, contains a V3D core. So add its specific > compatible to the bindings. > > v2: new, requested by Stefan Wahren. > > Signed-off-by: Iago Toral Quiroga <itoral@igalia.com> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml index dae55b8a267b..dc078ceeca9a 100644 --- a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml +++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml @@ -17,6 +17,7 @@ properties: compatible: enum: - brcm,2711-v3d + - brcm,2712-v3d - brcm,7268-v3d - brcm,7278-v3d
BCM2712, Raspberry Pi 5's SoC, contains a V3D core. So add its specific compatible to the bindings. v2: new, requested by Stefan Wahren. Signed-off-by: Iago Toral Quiroga <itoral@igalia.com> --- Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 + 1 file changed, 1 insertion(+)