| Message ID | 20231105154940.97688-2-wahrenst@gmx.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: dts: bcm2711-rpi-400: Fix delete-node of led_act | expand |
On Sun, Nov 05, 2023 at 04:49:39PM +0100, Stefan Wahren wrote: > In case leds-gpio fails to get the GPIO from the DT (e.g. the GPIO is > already requested) the driver doesn't provide any helpful error log: > > leds-gpio: probe of leds failed with error -16 > > So add a new error log in case devm_fwnode_gpiod_get() fails. ... > led.gpiod = devm_fwnode_gpiod_get(dev, child, NULL, GPIOD_ASIS, > NULL); > if (IS_ERR(led.gpiod)) { > + dev_err(dev, "Failed to get gpio '%pfw': %ld\n", > + child, PTR_ERR(led.gpiod)); Perhaps %pe ? > fwnode_handle_put(child); > return ERR_CAST(led.gpiod); > }
Hi Andy, Am 06.11.23 um 12:19 schrieb Andy Shevchenko: > On Sun, Nov 05, 2023 at 04:49:39PM +0100, Stefan Wahren wrote: >> In case leds-gpio fails to get the GPIO from the DT (e.g. the GPIO is >> already requested) the driver doesn't provide any helpful error log: >> >> leds-gpio: probe of leds failed with error -16 >> >> So add a new error log in case devm_fwnode_gpiod_get() fails. > ... > >> led.gpiod = devm_fwnode_gpiod_get(dev, child, NULL, GPIOD_ASIS, >> NULL); >> if (IS_ERR(led.gpiod)) { >> + dev_err(dev, "Failed to get gpio '%pfw': %ld\n", >> + child, PTR_ERR(led.gpiod)); > Perhaps %pe ? i notice that i need to use dev_err_probe because of EPROBE_DEFER anyway. So i will drop the second parameter in the next version. > >> fwnode_handle_put(child); >> return ERR_CAST(led.gpiod); >> }
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 710c319ad312..284a9e66fd9e 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -172,6 +172,8 @@ static struct gpio_leds_priv *gpio_leds_create(struct device *dev) led.gpiod = devm_fwnode_gpiod_get(dev, child, NULL, GPIOD_ASIS, NULL); if (IS_ERR(led.gpiod)) { + dev_err(dev, "Failed to get gpio '%pfw': %ld\n", + child, PTR_ERR(led.gpiod)); fwnode_handle_put(child); return ERR_CAST(led.gpiod); }
In case leds-gpio fails to get the GPIO from the DT (e.g. the GPIO is already requested) the driver doesn't provide any helpful error log: leds-gpio: probe of leds failed with error -16 So add a new error log in case devm_fwnode_gpiod_get() fails. Signed-off-by: Stefan Wahren <wahrenst@gmx.net> --- drivers/leds/leds-gpio.c | 2 ++ 1 file changed, 2 insertions(+) -- 2.34.1