| Message ID | 20231103083625.1229008-3-sakari.ailus@linux.intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Make fwnode_property_get_reference_args accept NULL args | expand |
On Fri, Nov 03, 2023 at 10:36:24AM +0200, Sakari Ailus wrote: > fwnode_get_property_reference_args() may not be called with args argument > NULL and while OF already supports this. Add the missing NULL check. > > The purpose is to be able to count the references. > > Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()") > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/base/swnode.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c > index 1886995a0b3a..079bd14bdedc 100644 > --- a/drivers/base/swnode.c > +++ b/drivers/base/swnode.c > @@ -541,6 +541,9 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode, > if (nargs > NR_FWNODE_REFERENCE_ARGS) > return -EINVAL; > > + if (!args) > + return 0; > + > args->fwnode = software_node_get(refnode); > args->nargs = nargs; > > -- > 2.39.2
diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c index 1886995a0b3a..079bd14bdedc 100644 --- a/drivers/base/swnode.c +++ b/drivers/base/swnode.c @@ -541,6 +541,9 @@ software_node_get_reference_args(const struct fwnode_handle *fwnode, if (nargs > NR_FWNODE_REFERENCE_ARGS) return -EINVAL; + if (!args) + return 0; + args->fwnode = software_node_get(refnode); args->nargs = nargs;
fwnode_get_property_reference_args() may not be called with args argument NULL and while OF already supports this. Add the missing NULL check. The purpose is to be able to count the references. Fixes: b06184acf751 ("software node: Add software_node_get_reference_args()") Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- drivers/base/swnode.c | 3 +++ 1 file changed, 3 insertions(+)