| Message ID | 20231109220151.10654-2-u.kleine-koenig@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | fb: amifb: Convert to platform remove callback returning void | expand |
Hi Uwe, On Thu, Nov 9, 2023 at 11:02 PM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > As described in the added code comment, a reference to .exit.text is ok > for drivers registered via module_platform_driver_probe(). Make this > explicit to prevent a section mismatch warning. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks for your patch! Why am I not seeing the actual section mismatch warning, not even with W=1? Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hello, On Fri, Nov 10, 2023 at 08:58:37AM +0100, Geert Uytterhoeven wrote: > On Thu, Nov 9, 2023 at 11:02 PM Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: > > As described in the added code comment, a reference to .exit.text is ok > > for drivers registered via module_platform_driver_probe(). Make this > > explicit to prevent a section mismatch warning. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Thanks for your patch! > Why am I not seeing the actual section mismatch warning, not even > with W=1? Do you have f177cd0c15fcc7bdbb68d8d1a3166dead95314c8 in your tree? And note it's only there if you compile the driver as a module and it is only emitted once you completed the whole build. Best regards Uwe
Hi Uwe, On Fri, Nov 10, 2023 at 9:57 AM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > On Fri, Nov 10, 2023 at 08:58:37AM +0100, Geert Uytterhoeven wrote: > > On Thu, Nov 9, 2023 at 11:02 PM Uwe Kleine-König > > <u.kleine-koenig@pengutronix.de> wrote: > > > As described in the added code comment, a reference to .exit.text is ok > > > for drivers registered via module_platform_driver_probe(). Make this > > > explicit to prevent a section mismatch warning. > > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > > > Thanks for your patch! > > Why am I not seeing the actual section mismatch warning, not even > > with W=1? > > Do you have f177cd0c15fcc7bdbb68d8d1a3166dead95314c8 in your tree? And Yes I have. > note it's only there if you compile the driver as a module and it is > only emitted once you completed the whole build. Thanks, I do see it in a modular build. Gr{oetje,eeting}s, Geert
diff --git a/drivers/video/fbdev/amifb.c b/drivers/video/fbdev/amifb.c index b18c6b4f129a..4a1bc693cebd 100644 --- a/drivers/video/fbdev/amifb.c +++ b/drivers/video/fbdev/amifb.c @@ -3768,7 +3768,13 @@ static int __exit amifb_remove(struct platform_device *pdev) return 0; } -static struct platform_driver amifb_driver = { +/* + * amifb_remove() lives in .exit.text. For drivers registered via + * module_platform_driver_probe() this ok because they cannot get unboud at + * runtime. The driver needs to be marked with __refdata, otherwise modpost + * triggers a section mismatch warning. + */ +static struct platform_driver amifb_driver __refdata = { .remove = __exit_p(amifb_remove), .driver = { .name = "amiga-video",
As described in the added code comment, a reference to .exit.text is ok for drivers registered via module_platform_driver_probe(). Make this explicit to prevent a section mismatch warning. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/video/fbdev/amifb.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)