diff mbox series

drm/msm/gpu: Move gpu devcore's to gpu device

Message ID 20231115224409.240935-1-robdclark@gmail.com (mailing list archive)
State New, archived
Headers show
Series drm/msm/gpu: Move gpu devcore's to gpu device | expand

Commit Message

Rob Clark Nov. 15, 2023, 10:44 p.m. UTC 
From: Rob Clark <robdclark@chromium.org>

The dpu devcore's are already associated with the dpu device.  So we
should associate the gpu devcore's with the gpu device, for easier
classification.

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
 drivers/gpu/drm/msm/msm_gpu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Abhinav Kumar Nov. 15, 2023, 10:58 p.m. UTC | #1 
On 11/15/2023 2:44 PM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
> 
> The dpu devcore's are already associated with the dpu device.  So we
> should associate the gpu devcore's with the gpu device, for easier
> classification.
> 
> Signed-off-by: Rob Clark <robdclark@chromium.org>

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Dmitry Baryshkov Nov. 16, 2023, 10 p.m. UTC | #2 
On Thu, 16 Nov 2023 at 00:58, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>
>
>
> On 11/15/2023 2:44 PM, Rob Clark wrote:
> > From: Rob Clark <robdclark@chromium.org>
> >
> > The dpu devcore's are already associated with the dpu device.  So we
> > should associate the gpu devcore's with the gpu device, for easier
> > classification.
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
>
> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
index cfcb4317afdb..3fad5d58262f 100644
--- a/drivers/gpu/drm/msm/msm_gpu.c
+++ b/drivers/gpu/drm/msm/msm_gpu.c
@@ -292,8 +292,7 @@  static void msm_gpu_crashstate_capture(struct msm_gpu *gpu,
 	/* Set the active crash state to be dumped on failure */
 	gpu->crashstate = state;
 
-	/* FIXME: Release the crashstate if this errors out? */
-	dev_coredumpm(gpu->dev->dev, THIS_MODULE, gpu, 0, GFP_KERNEL,
+	dev_coredumpm(&gpu->pdev->dev, THIS_MODULE, gpu, 0, GFP_KERNEL,
 		msm_gpu_devcoredump_read, msm_gpu_devcoredump_free);
 }
 #else