diff mbox series

[net-next,V2,01/13] net/mlx5: print change on SW reset semaphore returns busy

Message ID 20231115193649.8756-2-saeed@kernel.org (mailing list archive)
State Accepted
Commit 7b2bfd4ebf796ec4c5ff86b2531b26766ab2fd61
Delegated to: Netdev Maintainers
Headers show
Series [net-next,V2,01/13] net/mlx5: print change on SW reset semaphore returns busy | expand

Checks

Context Check Description
netdev/series_format success Pull request is its own cover letter
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1134 this patch: 1134
netdev/cc_maintainers success CCed 4 of 4 maintainers
netdev/build_clang success Errors and warnings before: 1161 this patch: 1161
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1161 this patch: 1161
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 11 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Saeed Mahameed Nov. 15, 2023, 7:36 p.m. UTC
From: Moshe Shemesh <moshe@nvidia.com>

While collecting crdump as part of fw_fatal health reporter dump the PF
may fail to lock the SW reset semaphore. Change the print to indicate if
it was due to another PF locked the semaphore already and so trying to
lock the semaphore returned -EBUSY.

Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
Reviewed-by: Shay Drory <shayd@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/diag/crdump.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Nov. 18, 2023, 5:50 p.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Saeed Mahameed <saeedm@nvidia.com>:

On Wed, 15 Nov 2023 11:36:37 -0800 you wrote:
> From: Moshe Shemesh <moshe@nvidia.com>
> 
> While collecting crdump as part of fw_fatal health reporter dump the PF
> may fail to lock the SW reset semaphore. Change the print to indicate if
> it was due to another PF locked the semaphore already and so trying to
> lock the semaphore returned -EBUSY.
> 
> [...]

Here is the summary with links:
  - [net-next,V2,01/13] net/mlx5: print change on SW reset semaphore returns busy
    https://git.kernel.org/netdev/net-next/c/7b2bfd4ebf79
  - [net-next,V2,02/13] net/mlx5: Allow sync reset flow when BF MGT interface device is present
    https://git.kernel.org/netdev/net-next/c/cecf44ea1a1f
  - [net-next,V2,03/13] net/mlx5e: Some cleanup in mlx5e_tc_stats_matchall()
    https://git.kernel.org/netdev/net-next/c/312eb3fd6244
  - [net-next,V2,04/13] net/mlx5: Annotate struct mlx5_fc_bulk with __counted_by
    https://git.kernel.org/netdev/net-next/c/0f452a862a9f
  - [net-next,V2,05/13] net/mlx5: Annotate struct mlx5_flow_handle with __counted_by
    https://git.kernel.org/netdev/net-next/c/9454e5643392
  - [net-next,V2,06/13] net/mlx5: simplify mlx5_set_driver_version string assignments
    https://git.kernel.org/netdev/net-next/c/10b49d0e7651
  - [net-next,V2,07/13] net/mlx5e: Access array with enum values instead of magic numbers
    https://git.kernel.org/netdev/net-next/c/88e928b22930
  - [net-next,V2,08/13] net/mlx5: Refactor real time clock operation checks for PHC
    https://git.kernel.org/netdev/net-next/c/330af90c4b43
  - [net-next,V2,09/13] net/mlx5: Initialize clock->ptp_info inside mlx5_init_timer_clock
    https://git.kernel.org/netdev/net-next/c/4395d9de4e21
  - [net-next,V2,10/13] net/mlx5: Convert scaled ppm values outside the s32 range for PHC frequency adjustments
    https://git.kernel.org/netdev/net-next/c/78c1b26754d9
  - [net-next,V2,11/13] net/mlx5: Query maximum frequency adjustment of the PTP hardware clock
    https://git.kernel.org/netdev/net-next/c/4aea6a6d61cd
  - [net-next,V2,12/13] net/mlx5e: Add local loopback counter to vport rep stats
    https://git.kernel.org/netdev/net-next/c/b2a62e56b173
  - [net-next,V2,13/13] net/mlx5e: Remove early assignment to netdev->features
    https://git.kernel.org/netdev/net-next/c/23ec6972865b

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/diag/crdump.c b/drivers/net/ethernet/mellanox/mlx5/core/diag/crdump.c
index 28d02749d3c4..7659ad21e6e5 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/diag/crdump.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/crdump.c
@@ -55,7 +55,10 @@  int mlx5_crdump_collect(struct mlx5_core_dev *dev, u32 *cr_data)
 	ret = mlx5_vsc_sem_set_space(dev, MLX5_SEMAPHORE_SW_RESET,
 				     MLX5_VSC_LOCK);
 	if (ret) {
-		mlx5_core_warn(dev, "Failed to lock SW reset semaphore\n");
+		if (ret == -EBUSY)
+			mlx5_core_info(dev, "SW reset semaphore is already in use\n");
+		else
+			mlx5_core_warn(dev, "Failed to lock SW reset semaphore\n");
 		goto unlock_gw;
 	}