| Message ID | 20231117104018.3435212-1-sumang@marvell.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5f228d7c8a539714c1e9b7e7534f76bb7979f268 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2] octeontx2-pf: Fix memory leak during interface down | expand |
On Fri, Nov 17, 2023 at 04:10:18PM +0530, Suman Ghosh wrote: > During 'ifconfig <netdev> down' one RSS memory was not getting freed. > This patch fixes the same. > > Fixes: 81a4362016e7 ("octeontx2-pf: Add RSS multi group support") > Signed-off-by: Suman Ghosh <sumang@marvell.com> > --- > v2 changes: > - Updated fixes tag Thanks for the update, this now looks good to me. Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Fri, 17 Nov 2023 16:10:18 +0530 you wrote: > During 'ifconfig <netdev> down' one RSS memory was not getting freed. > This patch fixes the same. > > Fixes: 81a4362016e7 ("octeontx2-pf: Add RSS multi group support") > Signed-off-by: Suman Ghosh <sumang@marvell.com> > --- > v2 changes: > - Updated fixes tag > > [...] Here is the summary with links: - [net,v2] octeontx2-pf: Fix memory leak during interface down https://git.kernel.org/netdev/net/c/5f228d7c8a53 You are awesome, thank you!
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c index 91b99fd70361..ba95ac913274 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c @@ -1934,6 +1934,8 @@ int otx2_stop(struct net_device *netdev) /* Clear RSS enable flag */ rss = &pf->hw.rss_info; rss->enable = false; + if (!netif_is_rxfh_configured(netdev)) + kfree(rss->rss_ctx[DEFAULT_RSS_CONTEXT_GROUP]); /* Cleanup Queue IRQ */ vec = pci_irq_vector(pf->pdev,
During 'ifconfig <netdev> down' one RSS memory was not getting freed. This patch fixes the same. Fixes: 81a4362016e7 ("octeontx2-pf: Add RSS multi group support") Signed-off-by: Suman Ghosh <sumang@marvell.com> --- v2 changes: - Updated fixes tag drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 ++ 1 file changed, 2 insertions(+)