| Message ID | 20231120100258.3428-1-yu-chang.lee@mediatek.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
| Series | [v4] dt-bindings: arm: mediatek: mmsys: Add VPPSYS compatible for MT8188 | expand |
On 20/11/2023 11:02, yu-chang.lee wrote: > For MT8188, VPPSYS0 and VPPSYS1 are 2 display pipes with > hardware differences in power domains, clocks and subsystem counts, > which should be probed from mtk-mmsys driver to populate device by > platform_device_register_data then start its own clock driver. > > Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com> > --- > Change in v4: > - Squashed binding patches > - This patch is based on [1] > [1] soc: mediatek: mmsys: Add support for MT8188 VPPSYS > - https://patchwork.kernel.org/project/linux-mediatek/patch/20231117054345.15859-1-yu-chang.lee@mediatek.com/ > This probably should stay part of previous patchset. Why splitting it? Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, 2023-11-20 at 11:09 +0100, Krzysztof Kozlowski wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 20/11/2023 11:02, yu-chang.lee wrote: > > For MT8188, VPPSYS0 and VPPSYS1 are 2 display pipes with > > hardware differences in power domains, clocks and subsystem counts, > > which should be probed from mtk-mmsys driver to populate device by > > platform_device_register_data then start its own clock driver. > > > > Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com> > > --- > > Change in v4: > > - Squashed binding patches > > - This patch is based on [1] > > [1] soc: mediatek: mmsys: Add support for MT8188 VPPSYS > > - > https://patchwork.kernel.org/project/linux-mediatek/patch/20231117054345.15859-1-yu-chang.lee@mediatek.com/ > > > > This probably should stay part of previous patchset. Why splitting > it? > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof > Thank you for your time and effort. I misunderstood that you want me to send the binding patches as a independent serie in previous discussion. Only until now I squashed them, but the driver patch has already been submitted... Should I resend all of these pathes as a serie again? Thanks, Best Regards, yuchang
Il 20/11/23 11:26, Yu-chang Lee (李禹璋) ha scritto: > On Mon, 2023-11-20 at 11:09 +0100, Krzysztof Kozlowski wrote: >> >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> On 20/11/2023 11:02, yu-chang.lee wrote: >>> For MT8188, VPPSYS0 and VPPSYS1 are 2 display pipes with >>> hardware differences in power domains, clocks and subsystem counts, >>> which should be probed from mtk-mmsys driver to populate device by >>> platform_device_register_data then start its own clock driver. >>> >>> Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com> >>> --- >>> Change in v4: >>> - Squashed binding patches >>> - This patch is based on [1] >>> [1] soc: mediatek: mmsys: Add support for MT8188 VPPSYS >>> - >> https://patchwork.kernel.org/project/linux-mediatek/patch/20231117054345.15859-1-yu-chang.lee@mediatek.com/ >>> >> >> This probably should stay part of previous patchset. Why splitting >> it? >> >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> Best regards, >> Krzysztof >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Thank you for your time and effort. I misunderstood that you want me to > send the binding patches as a independent serie in previous discussion. > Only until now I squashed them, but the driver patch has already been > submitted... Should I resend all of these pathes as a serie again? > For this time it's okay, I can pick those separately... but for the next time, please, yes, the two are related so they should go in one series. Thanks, Angelo > Thanks, > > Best Regards, > yuchang
diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml index 536f5a5ebd24..50324248b965 100644 --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml @@ -32,6 +32,8 @@ properties: - mediatek,mt8183-mmsys - mediatek,mt8186-mmsys - mediatek,mt8188-vdosys0 + - mediatek,mt8188-vppsys0 + - mediatek,mt8188-vppsys1 - mediatek,mt8192-mmsys - mediatek,mt8195-vdosys1 - mediatek,mt8195-vppsys0 diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml index d7214d97b2ba..860570320545 100644 --- a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml @@ -43,8 +43,6 @@ properties: - mediatek,mt8188-vdecsys - mediatek,mt8188-vdecsys-soc - mediatek,mt8188-vencsys - - mediatek,mt8188-vppsys0 - - mediatek,mt8188-vppsys1 - mediatek,mt8188-wpesys - mediatek,mt8188-wpesys-vpp0
For MT8188, VPPSYS0 and VPPSYS1 are 2 display pipes with hardware differences in power domains, clocks and subsystem counts, which should be probed from mtk-mmsys driver to populate device by platform_device_register_data then start its own clock driver. Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com> --- Change in v4: - Squashed binding patches - This patch is based on [1] [1] soc: mediatek: mmsys: Add support for MT8188 VPPSYS - https://patchwork.kernel.org/project/linux-mediatek/patch/20231117054345.15859-1-yu-chang.lee@mediatek.com/ Changes in v3: - Separate binding patch from driver patch Changes in v2: - Refine commit message - Refine commit title .../devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml | 2 ++ .../devicetree/bindings/clock/mediatek,mt8188-clock.yaml | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-)