| Message ID | 20231108134426.4174699-1-dario.binacchi@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] ARM: dts: stm32f469-disco: use the same 3v3 for SD and DSI nodes | expand |
Hi Dario On 11/8/23 14:44, Dario Binacchi wrote: > In the board schematic, the power supply for the SD card is the same 3.3 > volts used to power the LCD panel and other peripherals. By generalizing > the name of the voltage regulator, it simplifies the device tree and makes > it more readable. > > Link: https://www.st.com/en/evaluation-tools/32f469idiscovery.html#cad-resources > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > > --- Applied on stm32-next. Thanks for this clean-up. Alex > arch/arm/boot/dts/st/stm32f469-disco.dts | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/arch/arm/boot/dts/st/stm32f469-disco.dts b/arch/arm/boot/dts/st/stm32f469-disco.dts > index cbbd521bf010..8a4f8ddd083d 100644 > --- a/arch/arm/boot/dts/st/stm32f469-disco.dts > +++ b/arch/arm/boot/dts/st/stm32f469-disco.dts > @@ -69,16 +69,9 @@ aliases { > serial0 = &usart3; > }; > > - mmc_vcard: mmc_vcard { > + vcc_3v3: vcc-3v3 { > compatible = "regulator-fixed"; > - regulator-name = "mmc_vcard"; > - regulator-min-microvolt = <3300000>; > - regulator-max-microvolt = <3300000>; > - }; > - > - vdd_dsi: vdd-dsi { > - compatible = "regulator-fixed"; > - regulator-name = "vdd_dsi"; > + regulator-name = "vcc_3v3"; > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > }; > @@ -164,7 +157,7 @@ panel@0 { > compatible = "orisetech,otm8009a"; > reg = <0>; /* dsi virtual channel (0..3) */ > reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>; > - power-supply = <&vdd_dsi>; > + power-supply = <&vcc_3v3>; > status = "okay"; > > port { > @@ -219,7 +212,7 @@ timer@2 { > > &sdio { > status = "okay"; > - vmmc-supply = <&mmc_vcard>; > + vmmc-supply = <&vcc_3v3>; > cd-gpios = <&gpiog 2 GPIO_ACTIVE_LOW>; > broken-cd; > pinctrl-names = "default", "opendrain";
diff --git a/arch/arm/boot/dts/st/stm32f469-disco.dts b/arch/arm/boot/dts/st/stm32f469-disco.dts index cbbd521bf010..8a4f8ddd083d 100644 --- a/arch/arm/boot/dts/st/stm32f469-disco.dts +++ b/arch/arm/boot/dts/st/stm32f469-disco.dts @@ -69,16 +69,9 @@ aliases { serial0 = &usart3; }; - mmc_vcard: mmc_vcard { + vcc_3v3: vcc-3v3 { compatible = "regulator-fixed"; - regulator-name = "mmc_vcard"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - }; - - vdd_dsi: vdd-dsi { - compatible = "regulator-fixed"; - regulator-name = "vdd_dsi"; + regulator-name = "vcc_3v3"; regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; }; @@ -164,7 +157,7 @@ panel@0 { compatible = "orisetech,otm8009a"; reg = <0>; /* dsi virtual channel (0..3) */ reset-gpios = <&gpioh 7 GPIO_ACTIVE_LOW>; - power-supply = <&vdd_dsi>; + power-supply = <&vcc_3v3>; status = "okay"; port { @@ -219,7 +212,7 @@ timer@2 { &sdio { status = "okay"; - vmmc-supply = <&mmc_vcard>; + vmmc-supply = <&vcc_3v3>; cd-gpios = <&gpiog 2 GPIO_ACTIVE_LOW>; broken-cd; pinctrl-names = "default", "opendrain";
In the board schematic, the power supply for the SD card is the same 3.3 volts used to power the LCD panel and other peripherals. By generalizing the name of the voltage regulator, it simplifies the device tree and makes it more readable. Link: https://www.st.com/en/evaluation-tools/32f469idiscovery.html#cad-resources Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- arch/arm/boot/dts/st/stm32f469-disco.dts | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-)