| Message ID | 20231120224912.1421916-7-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xen: Enable -Wwrite-strings | expand |
On 20/11/2023 10:49 pm, Andrew Cooper wrote: > The codebase is now -Wwrite-strings clean. Activate the option to cause > string literals to have a const type, and prevent any violations of MISRA Rule > 7.4 being reintroduced. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> > --- > CC: Jan Beulich <JBeulich@suse.com> > CC: Roger Pau Monné <roger.pau@citrix.com> > CC: Wei Liu <wl@xen.org> > CC: Stefano Stabellini <sstabellini@kernel.org> > CC: Julien Grall <julien@xen.org> > CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com> > CC: Bertrand Marquis <bertrand.marquis@arm.com> > CC: Michal Orzel <michal.orzel@amd.com> > CC: Roberto Bagnara <roberto.bagnara@bugseng.com> > CC: Nicola Vetrini <nicola.vetrini@bugseng.com> > --- > xen/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/Makefile b/xen/Makefile > index 7b869f4b3037..ca571103c868 100644 > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -392,7 +392,7 @@ endif > CFLAGS-$(CONFIG_CC_SPLIT_SECTIONS) += -ffunction-sections -fdata-sections > > CFLAGS += -nostdinc -fno-builtin -fno-common > -CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith > +CFLAGS += -Werror -Wredundant-decls -Wwrite-strings -Wno-pointer-arith > $(call cc-option-add,CFLAGS,CC,-Wvla) > CFLAGS += -pipe -D__XEN__ -include $(srctree)/include/xen/config.h > CFLAGS-$(CONFIG_DEBUG_INFO) += -g I meant to say. I've checked our minimum compiler versions, and -Wwrite-strings is supported by everything. ~Andrew
On Mon, 20 Nov 2023, Andrew Cooper wrote: > The codebase is now -Wwrite-strings clean. Activate the option to cause > string literals to have a const type, and prevent any violations of MISRA Rule > 7.4 being reintroduced. > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Excellent! Acked-by: Stefano Stabellini <sstabellini@kernel.org> > --- > CC: Jan Beulich <JBeulich@suse.com> > CC: Roger Pau Monné <roger.pau@citrix.com> > CC: Wei Liu <wl@xen.org> > CC: Stefano Stabellini <sstabellini@kernel.org> > CC: Julien Grall <julien@xen.org> > CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com> > CC: Bertrand Marquis <bertrand.marquis@arm.com> > CC: Michal Orzel <michal.orzel@amd.com> > CC: Roberto Bagnara <roberto.bagnara@bugseng.com> > CC: Nicola Vetrini <nicola.vetrini@bugseng.com> > --- > xen/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/Makefile b/xen/Makefile > index 7b869f4b3037..ca571103c868 100644 > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -392,7 +392,7 @@ endif > CFLAGS-$(CONFIG_CC_SPLIT_SECTIONS) += -ffunction-sections -fdata-sections > > CFLAGS += -nostdinc -fno-builtin -fno-common > -CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith > +CFLAGS += -Werror -Wredundant-decls -Wwrite-strings -Wno-pointer-arith > $(call cc-option-add,CFLAGS,CC,-Wvla) > CFLAGS += -pipe -D__XEN__ -include $(srctree)/include/xen/config.h > CFLAGS-$(CONFIG_DEBUG_INFO) += -g > -- > 2.30.2 > >
diff --git a/xen/Makefile b/xen/Makefile index 7b869f4b3037..ca571103c868 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -392,7 +392,7 @@ endif CFLAGS-$(CONFIG_CC_SPLIT_SECTIONS) += -ffunction-sections -fdata-sections CFLAGS += -nostdinc -fno-builtin -fno-common -CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith +CFLAGS += -Werror -Wredundant-decls -Wwrite-strings -Wno-pointer-arith $(call cc-option-add,CFLAGS,CC,-Wvla) CFLAGS += -pipe -D__XEN__ -include $(srctree)/include/xen/config.h CFLAGS-$(CONFIG_DEBUG_INFO) += -g
The codebase is now -Wwrite-strings clean. Activate the option to cause string literals to have a const type, and prevent any violations of MISRA Rule 7.4 being reintroduced. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Jan Beulich <JBeulich@suse.com> CC: Roger Pau Monné <roger.pau@citrix.com> CC: Wei Liu <wl@xen.org> CC: Stefano Stabellini <sstabellini@kernel.org> CC: Julien Grall <julien@xen.org> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com> CC: Bertrand Marquis <bertrand.marquis@arm.com> CC: Michal Orzel <michal.orzel@amd.com> CC: Roberto Bagnara <roberto.bagnara@bugseng.com> CC: Nicola Vetrini <nicola.vetrini@bugseng.com> --- xen/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)